Happyr\ApiClient\Api\UserManagement

Complexity

Total Complexity

3

Size/Duplication

Total Lines	55
Duplicated Lines	16.36 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	9	9	1
A	show()	0	8	1
A	merge()	0	11	1

<?php

namespace Happyr\ApiClient\Api;

use Happyr\ApiClient\Assert;
use Happyr\ApiClient\Exception;
use Happyr\ApiClient\Model\UserManagement\User;
use Psr\Http\Message\ResponseInterface;

/**
 * @author Tobias Nyholm <tobias.nyholm@gmail.com>
 */
final class UserManagement extends HttpApi
{
    /**
     * @param string $user
     *
     * @throws Exception
     *
     * @return User|ResponseInterface
     */
    public function show($user)
    {
        Assert::stringNotEmpty($user);

        $response = $this->httpGet('/api/user/info', ['user' => $user]);

        return $this->hydrateResponse($response, User::class);
    }

    /**
     * @param string $user
     * @param array  $param Valid keys are email, name, gender, birthday, country
     *
     * @throws Exception
     *
     * @return User|ResponseInterface
     */
    public function update($user, $param)

This method seems to be duplicated in your project.

    {
        Assert::stringNotEmpty($user);
        $param['user'] = $user;

        $response = $this->httpPost('/api/user/update/profile', $param);

        return $this->hydrateResponse($response, User::class);
    }
    /**
     * @param string $user the user ID we should merge personality data to.
     * @param string $from the user ID we should merge personality data from.
     *
     * @throws Exception
     *
     * @return User|ResponseInterface
     */
    public function merge($user, $from)
    {
        Assert::stringNotEmpty($user);
        Assert::stringNotEmpty($from);
        $param['user'] = $user;

$param was never initialized. Although not strictly required by PHP, it is generally a good practice to add $param = array(); before regardless.

        $param['from'] = $from;

        $response = $this->httpPost('/api/user/merge', $param);

        return $this->hydrateResponse($response, User::class);
    }
}