TransformerTest::testOutputArray() - Code Metrics - Inspection of "Better exception for messenger envelopes (#38)" - Happyr/message-serializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2c2ab2...58b6ad )

by Tobias

created 2020-04-03 09:42 UTC

TransformerTest::testOutputArray() A

↳ Parent: TransformerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	28
rs	9.472
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace Tests\Happyr\MessageSerializer\Transformer;

use Happyr\MessageSerializer\Transformer\Exception\TransformerNotFoundException;
use Happyr\MessageSerializer\Transformer\Transformer;
use Happyr\MessageSerializer\Transformer\TransformerInterface;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Messenger\Envelope;

class TransformerTest extends TestCase
{
    public function testOutputArray()
    {
        $fooTransformer = $this->getMockBuilder(TransformerInterface::class)
            ->setMethods(['getVersion', 'getIdentifier', 'getPayload', 'supportsTransform'])
            ->getMock();

        $version = 2;
        $identifier = 'foobar';
        $payload = ['foo' => 'bar'];

        $fooTransformer->method('getVersion')->willReturn($version);
        $fooTransformer->method('getIdentifier')->willReturn($identifier);
        $fooTransformer->method('supportsTransform')->willReturn(true);
        $fooTransformer->method('getPayload')->willReturn($payload);

        $transformer = new Transformer([$fooTransformer]);
        $output = $transformer->toArray(new \stdClass());

        $this->assertArrayHasKey('version', $output);
        $this->assertArrayHasKey('identifier', $output);
        $this->assertArrayHasKey('timestamp', $output);
        $this->assertArrayHasKey('payload', $output);

        $this->assertEquals($output['version'], $version);
        $this->assertEquals($output['identifier'], $identifier);
        $this->assertEquals($output['payload'], $payload);
        $this->assertEqualsWithDelta($output['timestamp'], time(), 3);
    }

    public function testTransformerNotFoundExceptionClass()

    {
        $transformer = new Transformer([]);
        $this->expectException(TransformerNotFoundException::class);
        $this->expectExceptionMessage('No transformer found for "stdClass"');
        $output = $transformer->toArray(new \stdClass());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testTransformerNotFoundExceptionInteger()

    {
        $transformer = new Transformer([]);
        $this->expectException(TransformerNotFoundException::class);
        $this->expectExceptionMessage('No transformer found for "integer"');
        $output = $transformer->toArray(4711);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testTransformerNotFoundExceptionEnvelope()

    {
        $transformer = new Transformer([]);
        $this->expectException(TransformerNotFoundException::class);
        $this->expectExceptionMessage('No transformer found for "Envelope<stdClass>"');
        $output = $transformer->toArray(new Envelope(new \stdClass()));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Tests\Happyr\MessageSerializer\Transformer;
6
7		use Happyr\MessageSerializer\Transformer\Exception\TransformerNotFoundException;
8		use Happyr\MessageSerializer\Transformer\Transformer;
9		use Happyr\MessageSerializer\Transformer\TransformerInterface;
10		use PHPUnit\Framework\TestCase;
11		use Symfony\Component\Messenger\Envelope;
12
13		class TransformerTest extends TestCase
14		{
15		public function testOutputArray()
16		{
17		$fooTransformer = $this->getMockBuilder(TransformerInterface::class)
18		->setMethods(['getVersion', 'getIdentifier', 'getPayload', 'supportsTransform'])
19		->getMock();
20
21		$version = 2;
22		$identifier = 'foobar';
23		$payload = ['foo' => 'bar'];
24
25		$fooTransformer->method('getVersion')->willReturn($version);
26		$fooTransformer->method('getIdentifier')->willReturn($identifier);
27		$fooTransformer->method('supportsTransform')->willReturn(true);
28		$fooTransformer->method('getPayload')->willReturn($payload);
29
30		$transformer = new Transformer([$fooTransformer]);
31		$output = $transformer->toArray(new \stdClass());
32
33		$this->assertArrayHasKey('version', $output);
34		$this->assertArrayHasKey('identifier', $output);
35		$this->assertArrayHasKey('timestamp', $output);
36		$this->assertArrayHasKey('payload', $output);
37
38		$this->assertEquals($output['version'], $version);
39		$this->assertEquals($output['identifier'], $identifier);
40		$this->assertEquals($output['payload'], $payload);
41		$this->assertEqualsWithDelta($output['timestamp'], time(), 3);
42		}
43
44	View Code Duplication	public function testTransformerNotFoundExceptionClass()
		0 ignored issues – show Duplication introduced 2020-04-03 09:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		$transformer = new Transformer([]);
47		$this->expectException(TransformerNotFoundException::class);
48		$this->expectExceptionMessage('No transformer found for "stdClass"');
49		$output = $transformer->toArray(new \stdClass());
		0 ignored issues – show Unused Code introduced 2020-04-03 09:43 UTC by Report Bug Copy Issue Report `$output` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
50		}
51
52	View Code Duplication	public function testTransformerNotFoundExceptionInteger()
		0 ignored issues – show Duplication introduced 2020-04-03 09:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$transformer = new Transformer([]);
55		$this->expectException(TransformerNotFoundException::class);
56		$this->expectExceptionMessage('No transformer found for "integer"');
57		$output = $transformer->toArray(4711);
		0 ignored issues – show Documentation introduced 2020-04-03 09:43 UTC by Report Bug Copy Issue Report `4711` is of type `integer`, but the function expects a `object`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2020-04-03 09:43 UTC by Report Bug Copy Issue Report `$output` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
58		}
59
60	View Code Duplication	public function testTransformerNotFoundExceptionEnvelope()
		0 ignored issues – show Duplication introduced 2020-04-03 09:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		$transformer = new Transformer([]);
63		$this->expectException(TransformerNotFoundException::class);
64		$this->expectExceptionMessage('No transformer found for "Envelope<stdClass>"');
65		$output = $transformer->toArray(new Envelope(new \stdClass()));
		0 ignored issues – show Unused Code introduced 2020-04-03 09:43 UTC by Report Bug Copy Issue Report `$output` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
66		}
67		}
68

Happyr / message-serializer

Push — master ( 2c2ab2...58b6ad )

TransformerTest::testOutputArray() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like