ResponseConverter::convert() - Code Metrics - Inspection of "Implementing use of PSR7" - Happyr/LinkedIn-API-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#73)

by Tobias

created 2015-12-20 23:04 UTC

ResponseConverter::convert() C

↳ Parent: ResponseConverter

Complexity

Conditions	10
Paths	7

Size

Total Lines	22
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	22
rs	6.1369
cc	10
eloc	17
nc	7
nop	3

How to fix Complexity

<?php

namespace Happyr\LinkedIn\Http;

use Happyr\LinkedIn\Exception\InvalidArgumentException;
use Happyr\LinkedIn\Exception\LinkedInTransferException;
use Psr\Http\Message\ResponseInterface;

class ResponseConverter
{
    /**
     * @param ResponseInterface $response
     * @param string            $format
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string            $dataType
     *
     * @return ResponseInterface|\Psr\Http\Message\StreamInterface|\SimpleXMLElement|string
     *
     * @throws InvalidArgumentException
     * @throws LinkedInTransferException
     */
    public static function convert(ResponseInterface $response, $requestFormat, $dataType)
    {
        if (($requestFormat === 'json' && $dataType === 'simple_xml') ||
            ($requestFormat === 'xml' && $dataType === 'array')) {
            throw new InvalidArgumentException('Can not use reponse data format "%s" with the request format "%s".', $dataType, $requestFormat);
        }

        switch ($dataType) {
            case 'array':
                return self::convertToArray($response);
            case 'string':
                return $response->getBody()->__toString();
            case 'simple_xml':
                return self::convertToSimpleXml($response);
            case 'stream':
                return $response->getBody();
            case 'psr7':
                return $response;
            default:
                throw new InvalidArgumentException('Format "%s" is not supported', $dataType);
        }
    }

    /**
     * @param ResponseInterface $response
     *
     * @return string
     */
    public static function convertToArray(ResponseInterface $response)
    {
        return json_decode($response->getBody(), true);
    }

    /**
     * @param ResponseInterface $response
     *
     * @return \SimpleXMLElement
     *
     * @throws LinkedInTransferException
     */
    public static function convertToSimpleXml(ResponseInterface $response)
    {
        $body = $response->getBody();
        try {
            return new \SimpleXMLElement((string) $body ?: '<root />');
        } catch (\Exception $e) {
            throw new LinkedInTransferException('Unable to parse response body into XML.');
        }
    }
}


1			<?php
2
3			namespace Happyr\LinkedIn\Http;
4
5			use Happyr\LinkedIn\Exception\InvalidArgumentException;
6			use Happyr\LinkedIn\Exception\LinkedInTransferException;
7			use Psr\Http\Message\ResponseInterface;
8
9			class ResponseConverter
10			{
11			/**
12			* @param ResponseInterface $response
13			* @param string $format
			0 ignored issues – show Documentation introduced 2015-12-19 10:57 UTC by Report Bug Copy Issue Report There is no parameter named `$format`. Did you maybe mean `$requestFormat`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
14			* @param string $dataType
15			*
16			* @return ResponseInterface\|\Psr\Http\Message\StreamInterface\|\SimpleXMLElement\|string
17			*
18			* @throws InvalidArgumentException
19			* @throws LinkedInTransferException
20			*/
21			public static function convert(ResponseInterface $response, $requestFormat, $dataType)
22			{
23			if (($requestFormat === 'json' && $dataType === 'simple_xml') \|\|
24			($requestFormat === 'xml' && $dataType === 'array')) {
25			throw new InvalidArgumentException('Can not use reponse data format "%s" with the request format "%s".', $dataType, $requestFormat);
26			}
27
28			switch ($dataType) {
29			case 'array':
30			return self::convertToArray($response);
31			case 'string':
32			return $response->getBody()->__toString();
33			case 'simple_xml':
34			return self::convertToSimpleXml($response);
35			case 'stream':
36			return $response->getBody();
37			case 'psr7':
38			return $response;
39			default:
40			throw new InvalidArgumentException('Format "%s" is not supported', $dataType);
41			}
42			}
43
44			/**
45			* @param ResponseInterface $response
46			*
47			* @return string
48			*/
49			public static function convertToArray(ResponseInterface $response)
50			{
51			return json_decode($response->getBody(), true);
52			}
53
54			/**
55			* @param ResponseInterface $response
56			*
57			* @return \SimpleXMLElement
58			*
59			* @throws LinkedInTransferException
60			*/
61			public static function convertToSimpleXml(ResponseInterface $response)
62			{
63			$body = $response->getBody();
64			try {
65			return new \SimpleXMLElement((string) $body ?: '<root />');
66			} catch (\Exception $e) {
67			throw new LinkedInTransferException('Unable to parse response body into XML.');
68			}
69			}
70			}
71

Happyr / LinkedIn-API-client

Pull Request — master (#73)

ResponseConverter::convert() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like