GlobalVariableGetter - Code Metrics - Inspection of "Merge pull request #73 from Happyr/psr7" - Happyr/LinkedIn-API-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b65b29...f39982 )

by Tobias

created 2016-01-01 13:37 UTC

GlobalVariableGetter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
wmc	5
c	3
b	0
f	1
lcom	0
cbo	0
dl	0
loc	38
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	has()	0	8	2
A	get()	0	12	3

<?php

namespace Happyr\LinkedIn\Http;

/**
 * Look in $_REQUEST and $_GET if there is a variable we want.
 *
 * @author Tobias Nyholm <[email protected]>
 */
class GlobalVariableGetter
{
    /**
     * Returns true iff the $_REQUEST or $_GET variables has a key with $name.
     *
     * @param string $name
     *
     * @return bool
     */
    public static function has($name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_REQUEST[$name])) {
            return true;
        }

        return isset($_GET[$name]);
    }

    /**
     * Returns the value in $_REQUEST[$name] or $_GET[$name] if the former was empty. If no value found, return null.
     *
     * @param string $name
     *
     * @return mixed|null
     */
    public static function get($name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_REQUEST[$name])) {
            return $_REQUEST[$name];
        }

        if (isset($_GET[$name])) {
            return $_GET[$name];
        }

        return;
    }
}


1			<?php
2
3			namespace Happyr\LinkedIn\Http;
4
5			/**
6			* Look in $_REQUEST and $_GET if there is a variable we want.
7			*
8			* @author Tobias Nyholm <[email protected]>
9			*/
10			class GlobalVariableGetter
11			{
12			/**
13			* Returns true iff the $_REQUEST or $_GET variables has a key with $name.
14			*
15			* @param string $name
16			*
17			* @return bool
18			*/
19			public static function has($name)
			2 ignored issues – show Coding Style introduced 2015-12-19 10:57 UTC by Report Bug Copy Issue Report `has` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2015-12-19 10:57 UTC by Report Bug Copy Issue Report `has` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
20			{
21			if (isset($_REQUEST[$name])) {
22			return true;
23			}
24
25			return isset($_GET[$name]);
26			}
27
28			/**
29			* Returns the value in $_REQUEST[$name] or $_GET[$name] if the former was empty. If no value found, return null.
30			*
31			* @param string $name
32			*
33			* @return mixed\|null
34			*/
35			public static function get($name)
			2 ignored issues – show Coding Style introduced 2015-12-19 10:57 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2015-12-19 10:57 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
36			{
37			if (isset($_REQUEST[$name])) {
38			return $_REQUEST[$name];
39			}
40
41			if (isset($_GET[$name])) {
42			return $_GET[$name];
43			}
44
45			return;
46			}
47			}
48

Happyr / LinkedIn-API-client

Push — master ( b65b29...f39982 )

GlobalVariableGetter A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like