ResponseConverter::convert() - Code Metrics - Inspection of "Implementing use of PSR7" - Happyr/LinkedIn-API-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#73)

by Tobias

created 2015-12-20 21:17 UTC

ResponseConverter::convert() C

↳ Parent: ResponseConverter

Complexity

Conditions	10
Paths	7

Size

Total Lines	22
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	22
rs	6.1369
cc	10
eloc	17
nc	7
nop	3

How to fix Complexity

<?php

namespace Happyr\LinkedIn\Http;

use Happyr\LinkedIn\Exceptions\LinkedInApiException;
use Psr\Http\Message\ResponseInterface;

class ResponseConverter
{
    /**
     * @param ResponseInterface $response
     * @param string            $format
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return ResponseInterface|\Psr\Http\Message\StreamInterface|\SimpleXMLElement|string
     *
     * @throws LinkedInApiException
     */
    public static function convert(ResponseInterface $response, $requestFormat, $dataType)
    {
        if (($requestFormat === 'json' && $dataType === 'simple_xml') ||
            ($requestFormat === 'xml' && $dataType === 'array')) {
            throw new \InvalidArgumentException(sprintf('Can not use reponse data format "%s" with the request format "s%"', $dataType, $requestFormat));
        }

        switch ($dataType) {
            case 'array':
                return self::convertToArray($response);
            case 'string':
                return $response->getBody()->__toString();
            case 'simple_xml':
                return self::convertToSimpleXml($response);
            case 'stream':
                return $response->getBody();
            case 'psr7':
                return $response;
            default:
                throw new \InvalidArgumentException(sprintf('Format "%s" is not supported', $dataType));
        }
    }

    /**
     * @param ResponseInterface $response
     *
     * @return string
     */
    public static function convertToArray(ResponseInterface $response)
    {
        return json_decode($response->getBody(), true);
    }

    /**
     * @param ResponseInterface $response
     *
     * @return \SimpleXMLElement
     *
     * @throws LinkedInApiException
     */
    public static function convertToSimpleXml(ResponseInterface $response)
    {
        $body = $response->getBody();
        try {
            return new \SimpleXMLElement((string) $body ?: '<root />');
        } catch (\Exception $e) {
            throw new LinkedInApiException(
                array(
                    'error' => array(
                        'message' => 'Unable to parse response body into XML: '.$e->getMessage(),
                        'type' => 'XmlParseException',
                    ),
                )
            );
        }
    }
}


1			<?php
2
3			namespace Happyr\LinkedIn\Http;
4
5			use Happyr\LinkedIn\Exceptions\LinkedInApiException;
6			use Psr\Http\Message\ResponseInterface;
7
8			class ResponseConverter
9			{
10			/**
11			* @param ResponseInterface $response
12			* @param string $format
			0 ignored issues – show Documentation introduced 2015-12-19 10:57 UTC by Report Bug Copy Issue Report There is no parameter named `$format`. Did you maybe mean `$requestFormat`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
13			*
14			* @return ResponseInterface\|\Psr\Http\Message\StreamInterface\|\SimpleXMLElement\|string
15			*
16			* @throws LinkedInApiException
17			*/
18			public static function convert(ResponseInterface $response, $requestFormat, $dataType)
19			{
20			if (($requestFormat === 'json' && $dataType === 'simple_xml') \|\|
21			($requestFormat === 'xml' && $dataType === 'array')) {
22			throw new \InvalidArgumentException(sprintf('Can not use reponse data format "%s" with the request format "s%"', $dataType, $requestFormat));
23			}
24
25			switch ($dataType) {
26			case 'array':
27			return self::convertToArray($response);
28			case 'string':
29			return $response->getBody()->__toString();
30			case 'simple_xml':
31			return self::convertToSimpleXml($response);
32			case 'stream':
33			return $response->getBody();
34			case 'psr7':
35			return $response;
36			default:
37			throw new \InvalidArgumentException(sprintf('Format "%s" is not supported', $dataType));
38			}
39			}
40
41			/**
42			* @param ResponseInterface $response
43			*
44			* @return string
45			*/
46			public static function convertToArray(ResponseInterface $response)
47			{
48			return json_decode($response->getBody(), true);
49			}
50
51			/**
52			* @param ResponseInterface $response
53			*
54			* @return \SimpleXMLElement
55			*
56			* @throws LinkedInApiException
57			*/
58			public static function convertToSimpleXml(ResponseInterface $response)
59			{
60			$body = $response->getBody();
61			try {
62			return new \SimpleXMLElement((string) $body ?: '<root />');
63			} catch (\Exception $e) {
64			throw new LinkedInApiException(
65			array(
66			'error' => array(
67			'message' => 'Unable to parse response body into XML: '.$e->getMessage(),
68			'type' => 'XmlParseException',
69			),
70			)
71			);
72			}
73			}
74			}
75

Happyr / LinkedIn-API-client

Pull Request — master (#73)

ResponseConverter::convert() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like