Happyr\DoctrineSpecification\Operand\ArgumentToOperandConverter

Complexity

Total Complexity

13

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	toField()	0	8	2
A	toValue()	0	8	2
A	isAllOperands()	0	10	3
B	convert()	0	31	6

<?php

namespace Happyr\DoctrineSpecification\Operand;

use Happyr\DoctrineSpecification\Exception\NotConvertibleException;

/**
 * This service is intended for backward compatibility and may be removed in the future.
 */
class ArgumentToOperandConverter
{
    /**
     * Convert the argument into the field operand if it is not an operand.
     *
     * @param Operand|string $argument
     *
     * @return Operand
     */
    public static function toField($argument)
    {
        if ($argument instanceof Operand) {
            return $argument;
        }

        return new Field($argument);
    }

    /**
     * Convert the argument into the value operand if it is not an operand.
     *
     * @param Operand|string $argument
     *
     * @return Operand
     */
    public static function toValue($argument)
    {
        if ($argument instanceof Operand) {
            return $argument;
        }

        return new Value($argument);
    }

    /**
     * Are all arguments is a operands?
     *
     * @param array $arguments
     *
     * @return bool
     */
    public static function isAllOperands(array $arguments)
    {
        foreach ($arguments as $argument) {
            if (!($argument instanceof Operand)) {
                return false;
            }
        }

        return true;
    }

    /**
     * Convert all possible arguments to operands.
     *
     * @param Operand[]|string[] $arguments
     *
     * @throws NotConvertibleException
     *
     * @return Operand[]
     */
    public static function convert(array $arguments)
    {
        if (!$arguments) {

The expression $arguments of type array<Happyr\DoctrineSpecification\Operand\Operand|string> is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [];
        }

        // always try convert the first argument to the field operand
        $field = self::toField(array_shift($arguments));

It seems like array_shift($arguments) targeting array_shift() can also be of type null; however, Happyr\DoctrineSpecification\Operand\ArgumentToOperandConverter::toField() does only seem to accept object<Happyr\DoctrineSpecification\Operand\Operand>|string, maybe add an additional type check?

        if (!$arguments) {

The expression $arguments of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [$field];
        }

        // always try convert the last argument to the value operand
        $value = self::toValue(array_pop($arguments));

        if (!$arguments) {

The expression $arguments of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [$field, $value];
        }

        $result = [$field];
        foreach ($arguments as $argument) {
            if (!($argument instanceof Operand)) {
                throw new NotConvertibleException('You passed arguments not all of which are operands.');
            }
            $result[] = $argument;
        }
        $result[] = $value;

        return $result;
    }
}