Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class IndexBy implements QueryModifier |
||
11 | { |
||
12 | /** |
||
13 | * Field name. |
||
14 | * |
||
15 | * @var string |
||
16 | */ |
||
17 | private $field; |
||
18 | |||
19 | /** |
||
20 | * DQL Alias. |
||
21 | * |
||
22 | * @var string |
||
23 | */ |
||
24 | private $dqlAlias; |
||
25 | |||
26 | /** |
||
27 | * IndexBy constructor. |
||
28 | * |
||
29 | * @param string $field Field name for indexing |
||
30 | * @param string $dqlAlias DQL alias of field |
||
31 | */ |
||
32 | public function __construct($field, $dqlAlias = null) |
||
37 | |||
38 | /** |
||
39 | * {@inheritdoc} |
||
40 | */ |
||
41 | View Code Duplication | public function modify(QueryBuilder $qb, $dqlAlias) |
|
49 | } |
||
50 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.