In - Code Metrics - Inspection of "Add a deprecated comments and log messages for nex..." - Happyr/Doctrine-Specification - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3dab41...181b76 )

by Peter

created 2019-11-19 13:14 UTC

In A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	89.66 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	4
dl	52
loc	58
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	1
A	getFilter()	9	14	2

How to fix Duplicated Code

<?php

/**
 * This file is part of the Happyr Doctrine Specification package.
 *
 * (c) Tobias Nyholm <[email protected]>
 *     Kacper Gunia <[email protected]>
 *     Peter Gribanov <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Happyr\DoctrineSpecification\Filter;

use Doctrine\ORM\QueryBuilder;
use Happyr\DoctrineSpecification\Operand\ArgumentToOperandConverter;
use Happyr\DoctrineSpecification\Operand\Operand;

class In implements Filter

{
    /**
     * @deprecated This property will be marked as private in 2.0.
     *
     * @var Operand|string
     */
    protected $field;

    /**
     * @deprecated This property will be marked as private in 2.0.
     *
     * @var Operand|mixed
     */
    protected $value;

    /**
     * @deprecated This property will be marked as private in 2.0.
     *
     * @var string|null
     */
    protected $dqlAlias;

    /**
     * Make sure the $field has a value equals to $value.
     *
     * @param Operand|string $field
     * @param Operand|mixed  $value
     * @param string|null    $dqlAlias
     */
    public function __construct($field, $value, $dqlAlias = null)
    {
        $this->field = $field;

        $this->value = $value;

        $this->dqlAlias = $dqlAlias;

    }

    /**
     * @param QueryBuilder $qb
     * @param string       $dqlAlias
     *
     * @return string
     */
    public function getFilter(QueryBuilder $qb, $dqlAlias)
    {
        if (null !== $this->dqlAlias) {

            $dqlAlias = $this->dqlAlias;

        }

        $field = ArgumentToOperandConverter::toField($this->field);

        $value = ArgumentToOperandConverter::toValue($this->value);


        return (string) $qb->expr()->in(
            $field->transform($qb, $dqlAlias),
            $value->transform($qb, $dqlAlias)
        );
    }
}


1		<?php
2
3		/**
4		* This file is part of the Happyr Doctrine Specification package.
5		*
6		* (c) Tobias Nyholm <[email protected]>
7		* Kacper Gunia <[email protected]>
8		* Peter Gribanov <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Happyr\DoctrineSpecification\Filter;
15
16		use Doctrine\ORM\QueryBuilder;
17		use Happyr\DoctrineSpecification\Operand\ArgumentToOperandConverter;
18		use Happyr\DoctrineSpecification\Operand\Operand;
19
20	View Code Duplication	class In implements Filter
		0 ignored issues – show Duplication introduced 2019-05-01 11:49 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		/**
23		* @deprecated This property will be marked as private in 2.0.
24		*
25		* @var Operand\|string
26		*/
27		protected $field;
28
29		/**
30		* @deprecated This property will be marked as private in 2.0.
31		*
32		* @var Operand\|mixed
33		*/
34		protected $value;
35
36		/**
37		* @deprecated This property will be marked as private in 2.0.
38		*
39		* @var string\|null
40		*/
41		protected $dqlAlias;
42
43		/**
44		* Make sure the $field has a value equals to $value.
45		*
46		* @param Operand\|string $field
47		* @param Operand\|mixed $value
48		* @param string\|null $dqlAlias
49		*/
50		public function __construct($field, $value, $dqlAlias = null)
51		{
52		$this->field = $field;
		0 ignored issues – show Deprecated Code introduced 2019-11-19 13:21 UTC by Report Bug Copy Issue Report The property `Happyr\DoctrineSpecification\Filter\In::$field` has been deprecated with message: This property will be marked as private in 2.0. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
53		$this->value = $value;
		0 ignored issues – show Deprecated Code introduced 2019-11-19 13:21 UTC by Report Bug Copy Issue Report The property `Happyr\DoctrineSpecification\Filter\In::$value` has been deprecated with message: This property will be marked as private in 2.0. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
54		$this->dqlAlias = $dqlAlias;
		0 ignored issues – show Deprecated Code introduced 2019-11-19 13:21 UTC by Report Bug Copy Issue Report The property `Happyr\DoctrineSpecification\Filter\In::$dqlAlias` has been deprecated with message: This property will be marked as private in 2.0. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
55		}
56
57		/**
58		* @param QueryBuilder $qb
59		* @param string $dqlAlias
60		*
61		* @return string
62		*/
63		public function getFilter(QueryBuilder $qb, $dqlAlias)
64		{
65		if (null !== $this->dqlAlias) {
		0 ignored issues – show Deprecated Code introduced 2019-11-19 13:21 UTC by Report Bug Copy Issue Report The property `Happyr\DoctrineSpecification\Filter\In::$dqlAlias` has been deprecated with message: This property will be marked as private in 2.0. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
66		$dqlAlias = $this->dqlAlias;
		0 ignored issues – show Deprecated Code introduced 2019-11-19 13:21 UTC by Report Bug Copy Issue Report The property `Happyr\DoctrineSpecification\Filter\In::$dqlAlias` has been deprecated with message: This property will be marked as private in 2.0. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
67		}
68
69		$field = ArgumentToOperandConverter::toField($this->field);
		0 ignored issues – show Deprecated Code introduced 2019-11-19 13:21 UTC by Report Bug Copy Issue Report The property `Happyr\DoctrineSpecification\Filter\In::$field` has been deprecated with message: This property will be marked as private in 2.0. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
70		$value = ArgumentToOperandConverter::toValue($this->value);
		0 ignored issues – show Deprecated Code introduced 2019-11-19 13:21 UTC by Report Bug Copy Issue Report The property `Happyr\DoctrineSpecification\Filter\In::$value` has been deprecated with message: This property will be marked as private in 2.0. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
71
72		return (string) $qb->expr()->in(
73		$field->transform($qb, $dqlAlias),
74		$value->transform($qb, $dqlAlias)
75		);
76		}
77		}
78

Happyr / Doctrine-Specification

Push — master ( 3dab41...181b76 )

In A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like