Hanisch-IT / kraken-api

src/Call/TradableAssetPairs/TradableAssetPairsRequest.php

<?php

namespace HanischIt\KrakenApi\Call\TradableAssetPairs;

use HanischIt\KrakenApi\Enum\VisibilityEnum;
use HanischIt\KrakenApi\Model\RequestInterface;

/**
 * Class TradableAssetPairsRequest
 * @package HanischIt\KrakenApi\Call\TradableAssetPairs
 */
class TradableAssetPairsRequest implements RequestInterface
{
    /**
     * @var string
     */
    private $info;
    /**
     * @var array
     */
    private $pair;

    /**
     * TradableAssetPairsRequest constructor.
     * @param string $info
     * @param string $pair
     */
    public function __construct($info = 'info', $pair = null)
    {
        $this->info = $info;
        $this->pair = $pair;

It seems like $pair can also be of type string. However, the property $pair is declared as type array. Maybe add an additional type check?

    }


    /**
     * Returns the api request name
     *
     * @return string
     */
    public function getMethod()
    {
        return 'AssetPairs';
    }

    /**
     * @return string
     */
    public function getVisibility()
    {
        return VisibilityEnum::VISIBILITY_PUBLIC;
    }

    /**
     * @return array
     */
    public function getRequestData()
    {
        $arr = [];
        $arr["info"] = $this->info;
        if (null !== $this->pair) {

The condition null !== $this->pair can never be false.

            $arr["pair"] = $this->pair;
        }
        return $arr;
    }

    /**
     * @return string
     */
    public function getResponseClassName()
    {
        return TradableAssetPairsResponse::class;
    }
}