KrakenApi::getAccountBalance() - Code Metrics - Inspection of "Add AddOrder and GetAssets method" - Hanisch-IT/kraken-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 23ee92...69fe25 )

by Fabian

created 2017-07-16 18:46 UTC

KrakenApi::getAccountBalance() A

↳ Parent: KrakenApi

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * @author Fabian Hanisch
 * @since 16.07.2017 02:56
 * @version 1.0
 */

namespace HanischIt\KrakenApi;

use HanischIt\KrakenApi\External\HttpClient;
use HanischIt\KrakenApi\Model\AccountBalance\AccountBalanceRequest;
use HanischIt\KrakenApi\Model\AccountBalance\AccountBalanceResponse;
use HanischIt\KrakenApi\Model\AddOrder\AddOrderRequest;
use HanischIt\KrakenApi\Model\Assets\AssetsRequest;
use HanischIt\KrakenApi\Model\Assets\AssetsResponse;
use HanischIt\KrakenApi\Model\Header;
use HanischIt\KrakenApi\Model\RequestInterface;
use HanischIt\KrakenApi\Model\RequestOptions;
use HanischIt\KrakenApi\Model\ResponseInterface;
use HanischIt\KrakenApi\Model\ServerTime\ServerTimeRequest;
use HanischIt\KrakenApi\Model\ServerTime\ServerTimeResponse;
use HanischIt\KrakenApi\Service\RequestService\Request;
use HanischIt\KrakenApi\Service\RequestService\RequestHeader;

/**
 * Class KrakenApi
 * @package HanischIt\KrakenApi
 */
class KrakenApi
{
    /**
     * @var HttpClient
     */
    private $httpClient;
    /**
     * @var RequestHeader
     */
    private $requestHeader;
    /**
     * @var string
     */
    private $apiKey;
    /**
     * @var string
     */
    private $apiSign;
    /**
     * @var string
     */
    private $version;

    /**
     * KrakenApi constructor.
     * @param string $apiKey
     * @param string $apiSign
     */
    public function __construct($apiKey, $apiSign)
    {
        $this->httpClient = new HttpClient();
        $this->requestHeader = new RequestHeader();
        $this->endpoint = 'https://api.kraken.com/';

        $this->version = '0';
        $this->apiKey = $apiKey;
        $this->apiSign = $apiSign;
    }

    /**
     * @return ServerTimeResponse|ResponseInterface
     */
    public function getServerTime()
    {
        $serverTimeRequest = new ServerTimeRequest();

        return $this->doRequest($serverTimeRequest);
    }

    /**
     * @return AccountBalanceResponse|ResponseInterface
     */
    public function getAccountBalance()
    {
        $accountBalanceRequest = new AccountBalanceRequest();

        return $this->doRequest($accountBalanceRequest);
    }

    /**
     * @param string $pair
     * @param string $type
     * @param string $orderType
     * @param null|float $price
     * @param null|float $volume
     * @return ResponseInterface
     */
    public function addOrder($pair, $type, $orderType, $price = null, $volume = null)
    {
        $addOrderRequest = new AddOrderRequest($pair, $type, $orderType, $price, $volume);

        return $this->doRequest($addOrderRequest);
    }

    /**
     * @return ResponseInterface|AssetsResponse
     */
    public function getAssets()
    {
        $assetsRequest = new AssetsRequest();

        return $this->doRequest($assetsRequest);
    }

    /**
     * @param RequestInterface $requestInterface
     * @return ResponseInterface
     */
    private function doRequest(RequestInterface $requestInterface)
    {
        $requestOptions = new RequestOptions($this->endpoint, $this->version);

        $header = new Header($this->apiKey, $this->apiSign);
        $request = new Request($this->httpClient, $this->requestHeader);

        return $request->execute($requestInterface, $requestOptions, $header);
    }
}


1			<?php
2			/**
3			* @author Fabian Hanisch
4			* @since 16.07.2017 02:56
5			* @version 1.0
6			*/
7
8			namespace HanischIt\KrakenApi;
9
10			use HanischIt\KrakenApi\External\HttpClient;
11			use HanischIt\KrakenApi\Model\AccountBalance\AccountBalanceRequest;
12			use HanischIt\KrakenApi\Model\AccountBalance\AccountBalanceResponse;
13			use HanischIt\KrakenApi\Model\AddOrder\AddOrderRequest;
14			use HanischIt\KrakenApi\Model\Assets\AssetsRequest;
15			use HanischIt\KrakenApi\Model\Assets\AssetsResponse;
16			use HanischIt\KrakenApi\Model\Header;
17			use HanischIt\KrakenApi\Model\RequestInterface;
18			use HanischIt\KrakenApi\Model\RequestOptions;
19			use HanischIt\KrakenApi\Model\ResponseInterface;
20			use HanischIt\KrakenApi\Model\ServerTime\ServerTimeRequest;
21			use HanischIt\KrakenApi\Model\ServerTime\ServerTimeResponse;
22			use HanischIt\KrakenApi\Service\RequestService\Request;
23			use HanischIt\KrakenApi\Service\RequestService\RequestHeader;
24
25			/**
26			* Class KrakenApi
27			* @package HanischIt\KrakenApi
28			*/
29			class KrakenApi
30			{
31			/**
32			* @var HttpClient
33			*/
34			private $httpClient;
35			/**
36			* @var RequestHeader
37			*/
38			private $requestHeader;
39			/**
40			* @var string
41			*/
42			private $apiKey;
43			/**
44			* @var string
45			*/
46			private $apiSign;
47			/**
48			* @var string
49			*/
50			private $version;
51
52			/**
53			* KrakenApi constructor.
54			* @param string $apiKey
55			* @param string $apiSign
56			*/
57			public function __construct($apiKey, $apiSign)
58			{
59			$this->httpClient = new HttpClient();
60			$this->requestHeader = new RequestHeader();
61			$this->endpoint = 'https://api.kraken.com/';
			0 ignored issues – show Bug Best Practice introduced 2017-07-16 08:58 UTC by Report Bug Copy Issue Report The property `endpoint` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
62			$this->version = '0';
63			$this->apiKey = $apiKey;
64			$this->apiSign = $apiSign;
65			}
66
67			/**
68			* @return ServerTimeResponse\|ResponseInterface
69			*/
70			public function getServerTime()
71			{
72			$serverTimeRequest = new ServerTimeRequest();
73
74			return $this->doRequest($serverTimeRequest);
75			}
76
77			/**
78			* @return AccountBalanceResponse\|ResponseInterface
79			*/
80			public function getAccountBalance()
81			{
82			$accountBalanceRequest = new AccountBalanceRequest();
83
84			return $this->doRequest($accountBalanceRequest);
85			}
86
87			/**
88			* @param string $pair
89			* @param string $type
90			* @param string $orderType
91			* @param null\|float $price
92			* @param null\|float $volume
93			* @return ResponseInterface
94			*/
95			public function addOrder($pair, $type, $orderType, $price = null, $volume = null)
96			{
97			$addOrderRequest = new AddOrderRequest($pair, $type, $orderType, $price, $volume);
98
99			return $this->doRequest($addOrderRequest);
100			}
101
102			/**
103			* @return ResponseInterface\|AssetsResponse
104			*/
105			public function getAssets()
106			{
107			$assetsRequest = new AssetsRequest();
108
109			return $this->doRequest($assetsRequest);
110			}
111
112			/**
113			* @param RequestInterface $requestInterface
114			* @return ResponseInterface
115			*/
116			private function doRequest(RequestInterface $requestInterface)
117			{
118			$requestOptions = new RequestOptions($this->endpoint, $this->version);
			0 ignored issues – show Bug Best Practice introduced 2017-07-16 08:58 UTC by Report Bug Copy Issue Report The property `endpoint` does not exist on `HanischIt\KrakenApi\KrakenApi`. Did you maybe forget to declare it? Loading history...
119			$header = new Header($this->apiKey, $this->apiSign);
120			$request = new Request($this->httpClient, $this->requestHeader);
121
122			return $request->execute($requestInterface, $requestOptions, $header);
123			}
124			}
125

Hanisch-IT / kraken-api

Push — master ( 23ee92...69fe25 )

KrakenApi::getAccountBalance() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like