ClosedOrderModel::__construct() - Code Metrics - Inspection of "Add ClosedOrders Call" - Hanisch-IT/kraken-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bba056...1b0f90 )

by Fabian

created 2017-07-20 12:19 UTC

ClosedOrderModel::__construct() B

↳ Parent: ClosedOrderModel

Complexity

Conditions	1
Paths	1

Size

Total Lines	36
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	17
nc	1
nop	17
dl	0
loc	36
ccs	0
cts	36
cp	0
crap	2
rs	8.8571
c	1
b	0
f	0

How to fix Many Parameters

<?php
/**
 * @author  Fabian Hanisch
 * @since   18.07.2017 20:32
 * @version 1.0
 */

namespace HanischIt\KrakenApi\Model\ClosedOrders;

/**
 * Class ClosedOrderModel
 *
 * @package HanischIt\KrakenApi\Model\ClosedOrders
 */
class ClosedOrderModel
{
    /**
     * @var string
     */
    private $txId;
    /**
     * @var float
     */
    private $cost;
    /**
     * @var ClosedOrderOrderTypeModel
     */
    private $orderDetails;
    /**
     * @var int
     */
    private $expiretm;
    /**
     * @var float
     */
    private $fee;
    /**
     * @var string
     */
    private $misc;
    /**
     * @var string
     */
    private $oflags;
    /**
     * @var int
     */
    private $opentm;
    /**
     * @var float
     */
    private $price;
    /**
     * @var string
     */
    private $refid;
    /**
     * @var int
     */
    private $starttm;
    /**
     * @var string
     */
    private $status;
    /**
     * @var string
     */
    private $userref;
    /**
     * @var float
     */
    private $vol;
    /**
     * @varfloat
     */
    private $vol_exec;
    private $closeTm;
    private $reason;

    /**
     * OpenOrderModel constructor.
     *
     * @param string                    $txid
     * @param string                    $closeTm
     * @param float                     $cost
     * @param ClosedOrderOrderTypeModel $orderDetails
     * @param int                       $expiretm
     * @param float                     $fee
     * @param string                    $misc
     * @param string                    $oflags
     * @param int                       $opentm
     * @param float                     $price
     * @param string                    $reason
     * @param string                    $refid
     * @param int                       $starttm
     * @param string                    $status
     * @param string                    $userref
     * @param float                     $vol
     * @param float                     $vol_exec
     */
    public function __construct(
        $txid,
        $closeTm,
        $cost,
        ClosedOrderOrderTypeModel $orderDetails,
        $expiretm,
        $fee,
        $misc,
        $oflags,
        $opentm,
        $price,
        $reason,
        $refid,
        $starttm,
        $status,
        $userref,
        $vol,
        $vol_exec
    ) {
        $this->txId = $txid;
        $this->cost = $cost;
        $this->orderDetails = $orderDetails;
        $this->expiretm = $expiretm;
        $this->fee = $fee;
        $this->misc = $misc;
        $this->oflags = $oflags;
        $this->opentm = $opentm;
        $this->price = $price;
        $this->refid = $refid;
        $this->starttm = $starttm;
        $this->status = $status;
        $this->userref = $userref;
        $this->vol = $vol;
        $this->vol_exec = $vol_exec;
        $this->closeTm = $closeTm;
        $this->reason = $reason;
    }

    /**
     * @return string
     */
    public function getTxId()
    {
        return $this->txId;
    }


    /**
     * @return mixed
     */
    public function getCost()
    {
        return $this->cost;
    }

    /**
     * @return ClosedOrderOrderTypeModel
     */
    public function getOrderDetails()
    {
        return $this->orderDetails;
    }

    /**
     * @return int
     */
    public function getExpiretm()
    {
        return $this->expiretm;
    }

    /**
     * @return float
     */
    public function getFee()
    {
        return $this->fee;
    }

    /**
     * @return string
     */
    public function getMisc()
    {
        return $this->misc;
    }

    /**
     * @return string
     */
    public function getOflags()
    {
        return $this->oflags;
    }

    /**
     * @return int
     */
    public function getOpentm()
    {
        return $this->opentm;
    }

    /**
     * @return float
     */
    public function getPrice()
    {
        return $this->price;
    }

    /**
     * @return string
     */
    public function getRefid()
    {
        return $this->refid;
    }

    /**
     * @return int
     */
    public function getStarttm()
    {
        return $this->starttm;
    }

    /**
     * @return string
     */
    public function getStatus()
    {
        return $this->status;
    }

    /**
     * @return string
     */
    public function getUserref()
    {
        return $this->userref;
    }

    /**
     * @return float
     */
    public function getVol()
    {
        return $this->vol;
    }

    /**
     * @return mixed
     */
    public function getVolExec()
    {
        return $this->vol_exec;
    }

    /**
     * @return string
     */
    public function getCloseTm()
    {
        return $this->closeTm;
    }

    /**
     * @return string
     */
    public function getReason()
    {
        return $this->reason;
    }
}


1			<?php
2			/**
3			* @author Fabian Hanisch
4			* @since 18.07.2017 20:32
5			* @version 1.0
6			*/
7
8			namespace HanischIt\KrakenApi\Model\ClosedOrders;
9
10			/**
11			* Class ClosedOrderModel
12			*
13			* @package HanischIt\KrakenApi\Model\ClosedOrders
14			*/
15			class ClosedOrderModel
16			{
17			/**
18			* @var string
19			*/
20			private $txId;
21			/**
22			* @var float
23			*/
24			private $cost;
25			/**
26			* @var ClosedOrderOrderTypeModel
27			*/
28			private $orderDetails;
29			/**
30			* @var int
31			*/
32			private $expiretm;
33			/**
34			* @var float
35			*/
36			private $fee;
37			/**
38			* @var string
39			*/
40			private $misc;
41			/**
42			* @var string
43			*/
44			private $oflags;
45			/**
46			* @var int
47			*/
48			private $opentm;
49			/**
50			* @var float
51			*/
52			private $price;
53			/**
54			* @var string
55			*/
56			private $refid;
57			/**
58			* @var int
59			*/
60			private $starttm;
61			/**
62			* @var string
63			*/
64			private $status;
65			/**
66			* @var string
67			*/
68			private $userref;
69			/**
70			* @var float
71			*/
72			private $vol;
73			/**
74			* @varfloat
75			*/
76			private $vol_exec;
77			private $closeTm;
78			private $reason;
79
80			/**
81			* OpenOrderModel constructor.
82			*
83			* @param string $txid
84			* @param string $closeTm
85			* @param float $cost
86			* @param ClosedOrderOrderTypeModel $orderDetails
87			* @param int $expiretm
88			* @param float $fee
89			* @param string $misc
90			* @param string $oflags
91			* @param int $opentm
92			* @param float $price
93			* @param string $reason
94			* @param string $refid
95			* @param int $starttm
96			* @param string $status
97			* @param string $userref
98			* @param float $vol
99			* @param float $vol_exec
100			*/
101			public function __construct(
102			$txid,
103			$closeTm,
104			$cost,
105			ClosedOrderOrderTypeModel $orderDetails,
106			$expiretm,
107			$fee,
108			$misc,
109			$oflags,
110			$opentm,
111			$price,
112			$reason,
113			$refid,
114			$starttm,
115			$status,
116			$userref,
117			$vol,
118			$vol_exec
119			) {
120			$this->txId = $txid;
121			$this->cost = $cost;
122			$this->orderDetails = $orderDetails;
123			$this->expiretm = $expiretm;
124			$this->fee = $fee;
125			$this->misc = $misc;
126			$this->oflags = $oflags;
127			$this->opentm = $opentm;
128			$this->price = $price;
129			$this->refid = $refid;
130			$this->starttm = $starttm;
131			$this->status = $status;
132			$this->userref = $userref;
133			$this->vol = $vol;
134			$this->vol_exec = $vol_exec;
135			$this->closeTm = $closeTm;
136			$this->reason = $reason;
137			}
138
139			/**
140			* @return string
141			*/
142			public function getTxId()
143			{
144			return $this->txId;
145			}
146
147
148			/**
149			* @return mixed
150			*/
151			public function getCost()
152			{
153			return $this->cost;
154			}
155
156			/**
157			* @return ClosedOrderOrderTypeModel
158			*/
159			public function getOrderDetails()
160			{
161			return $this->orderDetails;
162			}
163
164			/**
165			* @return int
166			*/
167			public function getExpiretm()
168			{
169			return $this->expiretm;
170			}
171
172			/**
173			* @return float
174			*/
175			public function getFee()
176			{
177			return $this->fee;
178			}
179
180			/**
181			* @return string
182			*/
183			public function getMisc()
184			{
185			return $this->misc;
186			}
187
188			/**
189			* @return string
190			*/
191			public function getOflags()
192			{
193			return $this->oflags;
194			}
195
196			/**
197			* @return int
198			*/
199			public function getOpentm()
200			{
201			return $this->opentm;
202			}
203
204			/**
205			* @return float
206			*/
207			public function getPrice()
208			{
209			return $this->price;
210			}
211
212			/**
213			* @return string
214			*/
215			public function getRefid()
216			{
217			return $this->refid;
218			}
219
220			/**
221			* @return int
222			*/
223			public function getStarttm()
224			{
225			return $this->starttm;
226			}
227
228			/**
229			* @return string
230			*/
231			public function getStatus()
232			{
233			return $this->status;
234			}
235
236			/**
237			* @return string
238			*/
239			public function getUserref()
240			{
241			return $this->userref;
242			}
243
244			/**
245			* @return float
246			*/
247			public function getVol()
248			{
249			return $this->vol;
250			}
251
252			/**
253			* @return mixed
254			*/
255			public function getVolExec()
256			{
257			return $this->vol_exec;
258			}
259
260			/**
261			* @return string
262			*/
263			public function getCloseTm()
264			{
265			return $this->closeTm;
266			}
267
268			/**
269			* @return string
270			*/
271			public function getReason()
272			{
273			return $this->reason;
274			}
275			}
276

Hanisch-IT / kraken-api

Push — master ( bba056...1b0f90 )

ClosedOrderModel::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like