TradeVolumeRequest::getRequestData() - Code Metrics - Inspection of "Add GetTradeVolume" - Hanisch-IT/kraken-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 65b971...326999 )

by Fabian

created 2017-08-27 23:20 UTC

TradeVolumeRequest::getRequestData() A

↳ Parent: TradeVolumeRequest

Complexity

Conditions	3
Paths	4

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	6
nc	4
nop	0
dl	10
loc	10
ccs	9
cts	9
cp	1
crap	3
rs	9.4285
c	1
b	0
f	0

<?php

namespace HanischIt\KrakenApi\Model\TradeVolume;

use HanischIt\KrakenApi\Enum\VisibilityEnum;
use HanischIt\KrakenApi\Model\RequestInterface;

/**
 * Class TradeVolumeRequest
 * @package HanischIt\KrakenApi\Model\TradeVolume
 */
class TradeVolumeRequest implements RequestInterface

{

    /**
     * @var string
     */
    private $pair;
    /**
     * @var bool
     */
    private $feeInfo;

    /**
     * TradeVolumeRequest constructor.
     * @param string $pair
     * @param bool $feeInfo
     */
    public function __construct($pair = null, $feeInfo = null)
    {
        $this->pair = $pair;
        $this->feeInfo = $feeInfo;
    }


    /**
     * Returns the api request name
     *
     * @return string
     */
    public function getMethod()
    {
        return 'TradeVolume';
    }

    /**
     * @return string
     */
    public function getVisibility()
    {
        return VisibilityEnum::VISIBILITY_PRIVATE;
    }

    /**
     * @return array
     */
    public function getRequestData()
    {
        $ret = [];
        if ($this->pair) {
            $ret["pair"] = $this->pair;
        }
        if ($this->feeInfo) {
            $ret["fee-info"] = $this->feeInfo;
        }
        return $ret;
    }

    /**
     * @return string
     */
    public function getResponseClassName()
    {
        return TradeVolumeResponse::class;
    }
}


1			<?php
2
3			namespace HanischIt\KrakenApi\Model\TradeVolume;
4
5			use HanischIt\KrakenApi\Enum\VisibilityEnum;
6			use HanischIt\KrakenApi\Model\RequestInterface;
7
8			/**
9			* Class TradeVolumeRequest
10			* @package HanischIt\KrakenApi\Model\TradeVolume
11			*/
12		View Code Duplication	class TradeVolumeRequest implements RequestInterface
			0 ignored issues – show Duplication introduced 2017-08-27 23:22 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13			{
14
15			/**
16			* @var string
17			*/
18			private $pair;
19			/**
20			* @var bool
21			*/
22			private $feeInfo;
23
24			/**
25			* TradeVolumeRequest constructor.
26			* @param string $pair
27			* @param bool $feeInfo
28			*/
29	2		public function __construct($pair = null, $feeInfo = null)
30			{
31	2		$this->pair = $pair;
32	2		$this->feeInfo = $feeInfo;
33	2		}
34
35
36			/**
37			* Returns the api request name
38			*
39			* @return string
40			*/
41	1		public function getMethod()
42			{
43	1		return 'TradeVolume';
44			}
45
46			/**
47			* @return string
48			*/
49	1		public function getVisibility()
50			{
51	1		return VisibilityEnum::VISIBILITY_PRIVATE;
52			}
53
54			/**
55			* @return array
56			*/
57	1		public function getRequestData()
58			{
59	1		$ret = [];
60	1		if ($this->pair) {
61	1		$ret["pair"] = $this->pair;
62	1		}
63	1		if ($this->feeInfo) {
64	1		$ret["fee-info"] = $this->feeInfo;
65	1		}
66	1		return $ret;
67			}
68
69			/**
70			* @return string
71			*/
72	1		public function getResponseClassName()
73			{
74	1		return TradeVolumeResponse::class;
75			}
76			}
77

Hanisch-IT / kraken-api

Push — master ( 65b971...326999 )

TradeVolumeRequest::getRequestData() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like