Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
21 | class Result implements ExportableInterface { |
||
22 | |||
23 | /** |
||
24 | * @var array |
||
25 | */ |
||
26 | private $classes = array(); |
||
27 | |||
28 | /** |
||
29 | * @inheritdoc |
||
30 | */ |
||
31 | public function asArray() { |
||
47 | |||
48 | /** |
||
49 | * Push class |
||
50 | * |
||
51 | * @param ReflectedClass $class |
||
52 | * @return $this |
||
53 | */ |
||
54 | public function pushClass(ReflectedClass $class) { |
||
58 | |||
59 | /** |
||
60 | * @return array |
||
61 | */ |
||
62 | public function getClasses() |
||
66 | |||
67 | /** |
||
68 | * Get abstract classes |
||
69 | * |
||
70 | * @return array |
||
71 | */ |
||
72 | View Code Duplication | public function getAbstractClasses() { |
|
|
|||
73 | $result = array(); |
||
74 | foreach($this->getClasses() as $class) { |
||
75 | if($class->isAbstract() ||$class instanceof ReflectedInterface) { |
||
76 | array_push($result, $class); |
||
77 | } |
||
78 | } |
||
79 | return $result; |
||
80 | } |
||
81 | |||
82 | /** |
||
83 | * Get anonymous classes |
||
84 | * |
||
85 | * @return array |
||
86 | */ |
||
87 | public function getAnonymousClasses() { |
||
88 | $result = array(); |
||
89 | foreach($this->getClasses() as $class) { |
||
90 | if($class instanceof ReflectedClass\ReflectedAnonymousClass) { |
||
91 | array_push($result, $class); |
||
92 | } |
||
93 | } |
||
94 | return $result; |
||
95 | } |
||
96 | |||
97 | /** |
||
98 | * Get abstract classes |
||
99 | * |
||
100 | * @return array |
||
101 | */ |
||
102 | View Code Duplication | public function getInterfaces() { |
|
111 | |||
112 | /** |
||
113 | * Get concretes classes |
||
114 | * |
||
115 | * @return array |
||
116 | */ |
||
117 | public function getConcreteClasses() { |
||
126 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.