Halleck45 /
PhpMetrics
| Conditions | 17 |
| Paths | 27 |
| Total Lines | 101 |
| Code Lines | 64 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 7 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 68 | public function extract($filename) |
||
| 69 | { |
||
| 70 | |||
| 71 | $result = new Result; |
||
| 72 | |||
| 73 | $tokens = $this->tokenizer->tokenize($filename); |
||
| 74 | $nameResolver = new NameResolver(); |
||
| 75 | |||
| 76 | // default current values |
||
| 77 | $class = $interface = $function = $namespace = $method = null; |
||
| 78 | |||
| 79 | $len = sizeof($tokens, COUNT_NORMAL); |
||
| 80 | $endAnonymous = 0; |
||
| 81 | $mainContextClass = null; // class containing a anonymous class |
||
| 82 | |||
| 83 | for($n = 0; $n < $len; $n++) { |
||
| 84 | |||
| 85 | if($mainContextClass && $n > $endAnonymous) { |
||
| 86 | // anonymous class is finished. We back to parent class |
||
| 87 | // methods will be added to the main class now |
||
| 88 | $class = $mainContextClass; |
||
| 89 | $mainContextClass = null; |
||
| 90 | } |
||
| 91 | |||
| 92 | $token = $tokens[$n]; |
||
| 93 | |||
| 94 | switch($token->getType()) { |
||
| 95 | |||
| 96 | case T_USE: |
||
| 97 | $alias = $this->extractors->alias->extract($n, $tokens); |
||
| 98 | if (null !== $alias->name && null !== $alias->alias) { |
||
| 99 | $nameResolver->pushAlias($alias); |
||
| 100 | } |
||
| 101 | break; |
||
| 102 | |||
| 103 | case T_NAMESPACE: |
||
| 104 | $namespace = '\\'.$this->searcher->getFollowingName($n, $tokens); |
||
| 105 | $this->extractors->class->setNamespace($namespace); |
||
| 106 | $this->extractors->interface->setNamespace($namespace); |
||
| 107 | break; |
||
| 108 | |||
| 109 | case T_INTERFACE: |
||
| 110 | $class = $this->extractors->interface->extract($n, $tokens); |
||
| 111 | $class->setNameResolver($nameResolver); |
||
| 112 | // push class AND in global AND in local class map |
||
| 113 | $this->result->pushClass($class); |
||
| 114 | $result->pushClass($class); |
||
| 115 | break; |
||
| 116 | |||
| 117 | case T_EXTENDS: |
||
| 118 | $i = $n; |
||
| 119 | $parent = $this->searcher->getFollowingName($i, $tokens); |
||
| 120 | $class->setParent(trim($parent)); |
||
| 121 | break; |
||
| 122 | |||
| 123 | case T_IMPLEMENTS: |
||
| 124 | $i = $n + 1; |
||
| 125 | $contracts = $this->searcher->getUnder(array('{'), $i, $tokens); |
||
| 126 | $contracts = explode(',', $contracts); |
||
| 127 | $contracts = array_map('trim', $contracts); |
||
| 128 | $class->setInterfaces($contracts); |
||
| 129 | break; |
||
| 130 | |||
| 131 | case T_CLASS: |
||
| 132 | $c = $this->extractors->class->extract($n, $tokens); |
||
| 133 | $c->setNameResolver($nameResolver); |
||
| 134 | // push class AND in global AND in local class map |
||
| 135 | $this->result->pushClass($c); |
||
| 136 | $result->pushClass($c); |
||
| 137 | |||
| 138 | // PHP 7 and inner classes |
||
| 139 | if($c instanceof ReflectedAnonymousClass) { |
||
| 140 | // avoid to consider anonymous class as main class |
||
| 141 | $endAnonymous = $this->searcher->getPositionOfClosingBrace($p = $n, $tokens); |
||
| 142 | $mainContextClass = $class; |
||
| 143 | |||
| 144 | // add anonymous class in method |
||
| 145 | if($method) { |
||
| 146 | $method->pushAnonymousClass($c); |
||
| 147 | } |
||
| 148 | } |
||
| 149 | $class = $c; |
||
| 150 | break; |
||
| 151 | |||
| 152 | case T_FUNCTION: |
||
| 153 | if($class) { |
||
| 154 | // avoid closure |
||
| 155 | $next = $tokens[$n + 1]; |
||
| 156 | if(T_WHITESPACE != $next->getType()) { |
||
| 157 | continue; |
||
| 158 | } |
||
| 159 | $method = $this->extractors->method->extract($n, $tokens); |
||
| 160 | $method->setNamespace($namespace); |
||
| 161 | $class->pushMethod($method); |
||
| 162 | } |
||
| 163 | break; |
||
| 164 | } |
||
| 165 | |||
| 166 | } |
||
| 167 | return $result; |
||
| 168 | } |
||
| 169 | |||
| 170 | }; |
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.