Hal\Component\Phar\Updater::updates()

Complexity

Conditions	11
Paths	16

Size

Total Lines	53
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function updates($version = self::LATEST) {
        $tag = $version;
        if(self::LATEST == $version) {
            $tag = 'master';
        }

        if (ini_get('phar.readonly') == true) {

It seems like you are loosely comparing ini_get('phar.readonly') of type string to the boolean true. If you are specifically checking for a non-empty string, consider using the more explicit !== '' instead.

            throw new \RuntimeException('Unable to update the PHAR, phar.readonly is set, use \'-d phar.readonly=0\'');
        }

        if (ini_get('allow_url_fopen') == false) {

It seems like you are loosely comparing ini_get('allow_url_fopen') of type string to the boolean false. If you are specifically checking for an empty string, consider using the more explicit === '' instead.

            throw new \RuntimeException('Unable to update the PHAR, allow_url_fopen is not set, use \'-d allow_url_fopen=1\'');
        }

        $currentPharLocation = \Phar::running(false);
        if(!file_exists($currentPharLocation) ||strlen($currentPharLocation) == 0) {
            throw new \LogicException("You're not currently using Phar. If you have installed PhpMetrics with Composer, please updates it using Composer.");
        }

        if(!is_writable($currentPharLocation)) {
            throw new \RuntimeException(sprintf('%s is not writable', $currentPharLocation));
        }

        // downloading
        $url = sprintf($this->url, $tag);
        $ctx = stream_context_create();
        stream_context_set_params($ctx, array("notification" => array($this, 'stream_notification_callback')));
        $content = file_get_contents($url, false, $ctx);

        // replacing file
        if(!$content) {
            throw new \RuntimeException('Download failed');
        }

        // check if all is OK
        $tmpfile = tempnam(sys_get_temp_dir(), 'phar');
        file_put_contents($tmpfile, $content);
        $output = shell_exec(sprintf('"%s" "%s" --version', PHP_BINARY, $tmpfile));
        if(!preg_match('!(v\d+\.\d+\.\d+)!', $output, $matches)) {
            throw new \RuntimeException('Phar is corrupted. Please retry');
        }

        // compare versions
        $downloadedVersion = $matches[1];
        if(self::LATEST !==$version &&$downloadedVersion !== $version) {
            throw new \RuntimeException('Incorrect version. Please retry');
        }

        // at this step, all is ok
        file_put_contents($currentPharLocation, $content);
        return $version;

    }

}