HalalSoft / laravel-dynamic-column

src/HasDynamicColumn.php

<?php

namespace Halalsoft\LaravelDynamicColumn;


trait HasDynamicColumn
{

    /**
     * Boot the MariaDB Dynamic Column  trait.
     *
     * @return void
     */
    protected static function bootHasDynamicColumn()
    {
        static::addGlobalScope(new DynamicScope());
        static::saving(
            function($model) {
                foreach ($model->getCasts() as $column => $cast) {
                    if ($cast == 'Halalsoft\LaravelDynamicColumn\Dynamic' || $cast == "Halalsoft\LaravelDynamicColumn\DynamicObject") {
                        $model->$column = $model->$column;
                    }
                }
            }
        );
    }


    protected function newBaseQueryBuilder()
    {
        $connection = $this->getConnection();

It seems like getConnection() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return new DynamicBuilder(
            $connection, $connection->setQueryGrammar(new DynamicGrammar())->getQueryGrammar(),
            $connection->getPostProcessor(), $this

$this of type Halalsoft\LaravelDynamicColumn\HasDynamicColumn is incompatible with the type Illuminate\Database\Eloquent\Model|null expected by parameter $model of Halalsoft\LaravelDynamicColumn\DynamicBuilder::__construct().

        );
    }


    public function getDynamicColumns()
    {
        $columns = [];
        foreach ($this->getCasts() as $column => $cast) {

It seems like getCasts() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if ($cast == "Halalsoft\LaravelDynamicColumn\Dynamic" || $cast == "Halalsoft\LaravelDynamicColumn\DynamicObject") {
                $columns[] = $column;
            }
        }

        return $columns;
    }

}