Issues in AltoRouter.php - Fixed Issues - Inspection of "fix phpunit tests" - HakimCh/Router - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 723c8d...5629e4 )

by Ch
created 2017-10-09 13:46 UTC
AltoRouter.php (3 issues)

Labels

Severity

<?php

class AltoRouter
{
	protected $routes = array();
	protected $namedRoutes = array();
	protected $basePath = '';
	protected $matchTypes = array(
		'i'  => '[0-9]++',
		'a'  => '[0-9A-Za-z]++',
		'h'  => '[0-9A-Fa-f]++',
		'*'  => '.+?',
		'**' => '.++',
		''   => '[^/\.]++'
	);
	protected $all = array(
		'get', 'post'
	);
	private $server;

	/**
	 * Create router in one call from config.
	 *
	 * @param array $routes
	 * @param string $basePath
	 * @param array $matchTypes
	 */
	public function __construct($routes = array(), $basePath = '', $matchTypes = array(), $server = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		$this->addRoutes($routes);
		$this->setBasePath($basePath);
		$this->addMatchTypes($matchTypes);
		if(!$server) {
			$this->server = $_SERVER;
		}
	}

	/**
	 * Retrieves all routes.
	 * Useful if you want to process or display routes.
	 * @return array All routes.
	 */
	public function getRoutes()
	{
		return $this->routes;
	}

	/**
	 * Add multiple routes at once from array in the following format:
	 *
	 *   $routes = array(
	 *      array($method, $route, $target, $name)
	 *   );
	 *
	 * @param array $routes
	 * @return void
	 * @author Koen Punt
	 */
	public function addRoutes($routes)
	{
		if (!is_array($routes) && !$routes instanceof Traversable) {
			throw new Exception('Routes should be an array or an instance of Traversable');
		}
		if(!empty($routes)) {
			foreach ($routes as $route) {
				call_user_func_array(array($this, 'map'), $route);
			}
		}
	}

	/**
	 * Set the base path.
	 * Useful if you are running your application from a subdirectory.
	 */
	public function setBasePath($basePath)
	{
		$this->basePath = $basePath;
	}

	/**
	 * Add named match types. It uses array_merge so keys can be overwritten.
	 *
	 * @param array $matchTypes The key is the name and the value is the regex.
	 */
	public function addMatchTypes($matchTypes)
	{
		$this->matchTypes = array_merge($this->matchTypes, $matchTypes);
	}

	/**
	 * Map a route to a target
	 *
	 * @param string $method One of 5 HTTP Methods, or a pipe-separated list of multiple HTTP Methods (GET|POST|PATCH|PUT|DELETE)
	 * @param string $route The route regex, custom regex must start with an @. You can use multiple pre-set regex filters, like [i:id]
	 * @param mixed $target The target where this route should point to. Can be anything.
	 * @param string $name Optional name of this route. Supply if you want to reverse route this url in your application.
	 */
	public function map($method, $route, $target, $name = null)
	{
		if ($name) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			if (isset($this->namedRoutes[$name])) {
				throw new \Exception("Can not redeclare route '{$name}'");
			}
			$this->namedRoutes[$name] = $route;
		}

		$this->routes[] = array($method, $route, $target, $name);
	}

	/**
	 * Reversed routing
	 *
	 * Generate the URL for a named route. Replace regexes with supplied parameters
	 *
	 * @param string $routeName The name of the route.
	 * @param array @params Associative array of parameters to replace placeholders with.
	 * @return string The URL of the route with named parameters in place.
	 */
	public function generate($routeName, array $params = array())
	{

		// Check if named route exists
		if (!isset($this->namedRoutes[$routeName])) {
			throw new \Exception("Route '{$routeName}' does not exist.");
		}

		// Replace named parameters
		$route = $this->namedRoutes[$routeName];

		// prepend base path to route url again
		$url = $this->basePath . $route;

		if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
			foreach ($matches as $match) {
				$block  = $match[0];
				$pre    = $match[1];
				$param  = $match[3];

				if ($pre) {
					$block = substr($block, 1);
				}

				if (isset($params[$param])) {
					$url = str_replace($block, $params[$param], $url);
				} elseif ($match[4]) {
					$url = str_replace($pre . $block, '', $url);
				}
			}
		}

		return $url;
	}

	/**
	 * Match a given Request Url against stored routes
	 * @param string $requestUrl
	 * @param string $requestMethod
	 * @return array|boolean Array with route information on success, false on failure (no match).
	 */
	public function match($requestUrl = null, $requestMethod = null)
	{
		$params = array();

		$requestUrl = $this->getRequestUrl($requestUrl);

		// set Request Method if it isn't passed as a parameter
		if (is_null($requestMethod)) {
			$requestMethod = $this->server['REQUEST_METHOD'];
		}

		foreach ($this->routes as $handler) {
			// Method did not match, continue to next route.
			if (!$this->methodMatch($handler[0], $requestMethod, $handler[1], $requestUrl)) {
				continue;
			}

			return array(
				'target' => $handler[2],
				'params' => array_filter($params, function ($k) { return !is_numeric($k); }, ARRAY_FILTER_USE_KEY),
				'name'   => $handler[3]
			);
		}

		return false;
	}

	/**
	 * Compile the regex for a given route (EXPENSIVE)
	 */
	private function compileRoute($routeString, $requestUrl)
	{
		$route = $this->getRoute($routeString, $requestUrl);

		if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
			$matchTypes = $this->matchTypes;
			foreach ($matches as $match) {
				list($block, $pre, $type, $param, $optional) = $match;

				if (isset($matchTypes[$type])) {
					$type = $matchTypes[$type];
				}
				if ($pre === '.') {
					$pre = '\.';
				}

				//Older versions of PCRE require the 'P' in (?P<named>)
				$pattern = '(?:'
				           . ($pre !== '' ? $pre : null)
				           . '('
				           . ($param !== '' ? "?P<$param>" : null)
				           . $type
				           . '))'
				           . ($optional !== '' ? '?' : null);

				$route = str_replace($block, $pattern, $route);
			}
		}

		return "`^$route$`u";
	}

	/**
	 * @param $requestUrl
	 *
	 * @return mixed
	 */
	private function getRequestUrl($requestUrl)
	{
		// set Request Url if it isn't passed as parameter
		if (is_null($requestUrl)) {
			$requestUrl = parse_url($this->server['REQUEST_URI'], PHP_URL_PATH);
		}

		return str_replace($this->basePath, '', $requestUrl);
	}

	/**
	 * @param $method
	 * @param $requestMethod
	 * @param $routeString
	 * @param $requestUrl
	 *
	 * @return mixed
	 */
	private function methodMatch($method, $requestMethod, $routeString, $requestUrl)
	{
		$method = strtolower($method);
		$requestMethod = strtolower($requestMethod);
		$methods = explode('|', $method);

		if(in_array($requestMethod, $methods))
		{
			if($routeString == '*') return true;

			if(is_array($routeString) && !empty($routeString)) {
				if($routeString[0] == '@') {
					return preg_match('`' . substr($routeString, 1) . '`u', $requestUrl, $params);
					return preg_match('`' . substr(/** @scrutinizer ignore-type */ $routeString, 1) . '`u', $requestUrl, $params);
				}
				$regex = $this->compileRoute($routeString, $requestUrl);
				return preg_match($regex, $requestUrl, $params);
			}
		}

		return false;
	}

	/**
	 * @param $routeString
	 * @param $requestUrl
	 *
	 * @return bool|string
	 */
	private function getRoute($routeString, $requestUrl)
	{
		$iPointer = $jPointer = 0;
		$nPointer = isset($routeString[0]) ? $routeString[0] : null;
		$regex = $route = false;

		// Find the longest non-regex substring and match it against the URI
		while (true) {
			if (!isset($routeString[$iPointer])) {
				break;
			}
			if ($regex === false) {
				if(!$this->getRouteRegexCheck($nPointer, $jPointer, $iPointer, $routeString, $requestUrl)) {
					continue;
				}
				$jPointer++;
			}
			$route .= $routeString[$iPointer++];
		}

		return $route;
	}

	private function getRouteRegexCheck($nPointer, $jPointer, $iPointer, $routeString, $requestUrl)
	{
		$cPointer = $nPointer;
		$regex = in_array($cPointer, array('[', '(', '.'));
		if (!$regex && isset($routeString[$iPointer+1])) {
			$nPointer = $routeString[$iPointer + 1];
			$regex = in_array($nPointer, array('?', '+', '*', '{'));
		}
		if (!$regex && $cPointer !== '/' && (!isset($requestUrl[$jPointer]) || $cPointer !== $requestUrl[$jPointer])) {
			return false;
		}
		return true;
	}

	public function __call($method, $arguments)
	{
		if(!in_array($method, array('get', 'post', 'delete', 'put', 'patch', 'update', 'all'))) {
			throw new Exception($method . ' not exist in the '. __CLASS__);
		}

		$methods = $method == 'all' ? implode('|', $this->all) : $method;

		$route = array_merge(array($methods), $arguments);

		call_user_func_array(array($this, 'map'), $route);
	}

	public function __toString()
	{
		return 'AltoRouter';
	}
}

HakimCh / Router

Push — master ( 723c8d...5629e4 )

AltoRouter.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like
