Hackathonners / swap

app/Providers/AppServiceProvider.php

<?php

namespace App\Providers;

use App\Judite\Models\Settings;
use Illuminate\Support\Facades\App;
use Illuminate\Support\Facades\URL;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\ServiceProvider;
use Illuminate\Support\Facades\Validator;
use App\Judite\Registry\EloquentExchangeRegistry;
use App\Judite\Contracts\Registry\ExchangeRegistry;

class AppServiceProvider extends ServiceProvider
{
    /**
     * Bootstrap any application services.
     */
    public function boot()
    {
        if (App::environment('production')) {

The call to Illuminate\Support\Facades\App::environment() has too many arguments starting with 'production'.

            URL::forceScheme('https');
        }

        Auth::macro('student', function () {
            return Auth::check() ? Auth::user()->student : null;

Accessing student on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        });

        Validator::extend('student_number', function ($attribute, $value, $parameters, $validator) {

The parameter $validator is not used and could be removed.

The parameter $parameters is not used and could be removed.

            return preg_match('/^(a|pg)[0-9]+$/i', $value) === 1;
        });
    }

    /**
     * Register any application services.
     */
    public function register()
    {
        $this->app->singleton(ExchangeRegistry::class, function ($app) {

The parameter $app is not used and could be removed.

            return new EloquentExchangeRegistry();
        });

        $this->app->singleton('settings', function ($app) {

The parameter $app is not used and could be removed.

            return Settings::firstOrNew([]);
        });
    }
}