Hackathonners / swap

app/Http/Controllers/ExchangeController.php

<?php

namespace App\Http\Controllers;

use App\Judite\Models\Exchange;
use Illuminate\Support\Facades\DB;
use App\Events\ExchangeWasDeclined;
use App\Events\ExchangeWasConfirmed;
use Illuminate\Support\Facades\Auth;

class ExchangeController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('can.student');
        $this->middleware('student.verified');
        $this->middleware('can.exchange');
    }

    /**
     * Store a confirmation of an exchange in storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function confirm($id)
    {
        $exchange = DB::transaction(function () use ($id) {
            $exchange = Auth::student()->proposedExchanges()->findOrFail($id);

            return $exchange->perform();
        });
        flash('The shift exchange request was successfully confirmed.')->success();
        event(new ExchangeWasConfirmed($exchange));

It seems like $exchange can also be of type null; however, parameter $exchange of App\Events\ExchangeWasConfirmed::__construct() does only seem to accept App\Judite\Models\Exchange, maybe add an additional type check?

        return redirect()->back();
    }

    /**
     * Store a decline of an exchange in storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function decline($id)
    {
        $exchange = DB::transaction(function () use ($id) {
            $exchange = Auth::student()->proposedExchanges()->findOrFail($id);
            $exchange->delete();

            return $exchange;
        });
        flash('The shift exchange request was successfully declined.')->success();
        event(new ExchangeWasDeclined($exchange));

It seems like $exchange can also be of type null; however, parameter $exchange of App\Events\ExchangeWasDeclined::__construct() does only seem to accept App\Judite\Models\Exchange, maybe add an additional type check?

        return redirect()->back();
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy($id)
    {
        DB::transaction(function () use ($id) {
            Auth::student()->requestedExchanges()->findOrFail($id)->delete();
        });
        flash('The shift exchange request was successfully deleted.')->success();

        return redirect()->back();
    }
}