GroupStudentController::decline() - Code Metrics - Inspection of "feat: add groups feature" - Hackathonners/swap - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#18)

unknown

created 2019-07-02 14:12 UTC

GroupStudentController::decline() A

↳ Parent: GroupStudentController

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	6
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	12
rs	10

<?php

namespace App\Http\Controllers;

use App\Judite\Models\Group;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Auth;

class GroupStudentController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('can.group');
        $this->middleware('can.student');
        $this->middleware('student.verified');
    }

    /**
     * Confirm joining a group.
     *
     * @param \App\Judite\Models\Group  $group
     * 
     * @return \Illuminate\Http\RedirectResponse
     */
    public function confirm(Group $group)
    {
        $student = DB::transaction(function () {
            return Auth::user()->student;

        });

        $this->authorize('reply-group', [$student, $group]);

        DB::transaction(function () use ($student, $group) {
            return $student->confirmGroup($group);
        });
        flash('The group request was successfully confirmed.')->success();

        return redirect()->back();
    }

    /**
     * Decline joining a group.
     * 
     * @param \App\Judite\Models\Group  $group
     * 
     * @return \Illuminate\Http\RedirectResponse
     */
    public function decline(Group $group)
    {
        $student = Auth::user()->student;


        $this->authorize('reply-group', [$student, $group]);

        DB::transaction(function () use ($student, $group) {
            return $student->declineGroup($group);
        });
        flash('The group request was successfully declined.')->success();

        return redirect()->back();
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Judite\Models\Group;
6			use Illuminate\Support\Facades\DB;
7			use Illuminate\Support\Facades\Auth;
8
9			class GroupStudentController extends Controller
10			{
11			/**
12			* Create a new controller instance.
13			*/
14			public function __construct()
15			{
16			$this->middleware('auth');
17			$this->middleware('can.group');
18			$this->middleware('can.student');
19			$this->middleware('student.verified');
20			}
21
22			/**
23			* Confirm joining a group.
24			*
25			* @param \App\Judite\Models\Group $group
26			*
27			* @return \Illuminate\Http\RedirectResponse
28			*/
29			public function confirm(Group $group)
30			{
31			$student = DB::transaction(function () {
32			return Auth::user()->student;
			0 ignored issues – show Bug introduced 2019-07-02 14:19 UTC by Report Bug Copy Issue Report Accessing `student` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
33			});
34
35			$this->authorize('reply-group', [$student, $group]);
36
37			DB::transaction(function () use ($student, $group) {
38			return $student->confirmGroup($group);
39			});
40			flash('The group request was successfully confirmed.')->success();
41
42			return redirect()->back();
43			}
44
45			/**
46			* Decline joining a group.
47			*
48			* @param \App\Judite\Models\Group $group
49			*
50			* @return \Illuminate\Http\RedirectResponse
51			*/
52			public function decline(Group $group)
53			{
54			$student = Auth::user()->student;
			0 ignored issues – show Bug introduced 2017-08-23 15:05 UTC by Report Bug Copy Issue Report Accessing `student` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
55
56			$this->authorize('reply-group', [$student, $group]);
57
58			DB::transaction(function () use ($student, $group) {
59			return $student->declineGroup($group);
60			});
61			flash('The group request was successfully declined.')->success();
62
63			return redirect()->back();
64			}
65			}
66

Hackathonners / swap

Pull Request — develop (#18)

GroupStudentController::decline() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like