App\Http\Controllers\Admin\GroupController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	17	3
A	__construct()	0	4	1
A	index()	0	11	1

<?php

namespace App\Http\Controllers\Admin;

use App\Judite\Models\Group;
use App\Judite\Models\Course;
use Illuminate\Support\Facades\DB;
use App\Http\Controllers\Controller;

class GroupController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('can.admin');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $courses = DB::transaction(function () {
            return Course::orderedList()->get();
        });

        $courses = $courses->groupBy(function ($course) {
            return $course->present()->getOrdinalYear();
        });

        return view('admin.groups.index', compact('courses'));

The expression return view('admin.groups.index', compact('courses')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($courseId)
    {
        $groups = Group::whereCourseId($courseId)->get();

        foreach ($groups as $group) {
            $memberships = $group->memberships()->get();

            $students = [];
            foreach ($memberships as $membershipKey => $membership) {
                $student = $membership->student()->first();
                $student->name = $student->user()->first()->name;
                array_push($students, $student);
            }
            $group->students = $students;

The property students does not seem to exist on App\Judite\Models\Group. Are you sure there is no database migration missing?

        }

        return view('admin.groups.show', compact('groups'));

The expression return view('admin.groups.show', compact('groups')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }
}