GroupController::index() - Code Metrics - Inspection of "Add groups to courses" - Hackathonners/swap - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#11)

unknown

created 2018-10-06 13:44 UTC

GroupController::index() A

↳ Parent: GroupController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	0
dl	0
loc	11
rs	10
c	0
b	0
f	0

<?php

namespace App\Http\Controllers\Admin;

use App\Judite\Models\Group;
use App\Judite\Models\Course;
use Illuminate\Support\Facades\DB;
use App\Http\Controllers\Controller;

class GroupController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('auth');
        $this->middleware('can.admin');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\View\View
     */
    public function index()
    {
        $courses = DB::transaction(function () {
            return Course::orderedList()->get();
        });

        $courses = $courses->groupBy(function ($course) {
            return $course->present()->getOrdinalYear();
        });

        return view('admin.groups.index', compact('courses'));
    }

    /**
     * Display the specified resource.
     *
     * @param int $courseId
     *
     * @return \Illuminate\View\View
     */
    public function show($courseId)
    {
        $groups = DB::transaction(function () use ($courseId) {
            return Group::with('memberships.student.user')->whereCourseId($courseId)->get();
        });

        return view('admin.groups.show', compact('groups'));
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Admin;
4
5			use App\Judite\Models\Group;
6			use App\Judite\Models\Course;
7			use Illuminate\Support\Facades\DB;
8			use App\Http\Controllers\Controller;
9
10			class GroupController extends Controller
11			{
12			/**
13			* Create a new controller instance.
14			*/
15			public function __construct()
16			{
17			$this->middleware('auth');
18			$this->middleware('can.admin');
19			}
20
21			/**
22			* Display a listing of the resource.
23			*
24			* @return \Illuminate\View\View
25			*/
26			public function index()
27			{
28			$courses = DB::transaction(function () {
29			return Course::orderedList()->get();
30			});
31
32			$courses = $courses->groupBy(function ($course) {
33			return $course->present()->getOrdinalYear();
34			});
35
36			return view('admin.groups.index', compact('courses'));
37			}
38
39			/**
40			* Display the specified resource.
41			*
42			* @param int $courseId
43			*
44			* @return \Illuminate\View\View
45			*/
46			public function show($courseId)
47			{
48			$groups = DB::transaction(function () use ($courseId) {
49			return Group::with('memberships.student.user')->whereCourseId($courseId)->get();
50			});
51
52			return view('admin.groups.show', compact('groups'));
53			}
54			}
55

Hackathonners / swap

Pull Request — develop (#11)

GroupController::index() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like