App\Http\Controllers\ExchangeController::store()

Complexity

Conditions	3
Paths	3

Size

Total Lines	39
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	ExchangeController::checkDecideAuthorization()	0	11	3

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Judite\Models\Exchange;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Mail;
use App\Mail\DeclinedExchangeNotification;
use App\Mail\ConfirmedExchangeNotification;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Database\Eloquent\ModelNotFoundException;

class ExchangeController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('can.exchange');
    }

    /**
     * Store a confirmation of an exchange in storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function confirm($id)

This method seems to be duplicated in your project.

    {
        $exchange = DB::transaction(function () use ($id) {
            $exchange = Exchange::findOrFail($id);
            $this->checkDecideAuthorization($exchange);

            return $exchange->perform();
        });

        flash('The shift exchange request was successfully confirmed.')->success();
        Mail::to($exchange->fromStudent()->user)
            ->send(new ConfirmedExchangeNotification($exchange));

        return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a decline of an exchange in storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function decline($id)

This method seems to be duplicated in your project.

    {
        $exchange = DB::transaction(function () use ($id) {
            $exchange = Exchange::findOrFail($id);
            $this->checkDecideAuthorization($exchange);
            $exchange->delete();

            return $exchange;
        });

        flash('The shift exchange request was successfully declined.')->success();
        Mail::to($exchange->fromStudent()->user)
            ->send(new DeclinedExchangeNotification($exchange));

        return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Checks authorization of the authenticated user to decide on the given exchange.
     *
     * @param \App\Judite\Models\Exchange $exchange
     *
     * @throws \Illuminate\Database\Eloquent\ModelNotFoundException
     * @throws \Illuminate\Auth\Access\AuthorizationException
     */
    private function checkDecideAuthorization(Exchange $exchange)
    {
        // We are going to hide the third-party enrollments from user that
        // sent the request. If they try to confirm their own exchanges
        // a 403 will be returned, otherwise a 404 will be simulated.
        try {
            $this->authorize('decide', $exchange);
        } catch (AuthorizationException $e) {
            throw $exchange->isOwnedBy(auth()->user()->student)
                ? $e
                : new ModelNotFoundException(get_class($exchange), $exchange->getKey());

It seems like $exchange->getKey() can also be of type Carbon\Carbon and string and boolean and double and Illuminate\Support\Collection; however, parameter $code of Illuminate\Database\Eloquent\ModelNotFoundException::__construct() does only seem to accept integer, maybe add an additional type check?

        }
    }
}