Enrollment::scopeOrderByStudent() - Code Metrics - Inspection of "Refactor views" - Hackathonners/swap - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( a20adc...5e6aa2 )

by Francisco

created 2017-08-27 00:04 UTC

Enrollment::scopeOrderByStudent() A

↳ Parent: Enrollment

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Judite\Models;

use Illuminate\Database\Eloquent\Model;
use Laracasts\Presenter\PresentableTrait;
use App\Judite\Presenters\EnrollmentPresenter;

class Enrollment extends Model
{
    use PresentableTrait;

    /**
     * The relations to eager load on every query.
     *
     * @var array
     */
    protected $with = ['student', 'shift', 'course'];

    /**
     * The presenter for this entity.
     *
     * @var string
     */
    protected $presenter = EnrollmentPresenter::class;

    /**
     * Scope a query to order enrollments by course.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeOrderByCourse($query)
    {
        return $query->select('enrollments.*')
            ->join('courses', 'enrollments.course_id', '=', 'courses.id')
            ->orderBy('courses.year', 'asc')
            ->orderBy('courses.semester', 'asc')
            ->orderBy('courses.name', 'asc');
    }

    /**
     * Scope a query to filter similar enrollments.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     * @param \App\Judite\Models\Enrollment         $enrollment
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeSimilarEnrollments($query, Enrollment $enrollment)
    {
        return $query->where('enrollments.id', '!=', $enrollment->id)
            ->where('course_id', $enrollment->course->id)
            ->where('shift_id', '!=', $enrollment->shift->id);
    }

    /**
     * Scope a query to order enrollments by students.
     *
     * @param \Illuminate\Database\Eloquent\Builder $query
     *
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeOrderByStudent($query)
    {
        return $query->select('enrollments.*')
            ->join('students', 'enrollments.student_id', '=', 'students.id')
            ->orderBy('students.student_number', 'asc');
    }

    /**
     * Exchange shifts with the given enrollment.
     *
     * @param \App\Judite\Models\Enrollment $enrollment
     *
     * @return $this
     */
    public function exchange(Enrollment $enrollment): Enrollment
    {
        $fromShiftId = $this->shift_id;
        $this->shift()->associate($enrollment->shift_id);
        $enrollment->shift()->associate($fromShiftId);

        $this->save();
        $enrollment->save();

        return $this;
    }

    /**
     * Get exchanges of this enrollment as source.
     *
     * @return \Illuminate\Database\Eloquent\Relations\HasMany
     */
    public function exchangesAsSource()
    {
        return $this->hasMany(Exchange::class, 'from_enrollment_id');
    }

    /**
     * Get student of this enrollment.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function student()
    {
        return $this->belongsTo(Student::class);
    }

    /**
     * Get course of this enrollment.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function course()
    {
        return $this->belongsTo(Course::class);
    }

    /**
     * Get shift of this enrollment.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function shift()
    {
        return $this->belongsTo(Shift::class);
    }

    /**
     * Check whether this enrollment is available for exchange.
     *
     * @return bool
     */
    public function availableForExchange()
    {
        $isBeingExchanged = is_null($this->exchanges_as_source_count)

            ? $this->exchangesAsSource()->exists()
            : $this->exchanges_as_source_count > 0;

        return ! $isBeingExchanged && ! is_null($this->shift_id);
    }
}


1			<?php
2
3			namespace App\Judite\Models;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Laracasts\Presenter\PresentableTrait;
7			use App\Judite\Presenters\EnrollmentPresenter;
8
9			class Enrollment extends Model
10			{
11			use PresentableTrait;
12
13			/**
14			* The relations to eager load on every query.
15			*
16			* @var array
17			*/
18			protected $with = ['student', 'shift', 'course'];
19
20			/**
21			* The presenter for this entity.
22			*
23			* @var string
24			*/
25			protected $presenter = EnrollmentPresenter::class;
26
27			/**
28			* Scope a query to order enrollments by course.
29			*
30			* @param \Illuminate\Database\Eloquent\Builder $query
31			*
32			* @return \Illuminate\Database\Eloquent\Builder
33			*/
34			public function scopeOrderByCourse($query)
35			{
36			return $query->select('enrollments.*')
37			->join('courses', 'enrollments.course_id', '=', 'courses.id')
38			->orderBy('courses.year', 'asc')
39			->orderBy('courses.semester', 'asc')
40			->orderBy('courses.name', 'asc');
41			}
42
43			/**
44			* Scope a query to filter similar enrollments.
45			*
46			* @param \Illuminate\Database\Eloquent\Builder $query
47			* @param \App\Judite\Models\Enrollment $enrollment
48			*
49			* @return \Illuminate\Database\Eloquent\Builder
50			*/
51			public function scopeSimilarEnrollments($query, Enrollment $enrollment)
52			{
53			return $query->where('enrollments.id', '!=', $enrollment->id)
54			->where('course_id', $enrollment->course->id)
55			->where('shift_id', '!=', $enrollment->shift->id);
56			}
57
58			/**
59			* Scope a query to order enrollments by students.
60			*
61			* @param \Illuminate\Database\Eloquent\Builder $query
62			*
63			* @return \Illuminate\Database\Eloquent\Builder
64			*/
65			public function scopeOrderByStudent($query)
66			{
67			return $query->select('enrollments.*')
68			->join('students', 'enrollments.student_id', '=', 'students.id')
69			->orderBy('students.student_number', 'asc');
70			}
71
72			/**
73			* Exchange shifts with the given enrollment.
74			*
75			* @param \App\Judite\Models\Enrollment $enrollment
76			*
77			* @return $this
78			*/
79			public function exchange(Enrollment $enrollment): Enrollment
80			{
81			$fromShiftId = $this->shift_id;
82			$this->shift()->associate($enrollment->shift_id);
83			$enrollment->shift()->associate($fromShiftId);
84
85			$this->save();
86			$enrollment->save();
87
88			return $this;
89			}
90
91			/**
92			* Get exchanges of this enrollment as source.
93			*
94			* @return \Illuminate\Database\Eloquent\Relations\HasMany
95			*/
96			public function exchangesAsSource()
97			{
98			return $this->hasMany(Exchange::class, 'from_enrollment_id');
99			}
100
101			/**
102			* Get student of this enrollment.
103			*
104			* @return \Illuminate\Database\Eloquent\Relations\BelongsTo
105			*/
106			public function student()
107			{
108			return $this->belongsTo(Student::class);
109			}
110
111			/**
112			* Get course of this enrollment.
113			*
114			* @return \Illuminate\Database\Eloquent\Relations\BelongsTo
115			*/
116			public function course()
117			{
118			return $this->belongsTo(Course::class);
119			}
120
121			/**
122			* Get shift of this enrollment.
123			*
124			* @return \Illuminate\Database\Eloquent\Relations\BelongsTo
125			*/
126			public function shift()
127			{
128			return $this->belongsTo(Shift::class);
129			}
130
131			/**
132			* Check whether this enrollment is available for exchange.
133			*
134			* @return bool
135			*/
136			public function availableForExchange()
137			{
138			$isBeingExchanged = is_null($this->exchanges_as_source_count)
			0 ignored issues – show Bug introduced 2017-08-27 00:07 UTC by Report Bug Copy Issue Report The property `exchanges_as_source_count` does not seem to exist on `App\Judite\Models\Enrollment`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
139			? $this->exchangesAsSource()->exists()
140			: $this->exchanges_as_source_count > 0;
141
142			return ! $isBeingExchanged && ! is_null($this->shift_id);
143			}
144			}
145

Hackathonners / swap

Push — develop ( a20adc...5e6aa2 )

Enrollment::scopeOrderByStudent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like