App\Http\Controllers\ExchangeController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	51
Duplicated Lines	50.98 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	decline()	13	13	1
A	__construct()	0	3	1
A	confirm()	12	12	1

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Judite\Models\Exchange;
use Illuminate\Support\Facades\DB;
use App\Events\ExchangeWasDeclined;
use App\Events\ExchangeWasConfirmed;

class ExchangeController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('can.exchange');
    }

    /**
     * Store a confirmation of an exchange in storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function confirm($id)

This method seems to be duplicated in your project.

    {
        $exchange = DB::transaction(function () use ($id) {
            $exchange = student()->proposedExchanges()->findOrFail($id);

            return $exchange->perform();
        });

        event(new ExchangeWasConfirmed($exchange));
        flash('The shift exchange request was successfully confirmed.')->success();

        return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a decline of an exchange in storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function decline($id)

This method seems to be duplicated in your project.

    {
        $exchange = DB::transaction(function () use ($id) {
            $exchange = student()->proposedExchanges()->findOrFail($id);
            $exchange->delete();

            return $exchange;
        });

        event(new ExchangeWasDeclined($exchange));
        flash('The shift exchange request was successfully declined.')->success();

        return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }
}