ExchangeController::storeDecline() - Code Metrics - Inspection of "Change package.json" - Hackathonners/swap - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( dfa246...179c36 )

by Francisco

created 2017-08-25 23:55 UTC

ExchangeController::storeDecline() A

↳ Parent: ExchangeController

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	11
nc	1
nop	1
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Judite\Models\Exchange;
use App\Judite\Models\Enrollment;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Mail;
use App\Mail\DeclinedExchangeNotification;
use App\Mail\ConfirmedExchangeNotification;
use App\Http\Requests\Exchange\CreateRequest;
use App\Exceptions\MultipleEnrollmentExchangesException;
use App\Exceptions\ExchangeEnrollmentWithoutShiftException;
use App\Exceptions\ExchangeEnrollmentsOnDifferentCoursesException;

class ExchangeController extends Controller
{
    /**
     * Create a new controller instance.
     */
    public function __construct()
    {
        $this->middleware('can.exchange');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @param int $enrollmentId
     *
     * @return \Illuminate\Http\Response
     */
    public function create($enrollmentId)
    {
        try {
            $data = DB::transaction(function () use ($enrollmentId) {
                $enrollment = Enrollment::findOrFail($enrollmentId);
                $this->authorize('exchange', $enrollment);

                if (is_null($enrollment->shift)) {
                    throw new \LogicException('Enrollments without associated shifts cannot be exchanged.');
                }

                $matchingEnrollments = Enrollment::similarEnrollments($enrollment)
                    ->orderByStudent()
                    ->get();

                return compact('enrollment', 'matchingEnrollments');
            });

            $data['matchingEnrollments'] = $data['matchingEnrollments']->map(function ($item) {
                return [
                    'id' => $item->id,
                    '_toString' => $item->present()->inlineToString(),
                ];
            });

            return view('exchanges.create', $data);

        } catch (\LogicException $e) {
            flash($e->getMessage())->error();

            return redirect()->route('home');

        }
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \App\Http\Requests\Exchange\CreateRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(CreateRequest $request)
    {
        try {
            DB::transaction(function () use ($request) {
                $this->validate($request, [
                    'from_enrollment_id' => 'exists:enrollments,id',
                    'to_enrollment_id' => 'exists:enrollments,id',
                ]);

                $fromEnrollment = Enrollment::find($request->input('from_enrollment_id'));
                $toEnrollment = Enrollment::find($request->input('to_enrollment_id'));
                $this->authorize('exchange', $fromEnrollment);

                // Firstly check if the inverse exchange for the same enrollments
                // already exists. If the inverse record is found then we will
                // exchange and update both enrollments of this exchange.
                $exchange = Exchange::findMatchingExchange($fromEnrollment, $toEnrollment);
                if (! is_null($exchange)) {
                    return $exchange->perform();
                }

                // Otherwise, we create a new exchange between both enrollments
                // so the user that owns the target enrollment can confirm the
                // exchange and allow the other user to enroll on the shift.
                $exchange = Exchange::make();
                $exchange->setExchangeEnrollments($fromEnrollment, $toEnrollment);
                $exchange->save();

                return $exchange;
            });

            flash('The exchange was successfully proposed.')->success();
        } catch (MultipleEnrollmentExchangesException
            | ExchangeEnrollmentsOnDifferentCoursesException
            | ExchangeEnrollmentWithoutShiftException $e) {
            flash($e->getMessage())->error();
        }

        return redirect()->route('home');

    }

    /**
     * Store a confirmation of an exchange in storage.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function storeConfirmation(Request $request)
    {
        $exchange = DB::transaction(function () use ($request) {
            $this->validate($request, [
                'exchange_id' => 'exists:exchanges,id',
            ]);

            $exchange = Exchange::find($request->input('exchange_id'));
            $this->authorize('decide', $exchange);

            return $exchange->perform();
        });

        flash('The shift exchange request was successfully confirmed.')->success();
        Mail::to($exchange->fromStudent()->user)
            ->send(new ConfirmedExchangeNotification($exchange));

        return redirect()->back();

    }

    /**
     * Store a decline of an exchange in storage.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function storeDecline(Request $request)
    {
        $exchange = DB::transaction(function () use ($request) {
            $this->validate($request, [
                'exchange_id' => 'exists:exchanges,id',
            ]);

            $exchange = Exchange::find($request->input('exchange_id'));
            $this->authorize('decide', $exchange);

            $exchange->delete();

            return $exchange;
        });

        flash('The shift exchange request was successfully declined.')->success();
        Mail::to($exchange->fromStudent()->user)
            ->send(new DeclinedExchangeNotification($exchange));

        return redirect()->back();

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request)
    {
        DB::transaction(function () use ($request) {
            $this->validate($request, [
                'exchange_id' => 'exists:exchanges,id',
            ]);

            $exchange = Exchange::find($request->input('exchange_id'));
            $this->authorize('delete', $exchange);

            $exchange->delete();

            return $exchange;
        });

        flash('The shift exchange request was successfully deleted.')->success();

        return redirect()->back();

    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use App\Judite\Models\Exchange;
7			use App\Judite\Models\Enrollment;
8			use Illuminate\Support\Facades\DB;
9			use Illuminate\Support\Facades\Mail;
10			use App\Mail\DeclinedExchangeNotification;
11			use App\Mail\ConfirmedExchangeNotification;
12			use App\Http\Requests\Exchange\CreateRequest;
13			use App\Exceptions\MultipleEnrollmentExchangesException;
14			use App\Exceptions\ExchangeEnrollmentWithoutShiftException;
15			use App\Exceptions\ExchangeEnrollmentsOnDifferentCoursesException;
16
17			class ExchangeController extends Controller
18			{
19			/**
20			* Create a new controller instance.
21			*/
22			public function __construct()
23			{
24			$this->middleware('can.exchange');
25			}
26
27			/**
28			* Show the form for creating a new resource.
29			*
30			* @param int $enrollmentId
31			*
32			* @return \Illuminate\Http\Response
33			*/
34			public function create($enrollmentId)
35			{
36			try {
37			$data = DB::transaction(function () use ($enrollmentId) {
38			$enrollment = Enrollment::findOrFail($enrollmentId);
39			$this->authorize('exchange', $enrollment);
40
41			if (is_null($enrollment->shift)) {
42			throw new \LogicException('Enrollments without associated shifts cannot be exchanged.');
43			}
44
45			$matchingEnrollments = Enrollment::similarEnrollments($enrollment)
46			->orderByStudent()
47			->get();
48
49			return compact('enrollment', 'matchingEnrollments');
50			});
51
52			$data['matchingEnrollments'] = $data['matchingEnrollments']->map(function ($item) {
53			return [
54			'id' => $item->id,
55			'_toString' => $item->present()->inlineToString(),
56			];
57			});
58
59			return view('exchanges.create', $data);
			0 ignored issues – show Bug Best Practice introduced 2017-08-23 11:08 UTC by Report Bug Copy Issue Report The expression `return view('exchanges.create', $data)` returns the type `Illuminate\View\View` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
60			} catch (\LogicException $e) {
61			flash($e->getMessage())->error();
62
63			return redirect()->route('home');
			0 ignored issues – show Bug Best Practice introduced 2017-08-23 11:08 UTC by Report Bug Copy Issue Report The expression `return redirect()->route('home')` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
64			}
65			}
66
67			/**
68			* Store a newly created resource in storage.
69			*
70			* @param \App\Http\Requests\Exchange\CreateRequest $request
71			*
72			* @return \Illuminate\Http\Response
73			*/
74			public function store(CreateRequest $request)
75			{
76			try {
77			DB::transaction(function () use ($request) {
78			$this->validate($request, [
79			'from_enrollment_id' => 'exists:enrollments,id',
80			'to_enrollment_id' => 'exists:enrollments,id',
81			]);
82
83			$fromEnrollment = Enrollment::find($request->input('from_enrollment_id'));
84			$toEnrollment = Enrollment::find($request->input('to_enrollment_id'));
85			$this->authorize('exchange', $fromEnrollment);
86
87			// Firstly check if the inverse exchange for the same enrollments
88			// already exists. If the inverse record is found then we will
89			// exchange and update both enrollments of this exchange.
90			$exchange = Exchange::findMatchingExchange($fromEnrollment, $toEnrollment);
91			if (! is_null($exchange)) {
92			return $exchange->perform();
93			}
94
95			// Otherwise, we create a new exchange between both enrollments
96			// so the user that owns the target enrollment can confirm the
97			// exchange and allow the other user to enroll on the shift.
98			$exchange = Exchange::make();
99			$exchange->setExchangeEnrollments($fromEnrollment, $toEnrollment);
100			$exchange->save();
101
102			return $exchange;
103			});
104
105			flash('The exchange was successfully proposed.')->success();
106			} catch (MultipleEnrollmentExchangesException
107			\| ExchangeEnrollmentsOnDifferentCoursesException
108			\| ExchangeEnrollmentWithoutShiftException $e) {
109			flash($e->getMessage())->error();
110			}
111
112			return redirect()->route('home');
			0 ignored issues – show Bug Best Practice introduced 2017-08-23 11:08 UTC by Report Bug Copy Issue Report The expression `return redirect()->route('home')` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
113			}
114
115			/**
116			* Store a confirmation of an exchange in storage.
117			*
118			* @param \Illuminate\Http\Request $request
119			*
120			* @return \Illuminate\Http\Response
121			*/
122			public function storeConfirmation(Request $request)
123			{
124			$exchange = DB::transaction(function () use ($request) {
125			$this->validate($request, [
126			'exchange_id' => 'exists:exchanges,id',
127			]);
128
129			$exchange = Exchange::find($request->input('exchange_id'));
130			$this->authorize('decide', $exchange);
131
132			return $exchange->perform();
133			});
134
135			flash('The shift exchange request was successfully confirmed.')->success();
136			Mail::to($exchange->fromStudent()->user)
137			->send(new ConfirmedExchangeNotification($exchange));
138
139			return redirect()->back();
			0 ignored issues – show Bug Best Practice introduced 2017-08-23 11:08 UTC by Report Bug Copy Issue Report The expression `return redirect()->back()` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
140			}
141
142			/**
143			* Store a decline of an exchange in storage.
144			*
145			* @param \Illuminate\Http\Request $request
146			*
147			* @return \Illuminate\Http\Response
148			*/
149			public function storeDecline(Request $request)
150			{
151			$exchange = DB::transaction(function () use ($request) {
152			$this->validate($request, [
153			'exchange_id' => 'exists:exchanges,id',
154			]);
155
156			$exchange = Exchange::find($request->input('exchange_id'));
157			$this->authorize('decide', $exchange);
158
159			$exchange->delete();
160
161			return $exchange;
162			});
163
164			flash('The shift exchange request was successfully declined.')->success();
165			Mail::to($exchange->fromStudent()->user)
166			->send(new DeclinedExchangeNotification($exchange));
167
168			return redirect()->back();
			0 ignored issues – show Bug Best Practice introduced 2017-08-23 11:08 UTC by Report Bug Copy Issue Report The expression `return redirect()->back()` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
169			}
170
171			/**
172			* Remove the specified resource from storage.
173			*
174			* @param \Illuminate\Http\Request $request
175			*
176			* @return \Illuminate\Http\Response
177			*/
178			public function destroy(Request $request)
179			{
180			DB::transaction(function () use ($request) {
181			$this->validate($request, [
182			'exchange_id' => 'exists:exchanges,id',
183			]);
184
185			$exchange = Exchange::find($request->input('exchange_id'));
186			$this->authorize('delete', $exchange);
187
188			$exchange->delete();
189
190			return $exchange;
191			});
192
193			flash('The shift exchange request was successfully deleted.')->success();
194
195			return redirect()->back();
			0 ignored issues – show Bug Best Practice introduced 2017-08-23 11:08 UTC by Report Bug Copy Issue Report The expression `return redirect()->back()` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
196			}
197			}
198

Hackathonners / swap

Push — develop ( dfa246...179c36 )

ExchangeController::storeDecline() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like