App\Http\Controllers\DashboardController::studentDashboard()

Complexity

Conditions	1
Paths	1

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function studentDashboard()
    {
        $data = DB::transaction(function () {
            $student = Auth::user()->student;

Accessing student on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $data['enrollments'] = $student

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

                ->enrollments()
                ->orderByCourse()
                ->withCount('exchangesAsSource')
                ->get();
            $data['requestedExchanges'] = $student->requestedExchanges()->get();
            $data['proposedExchanges'] = $student->proposedExchanges()->get();

            return $data;
        });

        // Group all enrollments by the year of their associated course, so
        // the enrollments listing is organized by year. This will allow
        // a better experience, since it matches the official order.
        $data['enrollments'] = $data['enrollments']->groupBy(function ($enrollment) {
            return $enrollment->course->present()->getOrdinalYear();
        });

        return view('dashboard', $data);

The expression return view('dashboard', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }