Issues in HelperConfig.php (master) - Issues in master - HaaseIT/HCSF - Measure and Improve Code Quality continuously with Scrutinizer

Issues (102)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/HelperConfig.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
HCSF - A multilingual CMS and Shopsystem
Copyright (C) 2014  Marcus Haase - [email protected]

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see <http://www.gnu.org/licenses/>.
*/

namespace HaaseIT\HCSF;

use Symfony\Component\Yaml\Yaml;
use Zend\ServiceManager\ServiceManager;

/**
 * Class HelperConfig
 * @package HaaseIT\HCSF
 */
class HelperConfig
{
    /**
     * @var array
     */
    protected $core = [];

    /**
     * @var array
     */
    protected $secrets = [];

    /**
     * @var array
     */
    protected $countries = [];

    /**
     * @var array
     */
    protected $shop = [];

    /**
     * @var array
     */
    protected $customer = [];

    /**
     * @var array
     */
    protected $navigation = [];

    /**
     * @var string
     */
    protected $lang;

    /**
     * @var array
     */
    protected $customization = [];

    /**
     *
     */
    public function __construct()
    {
        $this->loadCore();
        $this->loadCountries();

        $this->lang = $this->getLanguage();

        $this->loadSecrets();

        if ($this->core['enable_module_customer']) {
            $this->loadCustomer();
        }

        if ($this->core['enable_module_shop']) {
            $this->loadShop();
        }

        $this->loadCustomization();
    }

    /**
     * @return string
     */
    public function getLang()
    {
        return $this->lang;
    }

    /**
     *
     */
    protected function loadCore()
    {
        $core = Yaml::parse(file_get_contents(HCSF_BASEDIR.'config/core.yml'));
        if (is_file(PATH_BASEDIR.'config/core.yml')) {
            $core = array_merge($core, Yaml::parse(file_get_contents(PATH_BASEDIR.'config/core.yml')));
        }

        $core['directory_images'] = trim($core['directory_images'], " \t\n\r\0\x0B/"); // trim this

        if (!empty($core['maintenancemode']) && $core['maintenancemode']) {
            $core['enable_module_customer'] = false;
            $core['enable_module_shop'] = false;
            $core['templatecache_enable'] = false;
            $core['debug'] = false;
            $core['textcatsverbose'] = false;
        } else {
            $core['maintenancemode'] = false;
        }

        if ($core['enable_module_shop']) {
            $core['enable_module_customer'] = true;
        }

        $this->core = $core;
    }

    /**
     * @param string|false $setting
     * @return mixed
     */
    public function getCore($setting = false)

    {
        if (!$setting) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->core;
        }

        return !empty($this->core[$setting]) ? $this->core[$setting] : false;
    }

    /**
     *
     */
    protected function loadCountries()

    {
        $countries = Yaml::parse(file_get_contents(HCSF_BASEDIR.'config/countries.yml'));
        if (is_file(PATH_BASEDIR.'config/countries.yml')) {
            $countries = array_merge($countries, Yaml::parse(file_get_contents(PATH_BASEDIR.'config/countries.yml')));
        }

        $this->countries = $countries;
    }

    /**
     * @param string|false $setting
     * @return mixed
     */
    public function getCountries($setting = false)

    {
        if (!$setting) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->countries;
        }

        return !empty($this->countries[$setting]) ? $this->countries[$setting] : false;
    }

    /**
     *
     */
    protected function loadSecrets()

    {
        $secrets = Yaml::parse(file_get_contents(HCSF_BASEDIR.'config/secrets.yml'));
        if (is_file(PATH_BASEDIR.'config/secrets.yml')) {
            $secrets = array_merge($secrets, Yaml::parse(file_get_contents(PATH_BASEDIR.'config/secrets.yml')));
        }

        $this->secrets = $secrets;
    }

    /**
     * @param string|false $setting
     * @return mixed
     */
    public function getSecret($setting = false)

    {
        if (!$setting) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->secrets;
        }

        return !empty($this->secrets[$setting]) ? $this->secrets[$setting] : false;
    }

    /**
     *
     */
    protected function loadCustomer()

    {
        $customer = Yaml::parse(file_get_contents(HCSF_BASEDIR.'config/customer.yml'));
        if (is_file(PATH_BASEDIR.'/config/customer.yml')) {
            $customer = array_merge($customer, Yaml::parse(file_get_contents(PATH_BASEDIR.'config/customer.yml')));
        }

        $this->customer = $customer;
    }

    /**
     * @param string|bool $setting
     * @return mixed
     */
    public function getCustomer($setting = false)

    {
        if (!$setting) {
            return $this->customer;
        }

        return !empty($this->customer[$setting]) ? $this->customer[$setting] : false;
    }

    /**
     *
     */
    protected function loadShop()
    {
        $shop = Yaml::parse(file_get_contents(HCSF_BASEDIR.'config/shop.yml'));
        if (is_file(PATH_BASEDIR.'config/shop.yml')) {
            $shop = array_merge($shop, Yaml::parse(file_get_contents(PATH_BASEDIR.'config/shop.yml')));
        }
        if (isset($shop['vat_disable']) && $shop['vat_disable']) {
            $shop['vat'] = ['full' => 0, 'reduced' => 0];
        }

        $this->shop = $shop;
    }

    /**
     * @param string|false $setting
     * @return mixed
     */
    public function getShop($setting = false)

    {
        if (!$setting) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->shop;
        }

        return !empty($this->shop[$setting]) ? $this->shop[$setting] : false;
    }

    /**
     * @param ServiceManager $serviceManager
     */
    public function loadNavigation(ServiceManager $serviceManager)
    {
        if (is_file(PATH_BASEDIR.'config/navigation.yml')) {
            $navstruct = Yaml::parse(file_get_contents(PATH_BASEDIR.'config/navigation.yml'));
        } else {
            $navstruct = Yaml::parse(file_get_contents(HCSF_BASEDIR.'config/navigation.yml'));
        }

        if (!empty($navstruct) && $this->core['navigation_fetch_text_from_textcats']) {
            $textcats = $serviceManager->get('textcats');
            $TMP = [];

            foreach ($navstruct as $key => $item) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                foreach ($item as $subkey => $subitem) {
                    if (!empty($textcats->T($subkey))) {
                        $TMP[$key][$textcats->T($subkey)] = $subitem;
                    } else {
                        $TMP[$key][$subkey] = $subitem;
                    }
                }
            }
            $navstruct = $TMP;
            unset($TMP);
        }

        if (isset($navstruct['admin'])) {
            unset($navstruct['admin']);
        }

        $hardcodedtextcats = $serviceManager->get('hardcodedtextcats');

        $navstruct['admin'][$hardcodedtextcats->get('admin_nav_home')] = '/_admin/index.html';

        if ($this->core['enable_module_shop']) {
            $navstruct['admin'][$hardcodedtextcats->get('admin_nav_orders')] = '/_admin/shopadmin.html';
            $navstruct['admin'][$hardcodedtextcats->get('admin_nav_items')] = '/_admin/itemadmin.html';
            $navstruct['admin'][$hardcodedtextcats->get('admin_nav_itemgroups')] = '/_admin/itemgroupadmin.html';
        }

        if ($this->core['enable_module_customer']) {
            $navstruct['admin'][$hardcodedtextcats->get('admin_nav_customers')] = '/_admin/customeradmin.html';
        }

        $navstruct['admin'][$hardcodedtextcats->get('admin_nav_pages')] = '/_admin/pageadmin.html';
        $navstruct['admin'][$hardcodedtextcats->get('admin_nav_textcats')] = '/_admin/textcatadmin.html';
        $navstruct['admin'][$hardcodedtextcats->get('admin_nav_cleartemplatecache')] = '/_admin/cleartemplatecache.html';
        $navstruct['admin'][$hardcodedtextcats->get('admin_nav_clearimagecache')] = '/_admin/clearimagecache.html';
        $navstruct['admin'][$hardcodedtextcats->get('admin_nav_phpinfo')] = '/_admin/phpinfo.html';
        $navstruct['admin'][$hardcodedtextcats->get('admin_nav_dbstatus')] = '/_admin/dbstatus.html';

        $this->navigation = $navstruct;
    }

    /**
     * @param string|false $setting
     * @return mixed
     */
    public function getNavigation($setting = false)

    {
        if (!$setting) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->navigation;
        }

        return !empty($this->navigation[$setting]) ? $this->navigation[$setting] : false;
    }

    /**
     * @return int|mixed|string
     */
    public function getLanguage()
    {
        $langavailable = $this->core['lang_available'];
        if (
            $this->core['lang_detection_method'] === 'domain'
            && isset($this->core['lang_by_domain'])
            && is_array($this->core['lang_by_domain'])
        ) { // domain based language detection
            $serverservername = filter_input(INPUT_SERVER, 'SERVER_NAME', FILTER_SANITIZE_URL);
            foreach ($this->core['lang_by_domain'] as $sKey => $sValue) {
                if ($serverservername == $sValue || $serverservername == 'www.'.$sValue) {
                    $sLang = $sKey;
                    break;
                }
            }
        } elseif ($this->core['lang_detection_method'] === 'legacy') { // legacy language detection
            $sLang = key($langavailable);
            $getlanguage = filter_input(INPUT_GET, 'language', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
            $cookielanguage = filter_input(INPUT_COOKIE, 'language', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
            $serverhttpaccepptlanguage = filter_input(INPUT_SERVER, 'HTTP_ACCEPT_LANGUAGE', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
            if ($getlanguage !== null && array_key_exists($getlanguage, $langavailable)) {
                $sLang = strtolower($getlanguage);
                setcookie('language', strtolower($getlanguage), 0, '/');
            } elseif ($cookielanguage !== null && array_key_exists($cookielanguage, $langavailable)) {
                $sLang = strtolower($cookielanguage);
            } elseif ($serverhttpaccepptlanguage !== null && array_key_exists(substr($serverhttpaccepptlanguage, 0, 2), $langavailable)) {
                $sLang = substr($serverhttpaccepptlanguage, 0, 2);
            }
        }
        if (!isset($sLang)) {
            $sLang = key($langavailable);
        }

        return $sLang;
    }

    protected function loadCustomization()
    {
        $customization = [];

        if (is_file(PATH_BASEDIR.'config/customization.yml')) {
            $customization = array_merge($customization, Yaml::parse(file_get_contents(PATH_BASEDIR.'config/customization.yml')));
        }

        $this->customization = $customization;
    }

    /**
     * @param bool $setting
     * @return array|bool|mixed
     */
    public function getCustomization($setting = false) {

        if (!$setting) {
            return $this->customization;
        }

        return !empty($this->customization[$setting]) ? $this->customization[$setting] : false;
    }
}


1			<?php
2
3			/*
4			HCSF - A multilingual CMS and Shopsystem
5			Copyright (C) 2014 Marcus Haase - [email protected]
6
7			This program is free software: you can redistribute it and/or modify
8			it under the terms of the GNU General Public License as published by
9			the Free Software Foundation, either version 3 of the License, or
10			(at your option) any later version.
11
12			This program is distributed in the hope that it will be useful,
13			but WITHOUT ANY WARRANTY; without even the implied warranty of
14			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			GNU General Public License for more details.
16
17			You should have received a copy of the GNU General Public License
18			along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*/
20
21			namespace HaaseIT\HCSF;
22
23			use Symfony\Component\Yaml\Yaml;
24			use Zend\ServiceManager\ServiceManager;
25
26			/**
27			* Class HelperConfig
28			* @package HaaseIT\HCSF
29			*/
30			class HelperConfig
31			{
32			/**
33			* @var array
34			*/
35			protected $core = [];
36
37			/**
38			* @var array
39			*/
40			protected $secrets = [];

HaaseIT / HCSF

Issues (102)

Security Analysis not enabled

src/HelperConfig.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like