Issues in Customeradmin.php (master) - Issues in master - HaaseIT/HCSF - Measure and Improve Code Quality continuously with Scrutinizer

Issues (102)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controller/Admin/Customer/Customeradmin.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
    HCSF - A multilingual CMS and Shopsystem
    Copyright (C) 2014  Marcus Haase - [email protected]

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

namespace HaaseIT\HCSF\Controller\Admin\Customer;


use Zend\ServiceManager\ServiceManager;

/**
 * Class Customeradmin
 * @package HaaseIT\HCSF\Controller\Admin\Customer
 */
class Customeradmin extends Base
{
    /**
     * @var \Doctrine\DBAL\Connection
     */
    private $dbal;

    /**
     * @var \HaaseIT\HCSF\HardcodedText
     */
    private $hardcodedtextcats;

    /**
     * Customeradmin constructor.
     * @param ServiceManager $serviceManager
     */
    public function __construct(ServiceManager $serviceManager)
    {
        parent::__construct($serviceManager);
        $this->dbal = $serviceManager->get('dbal');
        $this->hardcodedtextcats = $serviceManager->get('hardcodedtextcats');
    }

    /**
     *
     */
    public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager, [], 'admin/base.twig');
        $this->P->cb_pagetype = 'content';
        $this->P->cb_subnav = 'admin';

        $CUA = [
            ['title' => $this->hardcodedtextcats->get('customeradmin_list_no'), 'key' => 'cust_no', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
            ['title' => $this->hardcodedtextcats->get('customeradmin_list_company'), 'key' => 'cust_corp', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
            ['title' => $this->hardcodedtextcats->get('customeradmin_list_name'), 'key' => 'cust_name', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
            ['title' => $this->hardcodedtextcats->get('customeradmin_list_town'), 'key' => 'cust_town', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
            ['title' => $this->hardcodedtextcats->get('customeradmin_list_active'), 'key' => 'cust_active', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
            [
                'title' => $this->hardcodedtextcats->get('customeradmin_list_edit'),
                'key' => 'cust_id',
                'width' => '16%',
                'linked' => true,
                'ltarget' => '/_admin/customeradmin.html',
                'lkeyname' => 'id',
                'lgetvars' => ['action' => 'edit',],
            ],
        ];
        $aPData = $this->handleCustomerAdmin($CUA, $this->serviceManager->get('twig'));
        $this->P->cb_customcontenttemplate = 'customer/customeradmin';
        $this->P->oPayload->cl_html = $aPData['customeradmin']['text'];
        $this->P->cb_customdata = $aPData;
    }

    /**
     * @param $CUA
     * @param $twig
     * @return mixed
     */
    private function handleCustomerAdmin($CUA, $twig)
    {
        $sType = 'all';
        $type = filter_input(INPUT_GET, 'type');
        if ($type !== null) {
            if ($type === 'active') {
                $sType = 'active';
            } elseif ($type === 'inactive') {
                $sType = 'inactive';
            }
        }
        $return = '';
        if (filter_input(INPUT_GET, 'action') === null) {
            $querybuilder = $this->dbal->createQueryBuilder();
            $querybuilder
                ->select(DB_ADDRESSFIELDS)
                ->from('customer')
                ->orderBy('cust_no', 'ASC')
            ;

            if ($sType === 'active') {
                $querybuilder
                    ->where('cust_active = ?')
                    ->setParameter(0, 'y')
                ;
            } elseif ($sType === 'inactive') {
                $querybuilder
                    ->where('cust_active = ?')
                    ->setParameter(0, 'n')
                ;
            }
            $stmt = $querybuilder->execute();
            if ($stmt->rowCount() !== 0) {
                $aData = $stmt->fetchAll();
                $return .= \HaaseIT\Toolbox\Tools::makeListtable($CUA, $aData, $twig);
            } else {
                $aInfo['nodatafound'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        } elseif (filter_input(INPUT_GET, 'action') === 'edit') {
            $iId = filter_input(INPUT_GET, 'id', FILTER_SANITIZE_NUMBER_INT);
            $aErr = [];
            if (filter_input(INPUT_POST, 'doEdit') === 'yes') {
                $sCustno = trim(filter_input(INPUT_POST, 'custno', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW));
                if (strlen($sCustno) < $this->config->getCustomer('minimum_length_custno')) {
                    $aErr['custnoinvalid'] = true;
                } else {
                    $querybuilder = $this->dbal->createQueryBuilder();
                    $querybuilder
                        ->select(DB_ADDRESSFIELDS)
                        ->from('customer')
                        ->where('cust_id != ?')
                        ->andWhere('cust_no = ?')
                        ->setParameter(0, $iId)
                        ->setParameter(1, $sCustno)
                    ;
                    $stmt = $querybuilder->execute();

                    if ($stmt->rowCount() === 1) {
                        $aErr['custnoalreadytaken'] = true;
                    }

                    $querybuilder = $this->dbal->createQueryBuilder();
                    $querybuilder
                        ->select(DB_ADDRESSFIELDS)
                        ->from('customer')
                        ->where('cust_id != ?')
                        ->andWhere('cust_email = ?')
                        ->setParameter(0, $iId)
                        ->setParameter(1, filter_input(INPUT_POST, 'email', FILTER_SANITIZE_EMAIL))
                    ;
                    $stmt = $querybuilder->execute();
                    if ($stmt->rowCount() === 1) {
                        $aErr['emailalreadytaken'] = true;
                    }
                    $aErr = $this->helperCustomer->validateCustomerForm($this->config->getLang(), $aErr, true);
                    if (count($aErr) === 0) {
                        $querybuilder = $this->dbal->createQueryBuilder();
                        $querybuilder
                            ->update('customer')
                            ->set('cust_no', ':cust_no')
                            ->set('cust_email', ':cust_email')
                            ->set('cust_corp', ':cust_corp')
                            ->set('cust_name', ':cust_name')
                            ->set('cust_street', ':cust_street')
                            ->set('cust_zip', ':cust_zip')
                            ->set('cust_town', ':cust_town')
                            ->set('cust_phone', ':cust_phone')
                            ->set('cust_cellphone', ':cust_cellphone')
                            ->set('cust_fax', ':cust_fax')
                            ->set('cust_country', ':cust_country')
                            ->set('cust_group', ':cust_group')
                            ->set('cust_emailverified', ':cust_emailverified')
                            ->set('cust_active', ':cust_active')
                            ->where('cust_id = :cust_id')
                            ->setParameter(':cust_no', $sCustno)
                            ->setParameter(':cust_email', trim(filter_input(INPUT_POST, 'email', FILTER_SANITIZE_EMAIL)))
                            ->setParameter(':cust_corp', trim(filter_input(INPUT_POST, 'corpname', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_name', trim(filter_input(INPUT_POST, 'name', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_street', trim(filter_input(INPUT_POST, 'street', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_zip', trim(filter_input(INPUT_POST, 'zip', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_town', trim(filter_input(INPUT_POST, 'town', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_phone', trim(filter_input(INPUT_POST, 'phone', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_cellphone', trim(filter_input(INPUT_POST, 'cellphone', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_fax', trim(filter_input(INPUT_POST, 'fax', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_country', trim(filter_input(INPUT_POST, 'country', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_group', trim(filter_input(INPUT_POST, 'custgroup', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
                            ->setParameter(':cust_emailverified', (filter_input(INPUT_POST, 'emailverified') === 'y') ? 'y' : 'n')
                            ->setParameter(':cust_active', (filter_input(INPUT_POST, 'active') === 'y') ? 'y' : 'n')
                            ->setParameter(':cust_id', $iId)
                        ;

                        if (!empty(filter_input(INPUT_POST, 'pwd'))) {
                            $querybuilder
                                ->set('cust_password', ':cust_password')
                                ->setParameter(':cust_password', password_hash(filter_input(INPUT_POST, 'pwd'), PASSWORD_DEFAULT))
                            ;
                            $aInfo['passwordchanged'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                        }

                        $querybuilder->execute();
                        $aInfo['changeswritten'] = true;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    }
                }
            }
            $querybuilder = $this->dbal->createQueryBuilder();
            $querybuilder
                ->select(DB_ADDRESSFIELDS)
                ->from('customer')
                ->where('cust_id = ?')
                ->setParameter(0, $iId)
            ;
            $stmt = $querybuilder->execute();
            if ($stmt->rowCount() === 1) {
                $aUser = $stmt->fetch();
                $aPData['customerform'] = $this->helperCustomer->buildCustomerForm($this->config->getLang(), 'admin', $aErr, $aUser);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                $aInfo['nosuchuserfound'] = true;
            }
        }
        $aPData['customeradmin']['text'] = $return;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $aPData['customeradmin']['type'] = $sType;
        if (isset($aInfo)) {
            $aPData['customeradmin']['info'] = $aInfo;
        }
        return $aPData;
    }

}


Issues (102)

Security Analysis not enabled

src/Controller/Admin/Customer/Customeradmin.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			HCSF - A multilingual CMS and Shopsystem
5			Copyright (C) 2014 Marcus Haase - [email protected]
6
7			This program is free software: you can redistribute it and/or modify
8			it under the terms of the GNU General Public License as published by
9			the Free Software Foundation, either version 3 of the License, or
10			(at your option) any later version.
11
12			This program is distributed in the hope that it will be useful,
13			but WITHOUT ANY WARRANTY; without even the implied warranty of
14			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			GNU General Public License for more details.
16
17			You should have received a copy of the GNU General Public License
18			along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*/
20
21			namespace HaaseIT\HCSF\Controller\Admin\Customer;
22
23
24			use Zend\ServiceManager\ServiceManager;
25
26			/**
27			* Class Customeradmin
28			* @package HaaseIT\HCSF\Controller\Admin\Customer
29			*/
30			class Customeradmin extends Base
31			{
32			/**
33			* @var \Doctrine\DBAL\Connection
34			*/
35			private $dbal;
36
37			/**
38			* @var \HaaseIT\HCSF\HardcodedText
39			*/
40			private $hardcodedtextcats;
41
42			/**
43			* Customeradmin constructor.
44			* @param ServiceManager $serviceManager
45			*/
46			public function __construct(ServiceManager $serviceManager)
47			{
48			parent::__construct($serviceManager);
49			$this->dbal = $serviceManager->get('dbal');
50			$this->hardcodedtextcats = $serviceManager->get('hardcodedtextcats');
51			}
52
53			/**
54			*
55			*/
56			public function preparePage()
57			{
58			$this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager, [], 'admin/base.twig');
59			$this->P->cb_pagetype = 'content';
60			$this->P->cb_subnav = 'admin';
61
62			$CUA = [
63			['title' => $this->hardcodedtextcats->get('customeradmin_list_no'), 'key' => 'cust_no', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
64			['title' => $this->hardcodedtextcats->get('customeradmin_list_company'), 'key' => 'cust_corp', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
65			['title' => $this->hardcodedtextcats->get('customeradmin_list_name'), 'key' => 'cust_name', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
66			['title' => $this->hardcodedtextcats->get('customeradmin_list_town'), 'key' => 'cust_town', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
67			['title' => $this->hardcodedtextcats->get('customeradmin_list_active'), 'key' => 'cust_active', 'width' => '16%', 'linked' => false,'stylehead' => 'text-align: left;',],
68			[
69			'title' => $this->hardcodedtextcats->get('customeradmin_list_edit'),
70			'key' => 'cust_id',
71			'width' => '16%',
72			'linked' => true,
73			'ltarget' => '/_admin/customeradmin.html',
74			'lkeyname' => 'id',
75			'lgetvars' => ['action' => 'edit',],
76			],
77			];
78			$aPData = $this->handleCustomerAdmin($CUA, $this->serviceManager->get('twig'));
79			$this->P->cb_customcontenttemplate = 'customer/customeradmin';
80			$this->P->oPayload->cl_html = $aPData['customeradmin']['text'];
81			$this->P->cb_customdata = $aPData;
82			}
83
84			/**
85			* @param $CUA
86			* @param $twig
87			* @return mixed
88			*/
89			private function handleCustomerAdmin($CUA, $twig)
90			{
91			$sType = 'all';
92			$type = filter_input(INPUT_GET, 'type');
93			if ($type !== null) {
94			if ($type === 'active') {
95			$sType = 'active';
96			} elseif ($type === 'inactive') {
97			$sType = 'inactive';
98			}
99			}
100			$return = '';
101			if (filter_input(INPUT_GET, 'action') === null) {
102			$querybuilder = $this->dbal->createQueryBuilder();
103			$querybuilder
104			->select(DB_ADDRESSFIELDS)
105			->from('customer')
106			->orderBy('cust_no', 'ASC')
107			;
108
109			if ($sType === 'active') {
110			$querybuilder
111			->where('cust_active = ?')
112			->setParameter(0, 'y')
113			;
114			} elseif ($sType === 'inactive') {
115			$querybuilder
116			->where('cust_active = ?')
117			->setParameter(0, 'n')
118			;
119			}
120			$stmt = $querybuilder->execute();
121			if ($stmt->rowCount() !== 0) {
122			$aData = $stmt->fetchAll();
123			$return .= \HaaseIT\Toolbox\Tools::makeListtable($CUA, $aData, $twig);
124			} else {
125			$aInfo['nodatafound'] = true;
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-21 09:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$aInfo` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$aInfo = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
126			}
127			} elseif (filter_input(INPUT_GET, 'action') === 'edit') {
128			$iId = filter_input(INPUT_GET, 'id', FILTER_SANITIZE_NUMBER_INT);
129			$aErr = [];
130			if (filter_input(INPUT_POST, 'doEdit') === 'yes') {
131			$sCustno = trim(filter_input(INPUT_POST, 'custno', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW));
132			if (strlen($sCustno) < $this->config->getCustomer('minimum_length_custno')) {
133			$aErr['custnoinvalid'] = true;
134			} else {
135			$querybuilder = $this->dbal->createQueryBuilder();
136			$querybuilder
137			->select(DB_ADDRESSFIELDS)
138			->from('customer')
139			->where('cust_id != ?')
140			->andWhere('cust_no = ?')
141			->setParameter(0, $iId)
142			->setParameter(1, $sCustno)
143			;
144			$stmt = $querybuilder->execute();
145
146			if ($stmt->rowCount() === 1) {
147			$aErr['custnoalreadytaken'] = true;
148			}
149
150			$querybuilder = $this->dbal->createQueryBuilder();
151			$querybuilder
152			->select(DB_ADDRESSFIELDS)
153			->from('customer')
154			->where('cust_id != ?')
155			->andWhere('cust_email = ?')
156			->setParameter(0, $iId)
157			->setParameter(1, filter_input(INPUT_POST, 'email', FILTER_SANITIZE_EMAIL))
158			;
159			$stmt = $querybuilder->execute();
160			if ($stmt->rowCount() === 1) {
161			$aErr['emailalreadytaken'] = true;
162			}
163			$aErr = $this->helperCustomer->validateCustomerForm($this->config->getLang(), $aErr, true);
164			if (count($aErr) === 0) {
165			$querybuilder = $this->dbal->createQueryBuilder();
166			$querybuilder
167			->update('customer')
168			->set('cust_no', ':cust_no')
169			->set('cust_email', ':cust_email')
170			->set('cust_corp', ':cust_corp')
171			->set('cust_name', ':cust_name')
172			->set('cust_street', ':cust_street')
173			->set('cust_zip', ':cust_zip')
174			->set('cust_town', ':cust_town')
175			->set('cust_phone', ':cust_phone')
176			->set('cust_cellphone', ':cust_cellphone')
177			->set('cust_fax', ':cust_fax')
178			->set('cust_country', ':cust_country')
179			->set('cust_group', ':cust_group')
180			->set('cust_emailverified', ':cust_emailverified')
181			->set('cust_active', ':cust_active')
182			->where('cust_id = :cust_id')
183			->setParameter(':cust_no', $sCustno)
184			->setParameter(':cust_email', trim(filter_input(INPUT_POST, 'email', FILTER_SANITIZE_EMAIL)))
185			->setParameter(':cust_corp', trim(filter_input(INPUT_POST, 'corpname', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
186			->setParameter(':cust_name', trim(filter_input(INPUT_POST, 'name', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
187			->setParameter(':cust_street', trim(filter_input(INPUT_POST, 'street', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
188			->setParameter(':cust_zip', trim(filter_input(INPUT_POST, 'zip', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
189			->setParameter(':cust_town', trim(filter_input(INPUT_POST, 'town', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
190			->setParameter(':cust_phone', trim(filter_input(INPUT_POST, 'phone', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
191			->setParameter(':cust_cellphone', trim(filter_input(INPUT_POST, 'cellphone', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
192			->setParameter(':cust_fax', trim(filter_input(INPUT_POST, 'fax', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
193			->setParameter(':cust_country', trim(filter_input(INPUT_POST, 'country', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
194			->setParameter(':cust_group', trim(filter_input(INPUT_POST, 'custgroup', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW)))
195			->setParameter(':cust_emailverified', (filter_input(INPUT_POST, 'emailverified') === 'y') ? 'y' : 'n')
196			->setParameter(':cust_active', (filter_input(INPUT_POST, 'active') === 'y') ? 'y' : 'n')
197			->setParameter(':cust_id', $iId)
198			;
199
200			if (!empty(filter_input(INPUT_POST, 'pwd'))) {
201			$querybuilder
202			->set('cust_password', ':cust_password')
203			->setParameter(':cust_password', password_hash(filter_input(INPUT_POST, 'pwd'), PASSWORD_DEFAULT))
204			;
205			$aInfo['passwordchanged'] = true;
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-04-18 17:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$aInfo` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$aInfo = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
206			}
207
208			$querybuilder->execute();
209			$aInfo['changeswritten'] = true;
			0 ignored issues – show Bug introduced 2017-04-18 17:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$aInfo` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
210			}
211			}
212			}
213			$querybuilder = $this->dbal->createQueryBuilder();
214			$querybuilder
215			->select(DB_ADDRESSFIELDS)
216			->from('customer')
217			->where('cust_id = ?')
218			->setParameter(0, $iId)
219			;
220			$stmt = $querybuilder->execute();
221			if ($stmt->rowCount() === 1) {
222			$aUser = $stmt->fetch();
223			$aPData['customerform'] = $this->helperCustomer->buildCustomerForm($this->config->getLang(), 'admin', $aErr, $aUser);
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-29 16:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$aPData` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$aPData = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
224			} else {
225			$aInfo['nosuchuserfound'] = true;
226			}
227			}
228			$aPData['customeradmin']['text'] = $return;
			0 ignored issues – show Bug introduced 2017-03-21 09:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$aPData` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
229			$aPData['customeradmin']['type'] = $sType;
230			if (isset($aInfo)) {
231			$aPData['customeradmin']['info'] = $aInfo;
232			}
233			return $aPData;
234			}
235
236			}
237

HaaseIT / HCSF

Issues (102)

Security Analysis not enabled

src/Controller/Admin/Customer/Customeradmin.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like