Itemgroupadmin::admin_updateGroup() - Code Metrics - Inspection of "moved redirects to static method" - HaaseIT/HCSF - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 152809...934151 )

by Marcus

created 2017-04-17 13:44 UTC

Itemgroupadmin::admin_updateGroup() B

↳ Parent: Project

Complexity

Conditions	5
Paths	5

Size

Total Lines	54
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	54
rs	8.7449
c	0
b	0
f	0
cc	5
eloc	39
nc	5
nop	1

How to fix Long Method

<?php

/*
    HCSF - A multilingual CMS and Shopsystem
    Copyright (C) 2014  Marcus Haase - [email protected]

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

namespace HaaseIT\HCSF\Controller\Admin\Shop;

use HaaseIT\Toolbox\DBTools;
use HaaseIT\HCSF\HardcodedText;
use HaaseIT\HCSF\HelperConfig;
use HaaseIT\Toolbox\Tools;
use Zend\ServiceManager\ServiceManager;

/**
 * Class Itemgroupadmin
 * @package HaaseIT\HCSF\Controller\Admin\Shop
 */
class Itemgroupadmin extends Base
{
    /**
     * @var \PDO
     */
    private $db;

    /**
     * Itemgroupadmin constructor.
     * @param ServiceManager $serviceManager
     */
    public function __construct(ServiceManager $serviceManager)
    {
        parent::__construct($serviceManager);
        $this->db = $serviceManager->get('db');
    }

    /**
     *
     */
    public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
        $this->P->cb_pagetype = 'content';
        $this->P->cb_subnav = 'admin';

        $this->P->cb_customcontenttemplate = 'shop/itemgroupadmin';

        $return = '';
        if (isset($_REQUEST['action']) && $_REQUEST['action'] === 'insert_lang') {
            $sql = 'SELECT itmg_id FROM itemgroups_base WHERE itmg_id = :gid';
            $hResult = $this->db->prepare($sql);
            $hResult->bindValue(':gid', $_REQUEST['gid']);
            $hResult->execute();
            $iNumRowsBasis = $hResult->rowCount();

            $sql = 'SELECT itmgt_id FROM itemgroups_text WHERE itmgt_pid = :gid AND itmgt_lang = :lang';
            $hResult = $this->db->prepare($sql);
            $hResult->bindValue(':gid', $_REQUEST['gid']);
            $hResult->bindValue(':lang', HelperConfig::$lang);
            $hResult->execute();
            $iNumRowsLang = $hResult->rowCount();

            if ($iNumRowsBasis == 1 && $iNumRowsLang == 0) {
                $iGID = filter_var($_REQUEST['gid'], FILTER_SANITIZE_NUMBER_INT);
                $aData = [
                    'itmgt_pid' => $iGID,
                    'itmgt_lang' => HelperConfig::$lang,
                ];
                $sql = DBTools::buildPSInsertQuery($aData, 'itemgroups_text');
                $hResult = $this->db->prepare($sql);
                foreach ($aData as $sKey => $sValue) {
                    $hResult->bindValue(':'.$sKey, $sValue);
                }
                $hResult->execute();
                \HaaseIT\HCSF\Helper::redirectToPage('/_admin/itemgroupadmin.html?gid='.$iGID.'&action=editgroup');
            }
        }

        if (isset($_REQUEST['action']) && $_REQUEST['action'] === 'editgroup') {
            if (isset($_REQUEST['do']) && $_REQUEST['do'] === 'true') {
                $this->P->cb_customdata['updatestatus'] = $this->admin_updateGroup(\HaaseIT\HCSF\Helper::getPurifier('itemgroup'));
            }

            $iGID = filter_var($_REQUEST['gid'], FILTER_SANITIZE_NUMBER_INT);
            $aGroup = $this->admin_getItemgroups($iGID);
            if (isset($_REQUEST['added'])) {
                $this->P->cb_customdata['groupjustadded'] = true;
            }
            $this->P->cb_customdata['showform'] = 'edit';
            $this->P->cb_customdata['group'] = $this->admin_prepareGroup('edit', $aGroup[0]);
        } elseif (isset($_REQUEST['action']) && $_REQUEST['action'] === 'addgroup') {
            $aErr = [];
            if (isset($_REQUEST['do']) && $_REQUEST['do'] === 'true') {
                $sName = filter_var($_REQUEST['name'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
                $sGNo = filter_var($_REQUEST['no'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
                $sImg = filter_var($_REQUEST['img'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);

                if (strlen($sName) < 3) {
                    $aErr['nametooshort'] = true;
                }
                if (strlen($sGNo) < 3) {
                    $aErr['grouptooshort'] = true;
                }
                if (count($aErr) == 0) {
                    $sql = 'SELECT itmg_no FROM itemgroups_base WHERE itmg_no = :no';
                    $hResult = $this->db->prepare($sql);
                    $hResult->bindValue(':no', $sGNo);
                    $hResult->execute();
                    if ($hResult->rowCount() > 0) {
                        $aErr['duplicateno'] = true;
                    }
                }
                if (count($aErr) == 0) {
                    $aData = [
                        'itmg_name' => $sName,
                        'itmg_no' => $sGNo,
                        'itmg_img' => $sImg,
                    ];
                    $sql = DBTools::buildPSInsertQuery($aData, 'itemgroups_base');
                    $hResult = $this->db->prepare($sql);
                    foreach ($aData as $sKey => $sValue) {
                        $hResult->bindValue(':'.$sKey, $sValue);
                    }
                    $hResult->execute();
                    $iLastInsertID = $this->db->lastInsertId();
                    \HaaseIT\HCSF\Helper::redirectToPage('/_admin/itemgroupadmin.html?action=editgroup&added&gid='.$iLastInsertID));
                } else {
                    $this->P->cb_customdata['err'] = $aErr;
                    $this->P->cb_customdata['showform'] = 'add';
                    $this->P->cb_customdata['group'] = $this->admin_prepareGroup('add');
                }
            } else {
                $this->P->cb_customdata['showform'] = 'add';
                $this->P->cb_customdata['group'] = $this->admin_prepareGroup('add');
            }
        } else {
            if (!$return .= $this->admin_showItemgroups($this->admin_getItemgroups(''))) {
                $this->P->cb_customdata['err']['nogroupsavaliable'] = true;
            }
        }
        $this->P->oPayload->cl_html = $return;
    }

    /**
     * @param $purifier
     * @return string
     */
    private function admin_updateGroup( $purifier)
    {
        $sql = 'SELECT * FROM itemgroups_base WHERE itmg_id != :id AND itmg_no = :gno';
        $hResult = $this->db->prepare($sql);
        $iGID = filter_var($_REQUEST['gid'], FILTER_SANITIZE_NUMBER_INT);
        $sGNo = filter_var($_REQUEST['no'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
        $hResult->bindValue(':id', $iGID);
        $hResult->bindValue(':gno', $sGNo);
        $hResult->execute();
        $iNumRows = $hResult->rowCount();

        if ($iNumRows > 0) {
            return 'duplicateno';
        }

        $aData = [
            'itmg_name' => filter_var($_REQUEST['name'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
            'itmg_no' => $sGNo,
            'itmg_img' => filter_var($_REQUEST['img'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
            'itmg_id'=> $iGID,
        ];

        $sql = DBTools::buildPSUpdateQuery($aData, 'itemgroups_base', 'itmg_id');
        $hResult = $this->db->prepare($sql);
        foreach ($aData as $sKey => $sValue) {
            $hResult->bindValue(':' . $sKey, $sValue);
        }
        $hResult->execute();

        $sql = 'SELECT itmgt_id FROM itemgroups_text WHERE itmgt_pid = :gid AND itmgt_lang = :lang';
        $hResult = $this->db->prepare($sql);
        $hResult->bindValue(':gid', $iGID);
        $hResult->bindValue(':lang', HelperConfig::$lang, \PDO::PARAM_STR);
        $hResult->execute();

        $iNumRows = $hResult->rowCount();

        if ($iNumRows == 1) {
            $aRow = $hResult->fetch();
            $aData = [
                'itmgt_shorttext' => $purifier->purify($_REQUEST['shorttext']),
                'itmgt_details' => $purifier->purify($_REQUEST['details']),
                'itmgt_id' => $aRow['itmgt_id'],
            ];
            $sql = DBTools::buildPSUpdateQuery($aData, 'itemgroups_text', 'itmgt_id');
            $hResult = $this->db->prepare($sql);
            foreach ($aData as $sKey => $sValue) {
                $hResult->bindValue(':' . $sKey, $sValue);
            }
            $hResult->execute();
        }

        return 'success';
    }

    /**
     * @param string $sPurpose
     * @param array $aData
     * @return array
     */
    private function admin_prepareGroup($sPurpose = 'none', $aData = [])
    {
        $aGData = [
            'formaction' => Tools::makeLinkHRefWithAddedGetVars('/_admin/itemgroupadmin.html'),
            'id' => isset($aData['itmg_id']) ? $aData['itmg_id'] : '',
            'name' => isset($aData['itmg_name']) ? $aData['itmg_name'] : '',
            'no' => isset($aData['itmg_no']) ? $aData['itmg_no'] : '',
            'img' => isset($aData['itmg_img']) ? $aData['itmg_img'] : '',
        ];

        if ($sPurpose === 'edit') {
            if ($aData['itmgt_id'] != '') {
                $aGData['lang'] = [
                    'shorttext' => isset($aData['itmgt_shorttext']) ? $aData['itmgt_shorttext'] : '',
                    'details' => isset($aData['itmgt_details']) ? $aData['itmgt_details'] : '',
                ];
            }
        }

        return $aGData;
    }

    /**
     * @param string $iGID
     * @return mixed
     */
    private function admin_getItemgroups($iGID = '')
    {
        $sql = 'SELECT * FROM itemgroups_base '
            . 'LEFT OUTER JOIN itemgroups_text ON itemgroups_base.itmg_id = itemgroups_text.itmgt_pid'
            . ' AND itemgroups_text.itmgt_lang = :lang';
        if ($iGID != '') {
            $sql .= ' WHERE itmg_id = :gid';
        }
        $sql .= ' ORDER BY itmg_no';
        $hResult = $this->db->prepare($sql);
        $hResult->bindValue(':lang', HelperConfig::$lang);
        if ($iGID != '') {
            $hResult->bindValue(':gid', $iGID);
        }
        $hResult->execute();

        return $hResult->fetchAll();
    }

    /**
     * @param $aGroups
     * @return bool|mixed
     */
    private function admin_showItemgroups($aGroups)
    {
        $aList = [
            ['title' => HardcodedText::get('itemgroupadmin_list_no'), 'key' => 'gno', 'width' => 80, 'linked' => false, 'style-data' => 'padding: 5px 0;'],
            ['title' => HardcodedText::get('itemgroupadmin_list_name'), 'key' => 'gname', 'width' => 350, 'linked' => false, 'style-data' => 'padding: 5px 0;'],
            ['title' => HardcodedText::get('itemgroupadmin_list_edit'), 'key' => 'gid', 'width' => 30, 'linked' => true, 'ltarget' => '/_admin/itemgroupadmin.html', 'lkeyname' => 'gid', 'lgetvars' => ['action' => 'editgroup'], 'style-data' => 'padding: 5px 0;'],
        ];
        if (count($aGroups) > 0) {
            $aData = [];
            foreach ($aGroups as $aValue) {
                $aData[] = [
                    'gid' => $aValue['itmg_id'],
                    'gno' => $aValue['itmg_no'],
                    'gname' => $aValue['itmg_name'],
                ];
            }
            return Tools::makeListtable($aList, $aData, $this->serviceManager->get('twig'));
        } else {
            return false;
        }
    }
}

1			<?php
2
3			/*
4			HCSF - A multilingual CMS and Shopsystem
5			Copyright (C) 2014 Marcus Haase - [email protected]
6
7			This program is free software: you can redistribute it and/or modify
8			it under the terms of the GNU General Public License as published by
9			the Free Software Foundation, either version 3 of the License, or
10			(at your option) any later version.
11
12			This program is distributed in the hope that it will be useful,
13			but WITHOUT ANY WARRANTY; without even the implied warranty of
14			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			GNU General Public License for more details.
16
17			You should have received a copy of the GNU General Public License
18			along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*/
20
21			namespace HaaseIT\HCSF\Controller\Admin\Shop;
22
23			use HaaseIT\Toolbox\DBTools;
24			use HaaseIT\HCSF\HardcodedText;
25			use HaaseIT\HCSF\HelperConfig;
26			use HaaseIT\Toolbox\Tools;
27			use Zend\ServiceManager\ServiceManager;
28
29			/**
30			* Class Itemgroupadmin
31			* @package HaaseIT\HCSF\Controller\Admin\Shop
32			*/
33			class Itemgroupadmin extends Base
34			{
35			/**
36			* @var \PDO
37			*/
38			private $db;
39
40			/**
41			* Itemgroupadmin constructor.
42			* @param ServiceManager $serviceManager
43			*/
44			public function __construct(ServiceManager $serviceManager)
45			{
46			parent::__construct($serviceManager);
47			$this->db = $serviceManager->get('db');
48			}
49
50			/**
51			*
52			*/
53			public function preparePage()
54			{
55			$this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
56			$this->P->cb_pagetype = 'content';
57			$this->P->cb_subnav = 'admin';
58
59			$this->P->cb_customcontenttemplate = 'shop/itemgroupadmin';
60
61			$return = '';
62			if (isset($_REQUEST['action']) && $_REQUEST['action'] === 'insert_lang') {
63			$sql = 'SELECT itmg_id FROM itemgroups_base WHERE itmg_id = :gid';
64			$hResult = $this->db->prepare($sql);
65			$hResult->bindValue(':gid', $_REQUEST['gid']);
66			$hResult->execute();
67			$iNumRowsBasis = $hResult->rowCount();
68
69			$sql = 'SELECT itmgt_id FROM itemgroups_text WHERE itmgt_pid = :gid AND itmgt_lang = :lang';
70			$hResult = $this->db->prepare($sql);
71			$hResult->bindValue(':gid', $_REQUEST['gid']);
72			$hResult->bindValue(':lang', HelperConfig::$lang);
73			$hResult->execute();
74			$iNumRowsLang = $hResult->rowCount();
75
76			if ($iNumRowsBasis == 1 && $iNumRowsLang == 0) {
77			$iGID = filter_var($_REQUEST['gid'], FILTER_SANITIZE_NUMBER_INT);
78			$aData = [
79			'itmgt_pid' => $iGID,
80			'itmgt_lang' => HelperConfig::$lang,
81			];
82			$sql = DBTools::buildPSInsertQuery($aData, 'itemgroups_text');
83			$hResult = $this->db->prepare($sql);
84			foreach ($aData as $sKey => $sValue) {
85			$hResult->bindValue(':'.$sKey, $sValue);
86			}
87			$hResult->execute();
88			\HaaseIT\HCSF\Helper::redirectToPage('/_admin/itemgroupadmin.html?gid='.$iGID.'&action=editgroup');
89			}
90			}
91
92			if (isset($_REQUEST['action']) && $_REQUEST['action'] === 'editgroup') {
93			if (isset($_REQUEST['do']) && $_REQUEST['do'] === 'true') {
94			$this->P->cb_customdata['updatestatus'] = $this->admin_updateGroup(\HaaseIT\HCSF\Helper::getPurifier('itemgroup'));
95			}
96
97			$iGID = filter_var($_REQUEST['gid'], FILTER_SANITIZE_NUMBER_INT);
98			$aGroup = $this->admin_getItemgroups($iGID);
99			if (isset($_REQUEST['added'])) {
100			$this->P->cb_customdata['groupjustadded'] = true;
101			}
102			$this->P->cb_customdata['showform'] = 'edit';
103			$this->P->cb_customdata['group'] = $this->admin_prepareGroup('edit', $aGroup[0]);
104			} elseif (isset($_REQUEST['action']) && $_REQUEST['action'] === 'addgroup') {
105			$aErr = [];
106			if (isset($_REQUEST['do']) && $_REQUEST['do'] === 'true') {
107			$sName = filter_var($_REQUEST['name'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
108			$sGNo = filter_var($_REQUEST['no'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
109			$sImg = filter_var($_REQUEST['img'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
110
111			if (strlen($sName) < 3) {
112			$aErr['nametooshort'] = true;
113			}
114			if (strlen($sGNo) < 3) {
115			$aErr['grouptooshort'] = true;
116			}
117			if (count($aErr) == 0) {
118			$sql = 'SELECT itmg_no FROM itemgroups_base WHERE itmg_no = :no';
119			$hResult = $this->db->prepare($sql);
120			$hResult->bindValue(':no', $sGNo);
121			$hResult->execute();
122			if ($hResult->rowCount() > 0) {
123			$aErr['duplicateno'] = true;
124			}
125			}
126			if (count($aErr) == 0) {
127			$aData = [
128			'itmg_name' => $sName,
129			'itmg_no' => $sGNo,
130			'itmg_img' => $sImg,
131			];
132			$sql = DBTools::buildPSInsertQuery($aData, 'itemgroups_base');
133			$hResult = $this->db->prepare($sql);
134			foreach ($aData as $sKey => $sValue) {
135			$hResult->bindValue(':'.$sKey, $sValue);
136			}
137			$hResult->execute();
138			$iLastInsertID = $this->db->lastInsertId();
139			\HaaseIT\HCSF\Helper::redirectToPage('/_admin/itemgroupadmin.html?action=editgroup&added&gid='.$iLastInsertID));
140			} else {
141			$this->P->cb_customdata['err'] = $aErr;
142			$this->P->cb_customdata['showform'] = 'add';
143			$this->P->cb_customdata['group'] = $this->admin_prepareGroup('add');
144			}
145			} else {
146			$this->P->cb_customdata['showform'] = 'add';
147			$this->P->cb_customdata['group'] = $this->admin_prepareGroup('add');
148			}
149			} else {
150			if (!$return .= $this->admin_showItemgroups($this->admin_getItemgroups(''))) {
151			$this->P->cb_customdata['err']['nogroupsavaliable'] = true;
152			}
153			}
154			$this->P->oPayload->cl_html = $return;
155			}
156
157			/**
158			* @param $purifier
159			* @return string
160			*/
161			private function admin_updateGroup( $purifier)
162			{
163			$sql = 'SELECT * FROM itemgroups_base WHERE itmg_id != :id AND itmg_no = :gno';
164			$hResult = $this->db->prepare($sql);
165			$iGID = filter_var($_REQUEST['gid'], FILTER_SANITIZE_NUMBER_INT);
166			$sGNo = filter_var($_REQUEST['no'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
167			$hResult->bindValue(':id', $iGID);
168			$hResult->bindValue(':gno', $sGNo);
169			$hResult->execute();
170			$iNumRows = $hResult->rowCount();
171
172			if ($iNumRows > 0) {
173			return 'duplicateno';
174			}
175
176			$aData = [
177			'itmg_name' => filter_var($_REQUEST['name'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
178			'itmg_no' => $sGNo,
179			'itmg_img' => filter_var($_REQUEST['img'], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
180			'itmg_id'=> $iGID,
181			];
182
183			$sql = DBTools::buildPSUpdateQuery($aData, 'itemgroups_base', 'itmg_id');
184			$hResult = $this->db->prepare($sql);
185			foreach ($aData as $sKey => $sValue) {
186			$hResult->bindValue(':' . $sKey, $sValue);
187			}
188			$hResult->execute();
189
190			$sql = 'SELECT itmgt_id FROM itemgroups_text WHERE itmgt_pid = :gid AND itmgt_lang = :lang';
191			$hResult = $this->db->prepare($sql);
192			$hResult->bindValue(':gid', $iGID);
193			$hResult->bindValue(':lang', HelperConfig::$lang, \PDO::PARAM_STR);
194			$hResult->execute();
195
196			$iNumRows = $hResult->rowCount();
197
198			if ($iNumRows == 1) {
199			$aRow = $hResult->fetch();
200			$aData = [
201			'itmgt_shorttext' => $purifier->purify($_REQUEST['shorttext']),
202			'itmgt_details' => $purifier->purify($_REQUEST['details']),
203			'itmgt_id' => $aRow['itmgt_id'],
204			];
205			$sql = DBTools::buildPSUpdateQuery($aData, 'itemgroups_text', 'itmgt_id');
206			$hResult = $this->db->prepare($sql);
207			foreach ($aData as $sKey => $sValue) {
208			$hResult->bindValue(':' . $sKey, $sValue);
209			}
210			$hResult->execute();
211			}
212
213			return 'success';
214			}
215
216			/**
217			* @param string $sPurpose
218			* @param array $aData
219			* @return array
220			*/
221			private function admin_prepareGroup($sPurpose = 'none', $aData = [])
222			{
223			$aGData = [
224			'formaction' => Tools::makeLinkHRefWithAddedGetVars('/_admin/itemgroupadmin.html'),
225			'id' => isset($aData['itmg_id']) ? $aData['itmg_id'] : '',
226			'name' => isset($aData['itmg_name']) ? $aData['itmg_name'] : '',
227			'no' => isset($aData['itmg_no']) ? $aData['itmg_no'] : '',
228			'img' => isset($aData['itmg_img']) ? $aData['itmg_img'] : '',
229			];
230
231			if ($sPurpose === 'edit') {
232			if ($aData['itmgt_id'] != '') {
233			$aGData['lang'] = [
234			'shorttext' => isset($aData['itmgt_shorttext']) ? $aData['itmgt_shorttext'] : '',
235			'details' => isset($aData['itmgt_details']) ? $aData['itmgt_details'] : '',
236			];
237			}
238			}
239
240			return $aGData;
241			}
242
243			/**
244			* @param string $iGID
245			* @return mixed
246			*/
247			private function admin_getItemgroups($iGID = '')
248			{
249			$sql = 'SELECT * FROM itemgroups_base '
250			. 'LEFT OUTER JOIN itemgroups_text ON itemgroups_base.itmg_id = itemgroups_text.itmgt_pid'
251			. ' AND itemgroups_text.itmgt_lang = :lang';
252			if ($iGID != '') {
253			$sql .= ' WHERE itmg_id = :gid';
254			}
255			$sql .= ' ORDER BY itmg_no';
256			$hResult = $this->db->prepare($sql);
257			$hResult->bindValue(':lang', HelperConfig::$lang);
258			if ($iGID != '') {
259			$hResult->bindValue(':gid', $iGID);
260			}
261			$hResult->execute();
262
263			return $hResult->fetchAll();
264			}
265
266			/**
267			* @param $aGroups
268			* @return bool\|mixed
269			*/
270			private function admin_showItemgroups($aGroups)
271			{
272			$aList = [
273			['title' => HardcodedText::get('itemgroupadmin_list_no'), 'key' => 'gno', 'width' => 80, 'linked' => false, 'style-data' => 'padding: 5px 0;'],
274			['title' => HardcodedText::get('itemgroupadmin_list_name'), 'key' => 'gname', 'width' => 350, 'linked' => false, 'style-data' => 'padding: 5px 0;'],
275			['title' => HardcodedText::get('itemgroupadmin_list_edit'), 'key' => 'gid', 'width' => 30, 'linked' => true, 'ltarget' => '/_admin/itemgroupadmin.html', 'lkeyname' => 'gid', 'lgetvars' => ['action' => 'editgroup'], 'style-data' => 'padding: 5px 0;'],
276			];
277			if (count($aGroups) > 0) {
278			$aData = [];
279			foreach ($aGroups as $aValue) {
280			$aData[] = [
281			'gid' => $aValue['itmg_id'],
282			'gno' => $aValue['itmg_no'],
283			'gname' => $aValue['itmg_name'],
284			];
285			}
286			return Tools::makeListtable($aList, $aData, $this->serviceManager->get('twig'));
287			} else {
288			return false;
289			}
290			}
291			}

HaaseIT / HCSF

Push — master ( 152809...934151 )

Itemgroupadmin::admin_updateGroup() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like