Itemadmin::preparePage() - Code Metrics - Inspection of "migrated some queries to dbal" - HaaseIT/HCSF - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 456bf5...b3c1c7 )

by Marcus
created 2017-03-22 06:57 UTC
Itemadmin::preparePage() D

↳ Parent: Itemadmin
Complexity

Conditions	17
Paths	23
Size

Total Lines	83
Code Lines	61
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	83
rs	4.8887
c	0
b	0
f	0
cc	17
eloc	61
nc	23
nop	0
How to fix Long Method Complexity

<?php

/*
    HCSF - A multilingual CMS and Shopsystem
    Copyright (C) 2014  Marcus Haase - [email protected]

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

namespace HaaseIT\HCSF\Controller\Admin\Shop;

use HaaseIT\HCSF\HardcodedText;
use HaaseIT\Toolbox\DBTools;
use HaaseIT\HCSF\HelperConfig;
use HaaseIT\Toolbox\Tools;
use Zend\Diactoros\ServerRequest;
use Zend\ServiceManager\ServiceManager;

/**
 * Class Itemadmin
 * @package HaaseIT\HCSF\Controller\Admin\Shop
 */
class Itemadmin extends Base
{
    /**
     * @var \PDO
     */
    protected $db;

    /**
     * @var \Doctrine\DBAL\Connection
     */
    protected $dbal;

    /**
     * @var array
     */
    protected $get;

    /**
     * @var array
     */
    protected $post;

    /**
     * @var ServerRequest;
     */
    protected $request;

    /**
     * Itemadmin constructor.
     * @param ServiceManager $serviceManager
     */
    public function __construct(ServiceManager $serviceManager)
    {
        parent::__construct($serviceManager);
        $this->db = $serviceManager->get('db');
        $this->dbal = $serviceManager->get('dbal');
        $this->request = $serviceManager->get('request');
        $this->get = $this->request->getQueryParams();
        $this->post = $this->request->getParsedBody();
    }

    /**
     *
     */
    public function preparePage()
    {
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
        $this->P->cb_pagetype = 'content';
        $this->P->cb_subnav = 'admin';

        $this->P->cb_customcontenttemplate = 'shop/itemadmin';

        if (isset($this->get["action"]) && $this->get["action"] === 'insert_lang') {
            $aItemdata = $this->admin_getItem();

            if (isset($aItemdata["base"]) && !isset($aItemdata["text"])) {
                $aData = [
                    'itml_pid' => $aItemdata["base"]['itm_id'],
                    'itml_lang' => HelperConfig::$lang,
                ];

                $sql = DBTools::buildInsertQuery($aData, 'item_lang');
                $this->db->exec($sql);

                header('Location: /_admin/itemadmin.html?itemno='.$this->get["itemno"].'&action=showitem');
                die();

            }
        }
        $this->P->cb_customdata["searchform"] = $this->admin_prepareItemlistsearchform();

        if (isset($this->get["action"])) {
            if ($this->get["action"] === 'search') {
                $this->P->cb_customdata["searchresult"] = true;
                if ($aItemlist = $this->admin_getItemlist()) {
                    if (count($aItemlist["data"]) == 1) {
                        $aItemdata = $this->admin_getItem($aItemlist["data"][0]['itm_no']);
                        $this->P->cb_customdata["item"] = $this->admin_prepareItem($aItemdata);
                    } else {
                        $this->P->cb_customdata["itemlist"] = $this->admin_prepareItemlist($aItemlist);
                    }
                }
            } elseif (isset($this->post["doaction"]) && $this->post["doaction"] === 'edititem') {
                $this->admin_updateItem(\HaaseIT\HCSF\Helper::getPurifier('item'));
                $this->P->cb_customdata["itemupdated"] = true;

                $aItemdata = $this->admin_getItem();
                $this->P->cb_customdata["item"] = $this->admin_prepareItem($aItemdata);
            } elseif ($this->get["action"] === 'showitem') {
                $aItemdata = $this->admin_getItem();
                $this->P->cb_customdata["item"] = $this->admin_prepareItem($aItemdata);
            } elseif ($this->get["action"] === 'additem') {
                $aErr = [];
                if (isset($this->post["additem"]) && $this->post["additem"] === 'do') {
                    if (strlen($this->post["itemno"]) < 4) {
                        $aErr["itemnotooshort"] = true;
                    } else {
                        $sql = 'SELECT itm_no FROM item_base WHERE itm_no = \'';
                        $sql .= \trim(\filter_input(INPUT_POST, 'itemno', FILTER_SANITIZE_SPECIAL_CHARS))."'";
                        $hResult = $this->db->query($sql);
                        $iRows = $hResult->rowCount();
                        if ($iRows > 0) {
                            $aErr["itemnoalreadytaken"] = true;
                        } else {
                            $aData = ['itm_no' => trim(\filter_input(INPUT_POST, 'itemno', FILTER_SANITIZE_SPECIAL_CHARS)),];
                            $sql = DBTools::buildInsertQuery($aData, 'item_base');
                            $this->db->exec($sql);
                            $iInsertID = $this->db->lastInsertId();

                            $queryBuilder = $this->dbal->createQueryBuilder();
                            $queryBuilder
                                ->select('itm_no')
                                ->from('item_base')
                                ->where('itm_id = '.$queryBuilder->createNamedParameter($iInsertID))
                            ;
                            $statement = $queryBuilder->execute();
                            $row = $statement->fetch();

                            header('Location: /_admin/itemadmin.html?itemno='.$row['itm_no'].'&action=showitem');
                            die();

                        }
                    }
                }
                $this->P->cb_customdata["showaddform"] = true;
                $this->P->cb_customdata["err"] = $aErr;
            }
        }
    }

    /**
     * @return mixed
     */
    private function admin_prepareItemlistsearchform()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $aData["searchcats"] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            'nummer|'.HardcodedText::get('itemadmin_search_itemno'),
            'name|'.HardcodedText::get('itemadmin_search_itemname'),
            'index|'.HardcodedText::get('itemadmin_search_itemindex'),
        ];
        $aData["orderbys"] = [
            'nummer|'.HardcodedText::get('itemadmin_search_itemno'),
            'name|'.HardcodedText::get('itemadmin_search_itemname'),
        ];

        if (isset($this->get["searchcat"])) {

            $aData["searchcat"] = $this->get["searchcat"];
            $_SESSION["itemadmin_searchcat"] = $this->get["searchcat"];
        } elseif (isset($_SESSION["itemadmin_searchcat"])) {
            $aData["searchcat"] = $_SESSION["itemadmin_searchcat"];
        }

        if (isset($this->get["orderby"])) {

            $aData["orderby"] = $this->get["orderby"];
            $_SESSION["itemadmin_orderby"] = $this->get["orderby"];
        } elseif (isset($_SESSION["itemadmin_orderby"])) {
            $aData["orderby"] = $_SESSION["itemadmin_orderby"];
        }

        return $aData;
    }

    /**
     * @return bool
     */
    private function admin_getItemlist()
    {
        $sSearchstring = \filter_input(INPUT_GET, 'searchstring', FILTER_SANITIZE_SPECIAL_CHARS);
        $sSearchstring = str_replace('*', '%', $sSearchstring);

        $sql = 'SELECT itm_no, itm_name, itm_index FROM item_base'
            . ' LEFT OUTER JOIN item_lang ON item_base.itm_id = item_lang.itml_pid AND item_lang.itml_lang = :lang'
            . ' WHERE ';
        if ($this->get["searchcat"] === 'name') {
            $sql .= 'itm_name LIKE :searchstring ';
        } elseif ($this->get["searchcat"] === 'nummer') {
            $sql .= 'itm_no LIKE :searchstring ';
        } elseif ($this->get["searchcat"] === 'index') {
            $sql .= 'itm_index LIKE :searchstring ';
        } else {
            exit;

        }

        if ($this->get["orderby"] === 'name') {
            $sql .= 'ORDER BY itm_name';
        } elseif ($this->get["orderby"] === 'nummer') {
            $sql .= ' ORDER BY itm_no';
        }

        $hResult = $this->db->prepare($sql);
        $hResult->bindValue(':searchstring', $sSearchstring);
        $hResult->bindValue(':lang', HelperConfig::$lang);
        $hResult->execute();

        $aItemlist["numrows"] = $hResult->rowCount();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        if ($aItemlist["numrows"] != 0) {
            while ($aRow = $hResult->fetch()) {
                $aItemlist["data"][] = $aRow;
            }
            return $aItemlist;
        }

        return false;
    }

    /**
     * @param $aItemlist
     * @return array
     */
    private function admin_prepareItemlist($aItemlist)
    {
        $aList = [
            ['title' => HardcodedText::get('itemadmin_list_active'), 'key' => 'itemindex', 'width' => 30, 'linked' => false, 'callback' => 'renderItemStatusIcon',],
            ['title' => HardcodedText::get('itemadmin_list_itemno'), 'key' => 'itemno', 'width' => 100, 'linked' => false,],
            ['title' => HardcodedText::get('itemadmin_list_name'), 'key' => 'name', 'width' => 350, 'linked' => false,],
            ['title' => HardcodedText::get('itemadmin_list_edit'), 'key' => 'itemno', 'width' => 30, 'linked' => true, 'ltarget' => '/_admin/itemadmin.html', 'lkeyname' => 'itemno', 'lgetvars' => ['action' => 'showitem'],],
        ];
        $aData = [];
        foreach ($aItemlist["data"] as $aValue) {
            $aData[] = [
                'itemindex' => $aValue['itm_index'],
                'itemno' => $aValue['itm_no'],
                'name' => $aValue['itm_name'],
            ];
        }

        return [
            'numrows' => $aItemlist["numrows"],
            'listtable' => Tools::makeListtable($aList, $aData, $this->serviceManager->get('twig')),
        ];
    }

    /**
     * @param string $sItemno
     * @return bool
     */
    private function admin_getItem($sItemno = '')
    {
        if ($sItemno === '') {
            if (empty($this->get["itemno"])) {
                return false;
            }
            $sItemno = filter_var($this->get["itemno"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
        }

        $sql = 'SELECT * FROM item_base WHERE itm_no = :itemno';
        $hResult = $this->db->prepare($sql);
        $hResult->bindValue(':itemno', $sItemno);
        $hResult->execute();

        $aItemdata["base"] = $hResult->fetch();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        $sql = 'SELECT * FROM item_lang WHERE itml_pid = :parentpkey AND itml_lang = :lang';
        $hResult = $this->db->prepare($sql);
        $hResult->bindValue(':parentpkey', $aItemdata["base"]['itm_id']);
        $hResult->bindValue(':lang', HelperConfig::$lang);
        $hResult->execute();
        if ($hResult->rowCount() != 0) {
            $aItemdata["text"] = $hResult->fetch();
        }

        return $aItemdata;
    }

    /**
     * @param $aItemdata
     * @return array
     */
    private function admin_prepareItem($aItemdata)
    {
        $aData = [
            'form' => ['action' => Tools::makeLinkHRefWithAddedGetVars('/_admin/itemadmin.html', ['action' => 'showitem', 'itemno' => $aItemdata["base"]['itm_no']]),],
            'id' => $aItemdata["base"]['itm_id'],
            'itemno' => $aItemdata["base"]['itm_no'],
            'name' => $aItemdata["base"]['itm_name'],
            'img' => $aItemdata["base"]['itm_img'],
            'price' => $aItemdata["base"]['itm_price'],
            'vatid' => $aItemdata["base"]['itm_vatid'],
            'rg' => $aItemdata["base"]['itm_rg'],
            'index' => $aItemdata["base"]['itm_index'],
            'prio' => $aItemdata["base"]['itm_order'],
            'group' => $aItemdata["base"]['itm_group'],
            'data' => $aItemdata["base"]['itm_data'],
            'weight' => $aItemdata["base"]['itm_weight'],
        ];

        if (!HelperConfig::$shop["vat_disable"]) {
            $aOptions[] = '|';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            foreach (HelperConfig::$shop["vat"] as $sKey => $sValue) {
                $aOptions[] = $sKey.'|'.$sValue;
            }
            $aData["vatoptions"] = $aOptions;
            unset($aOptions);
        }
        $aData["rgoptions"][] = '';
        foreach (HelperConfig::$shop["rebate_groups"] as $sKey => $aValue) {
            $aData["rgoptions"][] = $sKey;
        }

        $aGroups = $this->admin_getItemgroups('');
        $aData["groupoptions"][] = '';
        foreach ($aGroups as $aValue) {
            $aData["groupoptions"][] = $aValue['itmg_id'] . '|' . $aValue['itmg_no'] . ' - ' . $aValue['itmg_name'];
        }
        unset($aGroups);

        if (isset($aItemdata["text"])) {
            $aData["lang"] = [
                'textid' => $aItemdata["text"]['itml_id'],
                'nameoverride' => $aItemdata["text"]['itml_name_override'],
                'text1' => $aItemdata["text"]['itml_text1'],
                'text2' => $aItemdata["text"]['itml_text2'],
            ];
        }

        return $aData;
    }

    /**
     * @param $purifier
     * @return bool
     */
    private function admin_updateItem($purifier)
    {
        $aData = [
            'itm_name' => filter_var($this->post["name"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
            'itm_group' => filter_var($this->post["group"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
            'itm_img' => filter_var($this->post["bild"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
            'itm_index' => filter_var($this->post["index"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
            'itm_order' => filter_var($this->post["prio"], FILTER_SANITIZE_NUMBER_INT),
            'itm_price' => filter_var($this->post["price"], FILTER_SANITIZE_NUMBER_FLOAT, FILTER_FLAG_ALLOW_FRACTION),
            'itm_rg' => filter_var($this->post["rg"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
            'itm_data' => filter_var($this->post["data"], FILTER_UNSAFE_RAW),
            'itm_weight' => filter_var($this->post["weight"], FILTER_SANITIZE_NUMBER_INT),
            'itm_id' => filter_var($this->post["id"], FILTER_SANITIZE_NUMBER_INT),
        ];
        if (!HelperConfig::$shop["vat_disable"]) {
            $aData['itm_vatid'] = filter_var($this->post["vatid"], FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
        } else {
            $aData['itm_vatid'] = 'full';
        }
        $sql = DBTools::buildPSUpdateQuery($aData, 'item_base', 'itm_id');
        $hResult = $this->db->prepare($sql);
        foreach ($aData as $sKey => $sValue) {
            $hResult->bindValue(':' . $sKey, $sValue);
        }
        $hResult->execute();
        if (isset($this->post["textid"])) {
            $aData = [
                'itml_text1' => $purifier->purify($this->post["text1"]),
                'itml_text2' => $purifier->purify($this->post["text2"]),
                'itml_name_override' => filter_var($this->post["name_override"], FILTER_UNSAFE_RAW, FILTER_FLAG_STRIP_LOW),
                'itml_id' => filter_var($this->post["textid"], FILTER_SANITIZE_NUMBER_INT),
            ];
            $sql = DBTools::buildPSUpdateQuery($aData, 'item_lang', 'itml_id');
            $hResult = $this->db->prepare($sql);
            foreach ($aData as $sKey => $sValue) {
                $hResult->bindValue(':' . $sKey, $sValue);
            }
            $hResult->execute();
        }

        return true;
    }

    /**
     * @param string $iGID
     * @return mixed
     */
    private function admin_getItemgroups($iGID = '') // this function should be outsourced, a duplicate is used in admin itemgroups!

    {
        $sql = 'SELECT * FROM itemgroups_base'
            . ' LEFT OUTER JOIN itemgroups_text ON itemgroups_base.itmg_id = itemgroups_text.itmgt_pid'
            . ' AND itemgroups_text.itmgt_lang = :lang';
        if ($iGID != '') {
            $sql .= ' WHERE itmg_id = :gid';
        }
        $sql .= ' ORDER BY itmg_no';
        $hResult = $this->db->prepare($sql);
        $hResult->bindValue(':lang', HelperConfig::$lang);
        if ($iGID != '') {
            $hResult->bindValue(':gid', $iGID);
        }
        $hResult->execute();

        return $hResult->fetchAll();
    }

}
1			<?php
2
3			/*
4			HCSF - A multilingual CMS and Shopsystem
5			Copyright (C) 2014 Marcus Haase - [email protected]
6
7			This program is free software: you can redistribute it and/or modify
8			it under the terms of the GNU General Public License as published by
9			the Free Software Foundation, either version 3 of the License, or
10			(at your option) any later version.
11
12			This program is distributed in the hope that it will be useful,
13			but WITHOUT ANY WARRANTY; without even the implied warranty of
14			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			GNU General Public License for more details.
16
17			You should have received a copy of the GNU General Public License
18			along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*/
20
21			namespace HaaseIT\HCSF\Controller\Admin\Shop;
22
23			use HaaseIT\HCSF\HardcodedText;
24			use HaaseIT\Toolbox\DBTools;
25			use HaaseIT\HCSF\HelperConfig;
26			use HaaseIT\Toolbox\Tools;
27			use Zend\Diactoros\ServerRequest;
28			use Zend\ServiceManager\ServiceManager;
29
30			/**
31			* Class Itemadmin
32			* @package HaaseIT\HCSF\Controller\Admin\Shop
33			*/
34			class Itemadmin extends Base
35			{
36			/**
37			* @var \PDO
38			*/
39			protected $db;
40
HaaseIT / HCSF

Push — master ( 456bf5...b3c1c7 )

Itemadmin::preparePage() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
