Completed
Push — master ( 12d38a...ff0701 )
by Marcus
01:56
created

Shoppingcart::getNotification()   C

Complexity

Conditions 12
Paths 6

Size

Total Lines 37
Code Lines 27

Duplication

Lines 0
Ratio 0 %

Importance

Changes 3
Bugs 0 Features 1
Metric Value
c 3
b 0
f 1
dl 0
loc 37
rs 5.1612
cc 12
eloc 27
nc 6
nop 0

How to fix   Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
/*
4
    HCSF - A multilingual CMS and Shopsystem
5
    Copyright (C) 2014  Marcus Haase - [email protected]
6
7
    This program is free software: you can redistribute it and/or modify
8
    it under the terms of the GNU General Public License as published by
9
    the Free Software Foundation, either version 3 of the License, or
10
    (at your option) any later version.
11
12
    This program is distributed in the hope that it will be useful,
13
    but WITHOUT ANY WARRANTY; without even the implied warranty of
14
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
15
    GNU General Public License for more details.
16
17
    You should have received a copy of the GNU General Public License
18
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
19
 */
20
21
namespace HaaseIT\HCSF\Controller\Shop;
22
23
use HaaseIT\HCSF\HelperConfig;
24
use HaaseIT\Toolbox\Tools;
25
use HaaseIT\HCSF\Helper;
26
use HaaseIT\HCSF\Customer\Helper as CHelper;
27
use HaaseIT\HCSF\Shop\Helper as SHelper;
28
use HaaseIT\Toolbox\DBTools;
29
30
class Shoppingcart extends Base
31
{
32
    /**
33
     * @var \HaaseIT\Toolbox\Textcat
34
     */
35
    private $textcats;
36
37
    /**
38
     * Shoppingcart constructor.
39
     * @param \Zend\ServiceManager\ServiceManager $serviceManager
40
     */
41
    public function __construct(\Zend\ServiceManager\ServiceManager $serviceManager)
42
    {
43
        parent::__construct($serviceManager);
44
        $this->textcats = $this->serviceManager->get('textcats');
45
    }
46
47
    /**
48
     *
49
     */
50
    public function preparePage()
0 ignored issues
show
Coding Style introduced by
preparePage uses the super-global variable $_SESSION which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
51
    {
52
        $this->P = new \HaaseIT\HCSF\CorePage($this->serviceManager);
53
        $this->P->cb_pagetype = 'contentnosubnav';
54
55
        if (HelperConfig::$shop['show_pricesonlytologgedin'] && !CHelper::getUserData()) {
56
            $this->P->oPayload->cl_html = $this->textcats->T('denied_notloggedin');
57
        } else {
58
            $this->P->cb_customcontenttemplate = 'shop/shoppingcart';
59
60
            // Check if there is a message to display above the shoppingcart
61
            $this->P->oPayload->cl_html = $this->getNotification();
62
63
            // Display the shoppingcart
64
            if (isset($_SESSION['cart']) && count($_SESSION['cart']) >= 1) {
65
                $aErr = [];
66
                if (filter_input(INPUT_POST, 'doCheckout') === 'yes') {
67
                    $aErr = $this->validateCheckout($aErr);
68
                    if (count($aErr) === 0) {
69
                        $this->doCheckout();
70
                    }
71
                }
72
73
                $aShoppingcart = SHelper::buildShoppingCartTable($_SESSION['cart'], false, '', $aErr);
0 ignored issues
show
Documentation introduced by
$aErr is of type array, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
74
75
                $this->P->cb_customdata = $aShoppingcart;
76
            } else {
77
                $this->P->oPayload->cl_html .= $this->textcats->T('shoppingcart_empty');
78
            }
79
        }
80
    }
81
82
    /**
83
     * @param array $aErr
84
     * @return array
85
     */
86
    private function validateCheckout($aErr = [])
87
    {
88
        $aErr = CHelper::validateCustomerForm(HelperConfig::$lang, $aErr, true);
89 View Code Duplication
        if (!CHelper::getUserData() && filter_input(INPUT_POST, 'tos') !== 'y') {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
90
            $aErr['tos'] = true;
91
        }
92 View Code Duplication
        if (!CHelper::getUserData() && filter_input(INPUT_POST, 'cancellationdisclaimer') !== 'y') {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
93
            $aErr['cancellationdisclaimer'] = true;
94
        }
95
        $postpaymentmethod = filter_input(INPUT_POST, 'paymentmethod');
96
        if (
97
            $postpaymentmethod === null
98
            || in_array($postpaymentmethod, HelperConfig::$shop['paymentmethods'], true) === false
99
        ) {
100
            $aErr['paymentmethod'] = true;
101
        }
102
103
        return $aErr;
104
    }
105
106
    /**
107
     * @param $aV
108
     * @return array
109
     */
110
    private function getItemImage($aV)
111
    {
112
        // base64 encode img and prepare for db
113
        // image/png image/jpeg image/gif
114
        // data:{mimetype};base64,XXXX
1 ignored issue
show
Unused Code Comprehensibility introduced by
45% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
115
116
        $aImagesToSend = [];
117
        $base64Img = false;
118
        $binImg = false;
119
120
        if (HelperConfig::$shop['email_orderconfirmation_embed_itemimages_method'] === 'glide') {
121
            $sPathToImage = '/'.HelperConfig::$core['directory_images'].'/'.HelperConfig::$shop['directory_images_items'].'/';
122
            $sImageroot = PATH_BASEDIR . HelperConfig::$core['directory_glide_master'];
123
124
            if (
125
                is_file($sImageroot.substr($sPathToImage.$aV['img'], strlen(HelperConfig::$core['directory_images']) + 1))
126
                && $aImgInfo = getimagesize($sImageroot.substr($sPathToImage.$aV['img'], strlen(HelperConfig::$core['directory_images']) + 1))
127
            ) {
128
                $glideserver = \League\Glide\ServerFactory::create([
129
                    'source' => $sImageroot,
130
                    'cache' => PATH_GLIDECACHE,
131
                    'max_image_size' => HelperConfig::$core['glide_max_imagesize'],
132
                ]);
133
                $glideserver->setBaseUrl('/' . HelperConfig::$core['directory_images'] . '/');
134
                $base64Img = $glideserver->getImageAsBase64($sPathToImage.$aV['img'], HelperConfig::$shop['email_orderconfirmation_embed_itemimages_glideparams']);
135
                $TMP = explode(',', $base64Img);
136
                $binImg = base64_decode($TMP[1]);
137
                unset($TMP);
138
            }
139
        } else {
140
            $sPathToImage =
141
                PATH_DOCROOT.HelperConfig::$core['directory_images'].'/'
142
                .HelperConfig::$shop['directory_images_items'].'/'
143
                .HelperConfig::$shop['directory_images_items_email'].'/';
144
            if ($aImgInfo = getimagesize($sPathToImage.$aV['img'])) {
145
                $binImg = file_get_contents($sPathToImage.$aV['img']);
146
                $base64Img = 'data:' . $aImgInfo['mime'] . ';base64,';
147
                $base64Img .= base64_encode($binImg);
148
            }
149
        }
150
        if (HelperConfig::$shop['email_orderconfirmation_embed_itemimages']) {
151
            $aImagesToSend['binimg'] = $binImg;
152
        }
153
        if ($base64Img) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $base64Img of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
154
            $aImagesToSend['base64img'] = $base64Img;
155
        }
156
        return $aImagesToSend;
157
    }
158
159
    /**
160
     * @return array
161
     */
162
    private function prepareDataOrder()
0 ignored issues
show
Coding Style introduced by
prepareDataOrder uses the super-global variable $_SESSION which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
Coding Style introduced by
prepareDataOrder uses the super-global variable $_POST which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
163
    {
164
        $cartpricesums = $_SESSION['cartpricesums'];
165
        return [
166
            'o_custno' => filter_var(trim(Tools::getFormfield('custno')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
167
            'o_email' => filter_var(trim(Tools::getFormfield('email')), FILTER_SANITIZE_EMAIL),
168
            'o_corpname' => filter_var(trim(Tools::getFormfield('corpname')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
169
            'o_name' => filter_var(trim(Tools::getFormfield('name')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
170
            'o_street' => filter_var(trim(Tools::getFormfield('street')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
171
            'o_zip' => filter_var(trim(Tools::getFormfield('zip')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
172
            'o_town' => filter_var(trim(Tools::getFormfield('town')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
173
            'o_phone' => filter_var(trim(Tools::getFormfield('phone')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
174
            'o_cellphone' => filter_var(trim(Tools::getFormfield('cellphone')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
175
            'o_fax' => filter_var(trim(Tools::getFormfield('fax')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
176
            'o_country' => filter_var(trim(Tools::getFormfield('country')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
177
            'o_group' => trim(CHelper::getUserData('cust_group')),
178
            'o_remarks' => filter_var(trim(Tools::getFormfield('remarks')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
179
            'o_tos' => (filter_input(INPUT_POST, 'tos') === 'y' || CHelper::getUserData()) ? 'y' : 'n',
180
            'o_cancellationdisclaimer' => (filter_input(INPUT_POST, 'cancellationdisclaimer') === 'y' || CHelper::getUserData()) ? 'y' : 'n',
181
            'o_paymentmethod' => filter_var(trim(Tools::getFormfield('paymentmethod')), FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
182
            'o_sumvoll' => $cartpricesums['sumvoll'],
183
            'o_sumerm' => $cartpricesums['sumerm'],
184
            'o_sumnettoall' => $cartpricesums['sumnettoall'],
185
            'o_taxvoll' => $cartpricesums['taxvoll'],
186
            'o_taxerm' => $cartpricesums['taxerm'],
187
            'o_sumbruttoall' => $cartpricesums['sumbruttoall'],
188
            'o_mindermenge' => isset($cartpricesums['mindergebuehr']) ? $cartpricesums['mindergebuehr'] : '',
189
            'o_shippingcost' => SHelper::getShippingcost(),
190
            'o_orderdate' => date('Y-m-d'),
191
            'o_ordertimestamp' => time(),
192
            'o_authed' => CHelper::getUserData() ? 'y' : 'n',
193
            'o_sessiondata' => serialize($_SESSION),
194
            'o_postdata' => serialize($_POST),
195
            'o_remote_address' => filter_input(INPUT_SERVER, 'REMOTE_ADDR', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
196
            'o_ordercompleted' => 'n',
197
            'o_paymentcompleted' => 'n',
198
            'o_srv_hostname' => filter_input(INPUT_SERVER, 'SERVER_NAME', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW),
199
            'o_vatfull' => HelperConfig::$shop['vat']['full'],
200
            'o_vatreduced' => HelperConfig::$shop['vat']['reduced'],
201
        ];
202
    }
203
204
    /**
205
     * @param int $orderid
206
     * @param string $cartkey
207
     * @param array $values
208
     * @param string $image
209
     * @return array
210
     */
211
    private function buildOrderItemRow($orderid, $cartkey, array $values, $image)
212
    {
213
        return [
214
            'oi_o_id' => $orderid,
215
            'oi_cartkey' => $cartkey,
216
            'oi_amount' => $values['amount'],
217
            'oi_price_netto_list' => $values['price']['netto_list'],
218
            'oi_price_netto_use' => $values['price']['netto_use'],
219
            'oi_price_brutto_use' => $values['price']['brutto_use'],
220
            'oi_price_netto_sale' => isset($values['price']['netto_sale']) ? $values['price']['netto_sale'] : '',
221
            'oi_price_netto_rebated' => isset($values['price']['netto_rebated']) ? $values['price']['netto_rebated'] : '',
222
            'oi_vat' => HelperConfig::$shop['vat'][$values['vat']],
223
            'oi_rg' => $values['rg'],
224
            'oi_rg_rebate' => isset(
225
                HelperConfig::$shop['rebate_groups'][$values['rg']][trim(CHelper::getUserData('cust_group'))]
226
            )
227
                ? HelperConfig::$shop['rebate_groups'][$values['rg']][trim(CHelper::getUserData('cust_group'))]
228
                : '',
229
            'oi_itemname' => $values['name'],
230
            'oi_img' => $image,
231
        ];
232
    }
233
234
    private function doCheckout()
0 ignored issues
show
Coding Style introduced by
doCheckout uses the super-global variable $_SESSION which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
235
    {
236
        /** @var \PDO $db */
237
        $db = $this->serviceManager->get('db');
238
239
        try {
240
            $db->beginTransaction();
241
242
            $aDataOrder = $this->prepareDataOrder();
243
            $sql = DBTools::buildPSInsertQuery($aDataOrder, 'orders');
244
            $hResult = $db->prepare($sql);
245
            foreach ($aDataOrder as $sKey => $sValue) {
246
                $hResult->bindValue(':' . $sKey, $sValue);
247
            }
248
            $hResult->execute();
249
            $iInsertID = $db->lastInsertId();
250
251
            $aImagesToSend = [];
252
            foreach ($_SESSION['cart'] as $sK => $aV) {
253
                $aImagesToSend[$aV['img']] = $this->getItemImage($aV);
254
                $aDataOrderItem = $this->buildOrderItemRow($iInsertID, $sK, $aV, $aImagesToSend[$aV['img']]['base64img']);
255
256
                $sql = DBTools::buildPSInsertQuery($aDataOrderItem, 'orders_items');
257
                $hResult = $db->prepare($sql);
258
                foreach ($aDataOrderItem as $sKey => $sValue) {
259
                    $hResult->bindValue(':' . $sKey, $sValue);
260
                }
261
                $hResult->execute();
262
            }
263
            $db->commit();
264
        } catch (\Exception $e) {
265
            // If something raised an exception in our transaction block of statements,
266
            // roll back any work performed in the transaction
267
            print '<p>Unable to complete transaction!</p>';
268
            error_log($e);
269
            $db->rollBack();
270
        }
271
        $sMailbody_us = $this->buildOrderMailBody(false, $iInsertID);
0 ignored issues
show
Bug introduced by
The variable $iInsertID does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
272
        $sMailbody_they = $this->buildOrderMailBody(true, $iInsertID);
273
274
        // write to file
275
        $this->writeCheckoutToFile($sMailbody_us);
276
277
        // Send Mails
278
        $this->sendCheckoutMails($iInsertID, $sMailbody_us, $sMailbody_they, $aImagesToSend);
0 ignored issues
show
Bug introduced by
The variable $aImagesToSend does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
279
280
        unset($_SESSION['cart'], $_SESSION['cartpricesums'], $_SESSION['sondercart']);
281
282
        $postpaymentmethod = filter_input(INPUT_POST, 'paymentmethod');
283
        if (
284
            $postpaymentmethod !== null
285
            && isset(HelperConfig::$shop['paypal_interactive'])
286
            && $postpaymentmethod === 'paypal'
287
            && in_array('paypal', HelperConfig::$shop['paymentmethods'], true) !== false
288
            && HelperConfig::$shop['paypal_interactive']
289
        ) {
290
            $redirectto = '/_misc/paypal.html?id=' . $iInsertID;
291
        } elseif (
292
            $postpaymentmethod !== null
293
            && $postpaymentmethod === 'sofortueberweisung'
294
            && in_array('sofortueberweisung', HelperConfig::$shop['paymentmethods'], true) !== false
295
        ) {
296
            $redirectto = '/_misc/sofortueberweisung.html?id=' . $iInsertID;
297
        } else {
298
            $redirectto = '/_misc/checkedout.html?id=' . $iInsertID;
299
        }
300
        \HaaseIT\HCSF\Helper::redirectToPage($redirectto);
301
    }
302
303
    /**
304
     * @param int $iInsertID
305
     * @param string $sMailbody_us
306
     * @param string $sMailbody_they
307
     * @param array $aImagesToSend
308
     */
309
    private function sendCheckoutMails($iInsertID, $sMailbody_us, $sMailbody_they, $aImagesToSend)
310
    {
311
        if (
312
            isset(HelperConfig::$shop['email_orderconfirmation_attachment_cancellationform_' .HelperConfig::$lang])
313
            && file_exists(
314
                PATH_DOCROOT.HelperConfig::$core['directory_emailattachments']
315
                .'/'.HelperConfig::$shop['email_orderconfirmation_attachment_cancellationform_'
316
                .HelperConfig::$lang]
317
            )
318
        ) {
319
            $aFilesToSend[] =
0 ignored issues
show
Coding Style Comprehensibility introduced by
$aFilesToSend was never initialized. Although not strictly required by PHP, it is generally a good practice to add $aFilesToSend = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
320
                PATH_DOCROOT.HelperConfig::$core['directory_emailattachments'].'/'
321
                .HelperConfig::$shop['email_orderconfirmation_attachment_cancellationform_' .HelperConfig::$lang];
322
        } else {
323
            $aFilesToSend = [];
324
        }
325
326
        Helper::mailWrapper(
327
            filter_input(INPUT_POST, 'email', FILTER_SANITIZE_EMAIL),
328
            $this->textcats->T('shoppingcart_mail_subject') . ' ' . $iInsertID,
329
            $sMailbody_they,
330
            $aImagesToSend,
331
            $aFilesToSend
332
        );
333
        Helper::mailWrapper(
334
            HelperConfig::$core['email_sender'],
335
            'Bestellung im Webshop Nr: ' . $iInsertID,
336
            $sMailbody_us,
337
            $aImagesToSend
338
        );
339
    }
340
341
    /**
342
     * @param string $sMailbody_us
343
     */
344
    private function writeCheckoutToFile($sMailbody_us)
345
    {
346
        $fp = fopen(PATH_LOGS . 'shoplog_' . date('Y-m-d') . '.html', 'a');
347
        // Write $somecontent to our opened file.
348
        fwrite($fp, $sMailbody_us . "\n\n-------------------------------------------------------------------------\n\n");
349
        fclose($fp);
350
    }
351
352
    /**
353
     * @param string $field
354
     * @return string
355
     */
356
    private function getPostValue($field)
357
    {
358
        $postvalue = filter_input(INPUT_POST, $field);
359
        return (!empty($postvalue) ? $postvalue : '');
360
    }
361
362
    /**
363
     * @param bool $bCust
364
     * @param int $iId
365
     * @return mixed
366
     */
367
    private function buildOrderMailBody($bCust = true, $iId)
0 ignored issues
show
Coding Style introduced by
buildOrderMailBody uses the super-global variable $_SESSION which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
Coding Style introduced by
buildOrderMailBody uses the super-global variable $_POST which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
368
    {
369
        $aM = [
370
            'customdata' => SHelper::buildShoppingCartTable($_SESSION['cart'], true),
371
            'currency' => HelperConfig::$shop['waehrungssymbol'],
372
        ];
373
        if (isset(HelperConfig::$shop['custom_order_fields'])) {
374
            $aM['custom_order_fields'] = HelperConfig::$shop['custom_order_fields'];
375
        }
376
377
        $postcustno = trim(filter_input(INPUT_POST, 'custno', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW));
378
        $postcountry = trim(filter_input(INPUT_POST, 'country', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW));
379
        $postpaymentmethod = filter_input(INPUT_POST, 'paymentmethod', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
380
        $serverservername = filter_input(INPUT_SERVER, 'SERVER_NAME', FILTER_SANITIZE_URL);
381
        $aData = [
382
            'customerversion' => $bCust,
383
            //'shc_css' => file_get_contents(PATH_DOCROOT.'screen-shc.css'),
0 ignored issues
show
Unused Code Comprehensibility introduced by
55% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
384
            'datetime' => date('d.m.Y - H:i'),
385
            'custno' => $postcustno !== null && strlen($postcustno) >= HelperConfig::$customer['minimum_length_custno'] ? $postcustno : '',
386
            'corpname' => $this->getPostValue('corpname'),
387
            'name' => $this->getPostValue('name'),
388
            'street' => $this->getPostValue('street'),
389
            'zip' => $this->getPostValue('zip'),
390
            'town' => $this->getPostValue('town'),
391
            'phone' => $this->getPostValue('phone'),
392
            'cellphone' => $this->getPostValue('cellphone'),
393
            'fax' => $this->getPostValue('fax'),
394
            'email' => $this->getPostValue('email'),
395
            'country' => !empty($postcountry) ?
396
            (
397
                isset(
398
                    HelperConfig::$countries['countries_' .HelperConfig::$lang][$postcountry]
399
                )
400
                    ? HelperConfig::$countries['countries_' .HelperConfig::$lang][$postcountry]
401
                    : $postcountry)
402
            : '',
403
            'remarks' => $this->getPostValue('remarks'),
404
            'tos' => $this->getPostValue('tos'),
405
            'cancellationdisclaimer' => $this->getPostValue('cancellationdisclaimer'),
406
            'paymentmethod' => $this->getPostValue('paymentmethod'),
407
            'shippingcost' => empty($_SESSION['shippingcost']) ? false : $_SESSION['shippingcost'],
408
            'paypallink' => $postpaymentmethod === 'paypal' ? $serverservername.'/_misc/paypal.html?id='.$iId : '',
409
            'sofortueberweisunglink' => $postpaymentmethod === 'sofortueberweisung' ?  $serverservername.'/_misc/sofortueberweisung.html?id='.$iId : '',
410
            'SESSION' => !$bCust ? Tools::debug($_SESSION, '$_SESSION', true, true) : '',
411
            'POST' => !$bCust ? Tools::debug($_POST, '$_POST', true, true) : '',
412
            'orderid' => $iId,
413
        ];
414
415
        $aM['customdata']['mail'] = $aData;
416
417
        return $this->serviceManager->get('twig')->render('shop/mail-order-html.twig', $aM);
418
    }
419
420
    /**
421
     * @return string
422
     */
423
    private function getNotification()
424
    {
425
        $return = '';
426
        $getmsg = filter_input(INPUT_GET, 'msg');
427
        $getcartkey = filter_input(INPUT_GET, 'cartkey', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
428
        $getamount = filter_input(INPUT_GET, 'cartkey', FILTER_SANITIZE_NUMBER_INT);
429
        if (!empty($getmsg)) {
430
            if (
431
                ($getmsg === 'updated' && !empty($getcartkey) && !empty($getamount))
432
                || ($getmsg === 'removed' && !empty($getcartkey))
433
            ) {
434
                $return .= $this->textcats->T('shoppingcart_msg_' . $getmsg . '_1') . ' ';
435
                if (isset(HelperConfig::$shop['custom_order_fields']) && mb_strpos($getcartkey, '|') !== false) {
436
                    $mCartkeys = explode('|', $getcartkey);
437
                    foreach ($mCartkeys as $sKey => $sValue) {
438
                        if ($sKey == 0) {
439
                            $return .= $sValue . ', ';
440
                        } else {
441
                            $TMP = explode(':', $sValue);
442
                            $return .= $this->textcats->T('shoppingcart_item_' . $TMP[0]) . ' ' . $TMP[1] . ', ';
443
                            unset($TMP);
444
                        }
445
                    }
446
                    $return = Tools::cutStringend($return, 2);
447
                } else {
448
                    $return .= $getcartkey;
449
                }
450
                $return.= ' ' . $this->textcats->T('shoppingcart_msg_'.$getmsg.'_2');
451
                if ($getmsg === 'updated') {
452
                    $return .= ' '.$getamount;
453
                }
454
                $return .= '<br><br>';
455
            }
456
        }
457
458
        return $return;
459
    }
460
}
461