Total Complexity | 60 |
Total Lines | 319 |
Duplicated Lines | 0 % |
Changes | 0 |
Complex classes like BinaryTree often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use BinaryTree, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
9 | class BinaryTree |
||
10 | { |
||
11 | public const IN_ORDER = 0; |
||
12 | public const PRE_ORDER = 1; |
||
13 | public const POST_ORDER = 2; |
||
14 | public const LEVEL_ORDER = 3; |
||
15 | |||
16 | public $root; |
||
17 | |||
18 | public function __construct(&$root=null) |
||
19 | { |
||
20 | $this->root = $root; |
||
21 | } |
||
22 | |||
23 | public function insert($node) //$node is a treenode |
||
24 | { |
||
25 | $this->validate_parameter($node); |
||
26 | |||
27 | if($this->root == null) |
||
28 | { |
||
29 | $this->root = $node; |
||
30 | return $this; |
||
31 | } |
||
32 | |||
33 | $n = $this->root; |
||
34 | while(1) |
||
35 | { |
||
36 | if($node->value < $n->value) |
||
37 | { |
||
38 | if($n->left == null) |
||
39 | { |
||
40 | $n->left = $node; |
||
41 | return $this; |
||
42 | } |
||
43 | |||
44 | $n = $n->left; |
||
45 | } |
||
46 | else if($node->value > $n->value) |
||
47 | { |
||
48 | if($n->right == null) |
||
49 | { |
||
50 | $n->right = $node; |
||
51 | return $this; |
||
52 | } |
||
53 | |||
54 | $n = $n->right; |
||
55 | } |
||
56 | else if($node->value == $n->value) //node is already in the tree, we do not create duplicates! |
||
57 | { |
||
58 | return $this; |
||
59 | } |
||
60 | } |
||
61 | } |
||
62 | |||
63 | public function search($value) |
||
64 | { |
||
65 | if(gettype($value) != "integer" && gettype($value) != "int" && gettype($value) != "double") |
||
66 | { |
||
67 | throw new InvalidArgument("Expected a number, got: " . gettype($value) . " !\n"); |
||
68 | } |
||
69 | |||
70 | return $this->recursive_search($value, $this->root); |
||
71 | } |
||
72 | |||
73 | private function recursive_search($value, $node) |
||
74 | { |
||
75 | if($node == null) |
||
76 | { |
||
77 | return null; |
||
78 | } |
||
79 | |||
80 | $eval = $value - $node->value; |
||
81 | if($eval == 0) |
||
82 | { |
||
83 | return $node; |
||
84 | } |
||
85 | |||
86 | if($eval < 0) |
||
87 | { |
||
88 | return $this->recursive_search($value, $node->left); |
||
89 | } |
||
90 | else if($eval > 0) |
||
91 | { |
||
92 | return $this->recursive_search($value, $node->right); |
||
93 | } |
||
94 | } |
||
95 | |||
96 | public function get_min($node) |
||
97 | { |
||
98 | while($node->left != null) //find left most leaf |
||
99 | { |
||
100 | $node = $node->left; |
||
101 | } |
||
102 | return $node; |
||
103 | } |
||
104 | |||
105 | public function compare($nodeA, $nodeB) |
||
106 | { |
||
107 | $this->validate_parameter($nodeA); |
||
108 | $this->validate_parameter($nodeB); |
||
109 | |||
110 | $eval = $nodeA->value - $nodeB->value; |
||
111 | |||
112 | if($eval < 0) |
||
113 | { |
||
114 | return -1; //go left |
||
115 | } |
||
116 | |||
117 | if($eval > 0) |
||
118 | { |
||
119 | return 1; //go right |
||
120 | } |
||
121 | |||
122 | return 0; //equal |
||
123 | } |
||
124 | |||
125 | public function delete($value) |
||
126 | { |
||
127 | //check if value is in the tree |
||
128 | $node = $this->search($value); //this function also handles type checking |
||
129 | if($node != null) |
||
130 | { |
||
131 | $this->delete_recursive($this->root, $node->value); |
||
132 | } |
||
133 | |||
134 | return $this; //allows chaining |
||
135 | } |
||
136 | |||
137 | private function delete_recursive(&$parent, $value) |
||
138 | { |
||
139 | if($parent == null) |
||
140 | { |
||
141 | return $parent; |
||
142 | } |
||
143 | |||
144 | if($value < $parent->value) |
||
145 | { |
||
146 | $parent->left = $this->delete_recursive($parent->left, $value); |
||
147 | } |
||
148 | else if($value > $parent->value) |
||
149 | { |
||
150 | $parent->right = $this->delete_recursive($parent->right, $value); |
||
151 | } |
||
152 | else |
||
153 | { |
||
154 | if($parent->left == null) |
||
155 | { |
||
156 | $temp = $parent->right; |
||
157 | $parent = null; |
||
158 | return $temp; |
||
159 | } |
||
160 | else if($parent->right == null) |
||
161 | { |
||
162 | $temp = $parent->left; |
||
163 | $parent = null; |
||
164 | return $temp; |
||
165 | } |
||
166 | |||
167 | $temp = $this->get_min($parent->right); |
||
168 | $parent->value = $temp->value; |
||
169 | $parent->right = $this->delete_recursive($parent->right, $temp->value); |
||
170 | } |
||
171 | |||
172 | return $parent; |
||
173 | } |
||
174 | |||
175 | public function is_complete() |
||
176 | { |
||
177 | //TODO |
||
178 | } |
||
179 | |||
180 | public function get_height() |
||
183 | } |
||
184 | |||
185 | private function get_height_recursive($node) |
||
186 | { |
||
187 | if($node == null) |
||
188 | { |
||
189 | return 0; |
||
190 | } |
||
191 | |||
192 | $lHeight = $this->get_height_recursive($node->left); |
||
193 | $rHeight = $this->get_height_recursive($node->right); |
||
194 | |||
195 | if($lHeight > $rHeight) |
||
196 | { |
||
197 | return ($lHeight + 1); |
||
198 | } |
||
199 | else |
||
200 | { |
||
201 | return ($rHeight + 1); |
||
202 | } |
||
203 | } |
||
204 | |||
205 | public function get_level($level) |
||
206 | { |
||
207 | if(gettype($level) != "integer" && gettype($level) != "int") |
||
208 | { |
||
209 | throw new InvalidArgument("Expected an int, got: " . gettype($level) . " !"); |
||
210 | } |
||
211 | |||
212 | $h = $this->get_height(); |
||
213 | if($level > $h) |
||
214 | { |
||
215 | throw new InvalidArgument("Cannot get the level: " . $level . " as it is greater than the tree level of: " . $h . " !"); |
||
216 | } |
||
217 | |||
218 | $results = array(); |
||
219 | $this->get_level_recursive($level, $this->root, $results); |
||
220 | return $results; |
||
221 | } |
||
222 | |||
223 | private function get_level_recursive($level, $node=null, &$results) //it is important that reference to results stays a reference (php pointer) ! |
||
224 | { |
||
225 | if($node == null) |
||
226 | { |
||
227 | return null; |
||
228 | } |
||
229 | |||
230 | if($level == 1) |
||
231 | { |
||
232 | array_push($results, $node); |
||
233 | } |
||
234 | else if($level > 1) |
||
235 | { |
||
236 | $this->get_level_recursive($level-1, $node->left, $results); |
||
237 | $this->get_level_recursive($level-1, $node->right, $results); |
||
238 | } |
||
239 | } |
||
240 | |||
241 | public function traverse($order) |
||
242 | { |
||
243 | switch($order) |
||
244 | { |
||
245 | case self::IN_ORDER: |
||
246 | $results = array(); |
||
247 | $this->in_order_traversal($this->root, $results); |
||
248 | return $results; |
||
249 | |||
250 | case self::PRE_ORDER: |
||
251 | $results = array(); |
||
252 | $this->pre_order_traversal($this->root, $results); |
||
253 | return $results; |
||
254 | |||
255 | case self::POST_ORDER: |
||
256 | $results = array(); |
||
257 | $this->post_order_traversal($this->root, $results); |
||
258 | return $results; |
||
259 | |||
260 | case self::LEVEL_ORDER: |
||
261 | $results =array(); |
||
262 | $this->level_order_traversal($results); |
||
263 | return $results; |
||
264 | |||
265 | default: |
||
266 | throw new InvalidArgument("Invalid order: " . $order . "! Valid orders: IN_ORDER (BinaryTree::IN_ORDER), PRE_ORDER (BinaryTree::PRE_ORDER), POST_ORDER (BinaryTree::POST_ORDER) and LEVEL_ORDER (BinaryTree::LEVEL_ORDER).\n"); |
||
267 | } |
||
268 | } |
||
269 | |||
270 | private function in_order_traversal($node, &$results) //it is important that reference to results stays a reference (php pointer) ! |
||
271 | { |
||
272 | if ($node == null) |
||
273 | { |
||
274 | return null; |
||
275 | } |
||
276 | |||
277 | $this->in_order_traversal($node->left, $results); |
||
278 | |||
279 | array_push($results, $node->value); |
||
280 | |||
281 | $this->in_order_traversal($node->right, $results); |
||
282 | } |
||
283 | |||
284 | private function pre_order_traversal($node, &$results) //it is important that reference to results stays a reference (php pointer) ! |
||
285 | { |
||
286 | if ($node == null) |
||
287 | { |
||
288 | return null; |
||
289 | } |
||
290 | |||
291 | array_push($results, $node->value); |
||
292 | |||
293 | $this->pre_order_traversal($node->left, $results); |
||
294 | $this->pre_order_traversal($node->right, $results); |
||
295 | } |
||
296 | |||
297 | private function post_order_traversal($node, &$results) //it is important that reference to results stays a reference (php pointer) ! |
||
298 | { |
||
299 | if ($node == null) |
||
300 | { |
||
301 | return null; |
||
302 | } |
||
303 | |||
304 | $this->post_order_traversal($node->left, $results); |
||
305 | $this->post_order_traversal($node->right, $results); |
||
306 | |||
307 | array_push($results, $node->value); |
||
308 | } |
||
309 | |||
310 | private function level_order_traversal(&$results) |
||
311 | { |
||
312 | for($i = 1; $i <= $this->get_height(); $i++) |
||
313 | { |
||
314 | $results[$i] = $this->get_level($i); |
||
315 | } |
||
316 | } |
||
317 | |||
318 | private function validate_parameter($node) |
||
328 | } |
||
329 | } |
||
330 | } |