com.hltech.vaunt.validator.schema.JsonSchemaValidator.validate(JsonSchema,JsonSchema) - Code Metrics - Inspection of "Consumer-driven validation of all properties of sc..." - HLTech/vaunt - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 00c609...aaedfc )

by Filip

created 2019-08-14 12:04 UTC

validate(JsonSchema,JsonSchema) C

↳ Parent: com.hltech.vaunt.validator.schema.JsonSchemaValidator

Complexity

Conditions

Size

Total Lines	60
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	45
c	0
b	0
f	0
dl	0
loc	60
rs	6.4666

How to fix Long Method

package com.hltech.vaunt.validator.schema;

import com.fasterxml.jackson.module.jsonSchema.JsonSchema;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Set;
import java.util.function.BiPredicate;
import java.util.stream.Collectors;
import java.util.stream.IntStream;

public abstract class JsonSchemaValidator {
    static final String ERROR_FORMAT = "Schema with id %s has not matching %s - consumer: %s, provider: %s";
    static final String ERROR_FORMAT_SHORT = "Schema with id %s has not matching %s";

    public abstract Class<?> supportsSchemaType();

    public List<String> validate(JsonSchema consumerSchema, JsonSchema providerSchema) {
        List<String> errors = new ArrayList<>();

        if (!isValid(consumerSchema.get$ref(), providerSchema.get$ref())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "$ref",
                    consumerSchema.get$ref(),
                    providerSchema.get$ref()));
        }

        if (!isValid(consumerSchema.get$schema(), providerSchema.get$schema())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "$schema",
                    consumerSchema.get$schema(),
                    providerSchema.get$schema()));
        }

        if (!isArrayValid(consumerSchema.getDisallow(), providerSchema.getDisallow(), Object::equals)) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "disallow",
                    jsonArrayToString(consumerSchema.getDisallow()),
                    jsonArrayToString(providerSchema.getDisallow())));
        }

        if (!isArrayValid(consumerSchema.getExtends(), providerSchema.getExtends(), Object::equals)) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "extends",
                    jsonArrayToString(consumerSchema.getExtends()),
                    jsonArrayToString(providerSchema.getExtends())));
        }

        if (isRequired(consumerSchema) && !isRequired(providerSchema)) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "required",
                    consumerSchema.getRequired(),
                    providerSchema.getRequired()));
        }

        if (!isValid(consumerSchema.getReadonly(), providerSchema.getReadonly())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "readonly",
                    consumerSchema.getReadonly(),
                    providerSchema.getReadonly()));
        }

        if (!isValid(consumerSchema.getDescription(), providerSchema.getDescription())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "description",
                    consumerSchema.getDescription(),
                    providerSchema.getDescription()));
        }

        return errors;
    }

    private boolean isRequired(JsonSchema schema) {
        return schema.getRequired() != null && schema.getRequired();
    }

    boolean isValid(Object consumerObject, Object providerObject) {
        return consumerObject == null || Objects.equals(consumerObject, providerObject);
    }

    <T> boolean isArrayValid(T[] consumerArray, T[] providerArray, BiPredicate<T, T> checker) {
        if (consumerArray == null) {
            return true;
        }

        if (providerArray == null) {
            return false;
        }

        return consumerArray.length == providerArray.length && IntStream.range(0, consumerArray.length)
                .allMatch(i -> checker.test(consumerArray[i], providerArray[i]));
    }

    private String jsonArrayToString(JsonSchema[] array) {
        String content = Arrays.stream(array)
                .map(this::jsonToString)
                .collect(Collectors.joining(", "));

        return "[" + content + "]";
    }

    String jsonToString(JsonSchema object) {
        return "JsonSchema(id=" + object.getId() + ")";
    }

    <T> boolean isEnumValid(Set<T> consumerEnums, Set<T> providerEnums) {
        if (representsString(consumerEnums) && representsEnum(providerEnums)) {
            return false;
        }

        if (representsEnum(consumerEnums) && representsEnum(providerEnums)) {
            return providerEnums.containsAll(consumerEnums);
        }

        return true;
    }

    <T, S> boolean isMapValid(Map<T, S> consumerMap, Map<T, S> providerMap) {
        if (consumerMap.size() == 0) {
            return true;
        }

        if (providerMap.size() == 0) {
            return false;
        }

        return consumerMap.equals(providerMap);
    }

    private <T> boolean representsEnum(Set<T> enums) {
        return enums.size() > 0;
    }

    private <T> boolean representsString(Set<T> enums) {
        return enums.size() == 0;
    }
}


1			package com.hltech.vaunt.validator.schema;
2
3			import com.fasterxml.jackson.module.jsonSchema.JsonSchema;
4
5			import java.util.ArrayList;
6			import java.util.Arrays;
7			import java.util.List;
8			import java.util.Map;
9			import java.util.Objects;
10			import java.util.Set;
11			import java.util.function.BiPredicate;
12			import java.util.stream.Collectors;
13			import java.util.stream.IntStream;
14
15			public abstract class JsonSchemaValidator {
16			static final String ERROR_FORMAT = "Schema with id %s has not matching %s - consumer: %s, provider: %s";
17			static final String ERROR_FORMAT_SHORT = "Schema with id %s has not matching %s";
18
19			public abstract Class<?> supportsSchemaType();
20
21			public List<String> validate(JsonSchema consumerSchema, JsonSchema providerSchema) {
22			List<String> errors = new ArrayList<>();
23
24			if (!isValid(consumerSchema.get$ref(), providerSchema.get$ref())) {
25			errors.add(String.format(ERROR_FORMAT,
26			consumerSchema.getId(),
27			"$ref",
28			consumerSchema.get$ref(),
29			providerSchema.get$ref()));
30			}
31
32			if (!isValid(consumerSchema.get$schema(), providerSchema.get$schema())) {
33			errors.add(String.format(ERROR_FORMAT,
34			consumerSchema.getId(),
35			"$schema",
36			consumerSchema.get$schema(),
37			providerSchema.get$schema()));
38			}
39
40			if (!isArrayValid(consumerSchema.getDisallow(), providerSchema.getDisallow(), Object::equals)) {
41			errors.add(String.format(ERROR_FORMAT,
42			consumerSchema.getId(),
43			"disallow",
44			jsonArrayToString(consumerSchema.getDisallow()),
45			jsonArrayToString(providerSchema.getDisallow())));
46			}
47
48			if (!isArrayValid(consumerSchema.getExtends(), providerSchema.getExtends(), Object::equals)) {
49			errors.add(String.format(ERROR_FORMAT,
50			consumerSchema.getId(),
51			"extends",
52			jsonArrayToString(consumerSchema.getExtends()),
53			jsonArrayToString(providerSchema.getExtends())));
54			}
55
56			if (isRequired(consumerSchema) && !isRequired(providerSchema)) {
57			errors.add(String.format(ERROR_FORMAT,
58			consumerSchema.getId(),
59			"required",
60			consumerSchema.getRequired(),
61			providerSchema.getRequired()));
62			}
63
64			if (!isValid(consumerSchema.getReadonly(), providerSchema.getReadonly())) {
65			errors.add(String.format(ERROR_FORMAT,
66			consumerSchema.getId(),
67			"readonly",
68			consumerSchema.getReadonly(),
69			providerSchema.getReadonly()));
70			}
71
72			if (!isValid(consumerSchema.getDescription(), providerSchema.getDescription())) {
73			errors.add(String.format(ERROR_FORMAT,
74			consumerSchema.getId(),
75			"description",
76			consumerSchema.getDescription(),
77			providerSchema.getDescription()));
78			}
79
80			return errors;
81			}
82
83			private boolean isRequired(JsonSchema schema) {
84			return schema.getRequired() != null && schema.getRequired();
85			}
86
87			boolean isValid(Object consumerObject, Object providerObject) {
88			return consumerObject == null \|\| Objects.equals(consumerObject, providerObject);
89			}
90
91			<T> boolean isArrayValid(T[] consumerArray, T[] providerArray, BiPredicate<T, T> checker) {
92			if (consumerArray == null) {
93			return true;
94			}
95
96			if (providerArray == null) {
97			return false;
98			}
99
100			return consumerArray.length == providerArray.length && IntStream.range(0, consumerArray.length)
101			.allMatch(i -> checker.test(consumerArray[i], providerArray[i]));
102			}
103
104			private String jsonArrayToString(JsonSchema[] array) {
105			String content = Arrays.stream(array)
106			.map(this::jsonToString)
107			.collect(Collectors.joining(", "));
108
109			return "[" + content + "]";
110			}
111
112			String jsonToString(JsonSchema object) {
113			return "JsonSchema(id=" + object.getId() + ")";
114			}
115
116			<T> boolean isEnumValid(Set<T> consumerEnums, Set<T> providerEnums) {
117			if (representsString(consumerEnums) && representsEnum(providerEnums)) {
118			return false;
119			}
120
121			if (representsEnum(consumerEnums) && representsEnum(providerEnums)) {
122			return providerEnums.containsAll(consumerEnums);
123			}
124
125			return true;
126			}
127
128			<T, S> boolean isMapValid(Map<T, S> consumerMap, Map<T, S> providerMap) {
129			if (consumerMap.size() == 0) {
130			return true;
131			}
132
133			if (providerMap.size() == 0) {
134			return false;
135			}
136
137			return consumerMap.equals(providerMap);
138			}
139
140			private <T> boolean representsEnum(Set<T> enums) {
141			return enums.size() > 0;
142			}
143
144			private <T> boolean representsString(Set<T> enums) {
145			return enums.size() == 0;
146			}
147			}
148

HLTech / vaunt

Push — master ( 00c609...aaedfc )

validate(JsonSchema,JsonSchema) C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like