com.hltech.vaunt.validator.JsonSchemaValidator.validate(JsonSchema,JsonSchema) - Code Metrics - Inspection of "StringSchema validated with detailed description o..." - HLTech/vaunt - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#69)

by Filip

created 2019-08-08 13:22 UTC

validate(JsonSchema,JsonSchema) C

↳ Parent: com.hltech.vaunt.validator.JsonSchemaValidator

Complexity

Conditions

Size

Total Lines	60
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	9
eloc	45
dl	0
loc	60
rs	6.4666
c	1
b	0
f	0

How to fix Long Method

package com.hltech.vaunt.validator;

import com.fasterxml.jackson.module.jsonSchema.JsonSchema;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

public class JsonSchemaValidator {
    static final String ERROR_FORMAT = "Schema with id %s has not matching %s - consumer: %s, provider: %s";

    public static List<String> validate(JsonSchema consumerSchema, JsonSchema providerSchema) {
        List<String> errors = new ArrayList<>();

        if (!equals(consumerSchema.get$ref(), providerSchema.get$ref())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "$ref",
                    consumerSchema.get$ref(),
                    providerSchema.get$ref()));
        }

        if (!equals(consumerSchema.get$schema(), providerSchema.get$schema())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "$schema",
                    consumerSchema.get$schema(),
                    providerSchema.get$schema()));
        }

        if (!arraysEquals(consumerSchema.getDisallow(), providerSchema.getDisallow())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "disallow",
                    jsonArraysToString(consumerSchema.getDisallow()),
                    jsonArraysToString(providerSchema.getDisallow())));
        }

        if (!arraysEquals(consumerSchema.getExtends(), providerSchema.getExtends())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "extends",
                    jsonArraysToString(consumerSchema.getExtends()),
                    jsonArraysToString(providerSchema.getExtends())));
        }

        if (isRequired(consumerSchema) && !isRequired(providerSchema)) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "required",
                    consumerSchema.getRequired(),
                    providerSchema.getRequired()));
        }

        if (!equals(consumerSchema.getReadonly(), providerSchema.getReadonly())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "readonly",
                    consumerSchema.getReadonly(),
                    providerSchema.getReadonly()));
        }

        if (!equals(consumerSchema.getDescription(), providerSchema.getDescription())) {
            errors.add(String.format(ERROR_FORMAT,
                    consumerSchema.getId(),
                    "description",
                    consumerSchema.getDescription(),
                    providerSchema.getDescription()));
        }

        return errors;
    }

    private static boolean isRequired(JsonSchema schema) {
        return schema.getRequired() != null && schema.getRequired();
    }

    public static boolean equals(Object object1, Object object2) {
        if (object1 == null) {
            return object2 == null;
        } else {
            return object1.equals(object2);
        }
    }

    private static <T> boolean arraysEquals(T[] array1, T[] array2) {
        if (array1 == null) {
            return array2 == null;
        }
        if (array2 == null) {
            return false;
        }

        return Arrays.equals(array1, array2);
    }

    private static String jsonArraysToString(JsonSchema[] array) {
        if (array == null) {
            return "null";
        }

        int inMax = array.length - 1;
        if (inMax == -1) {
            return "[]";
        }

        StringBuilder stringBuilder = new StringBuilder();
        stringBuilder.append('[');
        for (int i = 0; ; i++) {
            stringBuilder.append(jsonArrayToString(array[i]));
            if (i == inMax) {
                return stringBuilder.append(']').toString();
            }
            stringBuilder.append(", ");
        }
    }

    private static String jsonArrayToString(JsonSchema object) {
        return "id=" + object.getId();
    }
}


1			package com.hltech.vaunt.validator;
2
3			import com.fasterxml.jackson.module.jsonSchema.JsonSchema;
4
5			import java.util.ArrayList;
6			import java.util.Arrays;
7			import java.util.List;
8
9			public class JsonSchemaValidator {
10			static final String ERROR_FORMAT = "Schema with id %s has not matching %s - consumer: %s, provider: %s";
11
12			public static List<String> validate(JsonSchema consumerSchema, JsonSchema providerSchema) {
13			List<String> errors = new ArrayList<>();
14
15			if (!equals(consumerSchema.get$ref(), providerSchema.get$ref())) {
16			errors.add(String.format(ERROR_FORMAT,
17			consumerSchema.getId(),
18			"$ref",
19			consumerSchema.get$ref(),
20			providerSchema.get$ref()));
21			}
22
23			if (!equals(consumerSchema.get$schema(), providerSchema.get$schema())) {
24			errors.add(String.format(ERROR_FORMAT,
25			consumerSchema.getId(),
26			"$schema",
27			consumerSchema.get$schema(),
28			providerSchema.get$schema()));
29			}
30
31			if (!arraysEquals(consumerSchema.getDisallow(), providerSchema.getDisallow())) {
32			errors.add(String.format(ERROR_FORMAT,
33			consumerSchema.getId(),
34			"disallow",
35			jsonArraysToString(consumerSchema.getDisallow()),
36			jsonArraysToString(providerSchema.getDisallow())));
37			}
38
39			if (!arraysEquals(consumerSchema.getExtends(), providerSchema.getExtends())) {
40			errors.add(String.format(ERROR_FORMAT,
41			consumerSchema.getId(),
42			"extends",
43			jsonArraysToString(consumerSchema.getExtends()),
44			jsonArraysToString(providerSchema.getExtends())));
45			}
46
47			if (isRequired(consumerSchema) && !isRequired(providerSchema)) {
48			errors.add(String.format(ERROR_FORMAT,
49			consumerSchema.getId(),
50			"required",
51			consumerSchema.getRequired(),
52			providerSchema.getRequired()));
53			}
54
55			if (!equals(consumerSchema.getReadonly(), providerSchema.getReadonly())) {
56			errors.add(String.format(ERROR_FORMAT,
57			consumerSchema.getId(),
58			"readonly",
59			consumerSchema.getReadonly(),
60			providerSchema.getReadonly()));
61			}
62
63			if (!equals(consumerSchema.getDescription(), providerSchema.getDescription())) {
64			errors.add(String.format(ERROR_FORMAT,
65			consumerSchema.getId(),
66			"description",
67			consumerSchema.getDescription(),
68			providerSchema.getDescription()));
69			}
70
71			return errors;
72			}
73
74			private static boolean isRequired(JsonSchema schema) {
75			return schema.getRequired() != null && schema.getRequired();
76			}
77
78			public static boolean equals(Object object1, Object object2) {
79			if (object1 == null) {
80			return object2 == null;
81			} else {
82			return object1.equals(object2);
83			}
84			}
85
86			private static <T> boolean arraysEquals(T[] array1, T[] array2) {
87			if (array1 == null) {
88			return array2 == null;
89			}
90			if (array2 == null) {
91			return false;
92			}
93
94			return Arrays.equals(array1, array2);
95			}
96
97			private static String jsonArraysToString(JsonSchema[] array) {
98			if (array == null) {
99			return "null";
100			}
101
102			int inMax = array.length - 1;
103			if (inMax == -1) {
104			return "[]";
105			}
106
107			StringBuilder stringBuilder = new StringBuilder();
108			stringBuilder.append('[');
109			for (int i = 0; ; i++) {
110			stringBuilder.append(jsonArrayToString(array[i]));
111			if (i == inMax) {
112			return stringBuilder.append(']').toString();
113			}
114			stringBuilder.append(", ");
115			}
116			}
117
118			private static String jsonArrayToString(JsonSchema object) {
119			return "id=" + object.getId();
120			}
121			}
122

HLTech / vaunt

Pull Request — master (#69)

validate(JsonSchema,JsonSchema) C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like