Completed
Pull Request — master (#66)
by Filip
19:45 queued 11:20
created

com.hltech.pact.gen.domain.client.annotation.handlers.RequestMappingMethodsHandler   A

Complexity

Total Complexity 7

Size/Duplication

Total Lines 49
Duplicated Lines 100 %

Importance

Changes 0
Metric Value
eloc 38
dl 49
loc 49
rs 10
c 0
b 0
f 0
wmc 7

6 Methods

Rating   Name   Duplication   Size   Complexity  
A isSupported(Method) 3 3 1
A getResponseMediaHeaders(Method) 5 5 1
A handleRequest(Method) 13 13 1
A getRequestMediaHeaders(Method) 8 8 1
A getPathFromMethod(Method) 3 3 2
A combineHeaders(String[],List) 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
package com.hltech.pact.gen.domain.client.annotation.handlers;
2
3
import com.hltech.pact.gen.domain.client.annotation.MappingMethodHandler;
4
import com.hltech.pact.gen.domain.client.model.Param;
5
import com.hltech.pact.gen.domain.client.model.RequestRepresentation;
6
import com.hltech.pact.gen.domain.client.util.PathParametersExtractor;
7
import com.hltech.pact.gen.domain.client.util.RawHeadersParser;
8
import com.hltech.pact.gen.domain.client.util.RequestBodyExtractor;
9
import com.hltech.pact.gen.domain.client.util.RequestHeaderParamsExtractor;
10
import com.hltech.pact.gen.domain.client.util.RequestParametersExtractor;
11
import org.apache.commons.lang3.ArrayUtils;
12
import org.springframework.http.HttpHeaders;
13
import org.springframework.http.HttpMethod;
14
import org.springframework.web.bind.annotation.RequestMapping;
15
16
import java.lang.reflect.Method;
17
import java.util.Arrays;
18
import java.util.List;
19
import java.util.stream.Collectors;
20
import java.util.stream.Stream;
21
22 View Code Duplication
@MappingMethodHandler
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated in your project.
Loading history...
23
public class RequestMappingMethodsHandler implements AnnotatedMethodHandler {
24
25
    @Override
26
    public boolean isSupported(Method method) {
27
        return method.isAnnotationPresent(RequestMapping.class);
28
    }
29
30
    @Override
31
    public RequestRepresentation handleRequest(Method method) {
32
        return RequestRepresentation.builder()
33
            .httpMethod(HttpMethod.resolve(method.getAnnotation(RequestMapping.class)
34
                .method()[0].name().toUpperCase()))
35
            .path(getPathFromMethod(method))
36
            .headers(combineHeaders(
37
                ArrayUtils.addAll(method.getAnnotation(RequestMapping.class).headers(), getRequestMediaHeaders(method)),
38
                RequestHeaderParamsExtractor.extractAll(method)))
39
            .body(RequestBodyExtractor.extract(method.getParameters()))
40
            .requestParameters(RequestParametersExtractor.extractAll(method))
41
            .pathParameters(PathParametersExtractor.extractAll(method))
42
            .build();
43
    }
44
45
    @Override
46
    public String[] getResponseMediaHeaders(Method method) {
47
        return Arrays.stream(method.getAnnotation(RequestMapping.class).produces())
48
            .map(header -> HttpHeaders.CONTENT_TYPE + "=" + header)
49
            .toArray(String[]::new);
50
    }
51
52
    private String[] getRequestMediaHeaders(Method method) {
53
        return ArrayUtils.addAll(
54
            Arrays.stream(method.getAnnotation(RequestMapping.class).consumes())
55
                .map(header -> HttpHeaders.CONTENT_TYPE + "=" + header)
56
                .toArray(String[]::new),
57
            Arrays.stream(method.getAnnotation(RequestMapping.class).produces())
58
                .map(header -> HttpHeaders.ACCEPT + "=" + header)
59
                .toArray(String[]::new));
60
    }
61
62
    private String getPathFromMethod(Method method) {
63
        RequestMapping annotation = method.getAnnotation(RequestMapping.class);
64
        return annotation.path().length == 1 ? annotation.path()[0] : annotation.value()[0];
65
    }
66
67
    private static List<Param> combineHeaders(String[] rawHeaders, List<Param> headers) {
68
        return Stream
69
            .concat(RawHeadersParser.parseAll(rawHeaders).stream(), headers.stream())
70
            .collect(Collectors.toList());
71
    }
72
}
73