dev.hltech.dredd.interfaces.rest.validation.ValidationController - Code Metrics - Inspection of "Minor editorial fixes after review" - HLTech/judge-d - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 931bc2...fdbf8c )

by Tomasz

created 2018-10-22 19:38 UTC

dev.hltech.dredd.interfaces.rest.validation.ValidationController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	68
Duplicated Lines	70.59 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
eloc	54
c	2
b	1
f	0
dl	48
loc	68
rs	10
wmc	3

3 Methods

Rating	Name	Duplication	Size	Complexity
A	ValidationController(JudgeD,ServiceContractsRepository,List)	0	9	1
A	validateAgainstEnvironment(String,String,String)	24	24	1
A	validateAgainstEnvironments(String,String,List)	24	24	1

How to fix Duplicated Code

package dev.hltech.dredd.interfaces.rest.validation;

import dev.hltech.dredd.domain.JudgeD;
import dev.hltech.dredd.domain.contracts.ServiceContracts;
import dev.hltech.dredd.domain.contracts.ServiceContractsRepository;
import dev.hltech.dredd.domain.validation.EnvironmentValidatorResult;
import dev.hltech.dredd.domain.validation.InterfaceContractValidator;
import dev.hltech.dredd.interfaces.rest.ResourceNotFoundException;
import io.swagger.annotations.ApiOperation;
import io.swagger.annotations.ApiResponse;
import io.swagger.annotations.ApiResponses;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.MediaType;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;

import java.util.List;
import java.util.stream.Collectors;

import static dev.hltech.dredd.interfaces.rest.validation.Converters.toDtos;

@RestController
public class ValidationController {

    private final JudgeD judgeD;
    private final ServiceContractsRepository serviceContractsRepository;
    private final List<InterfaceContractValidator<?, ?>> validators;

    @Autowired
    public ValidationController(
        JudgeD judgeD,
        ServiceContractsRepository serviceContractsRepository,
        List<InterfaceContractValidator<?, ?>> validators
    ) {
        this.judgeD = judgeD;
        this.serviceContractsRepository = serviceContractsRepository;
        this.validators = validators;
    }

    @GetMapping(value = "/environment-compatibility-report/{environment}/{serviceName}:{serviceVersion:.+}", produces = MediaType.APPLICATION_JSON_VALUE)

    @ApiOperation(value = "Get validation report for contract between given service and given environment", nickname = "Validate against environment")
    @ApiResponses(value = {
        @ApiResponse(code = 200, message = "Success", response = String.class, responseContainer = "list"),
        @ApiResponse(code = 500, message = "Failure"),
        @ApiResponse(code = 404, message = "Service not found")
    })
    public List<ContractValidationReportDto> validateAgainstEnvironment(
        @PathVariable("environment") String environment,
        @PathVariable("serviceName") String serviceName,
        @PathVariable("serviceVersion") String serviceVersion
    ) {
        ServiceContracts validatedServiceContracts = this.serviceContractsRepository.find(serviceName, serviceVersion)
            .orElseThrow(ResourceNotFoundException::new);

        List<EnvironmentValidatorResult> collect = this.validators.stream()
            .map(validator ->
                this.judgeD.validateServiceAgainstEnv(
                    validatedServiceContracts,
                    environment,
                    validator
                ))
            .collect(Collectors.toList());
        return toDtos(collect, serviceName, serviceVersion);
    }

    @GetMapping(value = "/environment-compatibility-report/{serviceName}:{serviceVersion:.+}", produces = MediaType.APPLICATION_JSON_VALUE)

    @ApiOperation(value = "Get validation report for contract between given service and given environment", nickname = "Validate against environment")
    @ApiResponses(value = {
        @ApiResponse(code = 200, message = "Success", response = String.class, responseContainer = "list"),
        @ApiResponse(code = 500, message = "Failure"),
        @ApiResponse(code = 404, message = "Service not found")
    })
    public List<ContractValidationReportDto> validateAgainstEnvironments(
        @PathVariable("serviceName") String serviceName,
        @PathVariable("serviceVersion") String serviceVersion,
        @RequestParam("environment") List<String> environments
    ) {
        ServiceContracts validatedServiceContracts = this.serviceContractsRepository.find(serviceName, serviceVersion)
            .orElseThrow(ResourceNotFoundException::new);

        List<EnvironmentValidatorResult> collect = this.validators.stream()
            .map(validator ->
                this.judgeD.validateServiceAgainstEnv(
                    validatedServiceContracts,
                    environments,
                    validator
                ))
            .collect(Collectors.toList());
        return toDtos(collect, serviceName, serviceVersion);
    }
}


1		package dev.hltech.dredd.interfaces.rest.validation;
2
3		import dev.hltech.dredd.domain.JudgeD;
4		import dev.hltech.dredd.domain.contracts.ServiceContracts;
5		import dev.hltech.dredd.domain.contracts.ServiceContractsRepository;
6		import dev.hltech.dredd.domain.validation.EnvironmentValidatorResult;
7		import dev.hltech.dredd.domain.validation.InterfaceContractValidator;
8		import dev.hltech.dredd.interfaces.rest.ResourceNotFoundException;
9		import io.swagger.annotations.ApiOperation;
10		import io.swagger.annotations.ApiResponse;
11		import io.swagger.annotations.ApiResponses;
12		import org.springframework.beans.factory.annotation.Autowired;
13		import org.springframework.http.MediaType;
14		import org.springframework.web.bind.annotation.GetMapping;
15		import org.springframework.web.bind.annotation.PathVariable;
16		import org.springframework.web.bind.annotation.RequestParam;
17		import org.springframework.web.bind.annotation.RestController;
18
19		import java.util.List;
20		import java.util.stream.Collectors;
21
22		import static dev.hltech.dredd.interfaces.rest.validation.Converters.toDtos;
23
24		@RestController
25		public class ValidationController {
26
27		private final JudgeD judgeD;
28		private final ServiceContractsRepository serviceContractsRepository;
29		private final List<InterfaceContractValidator<?, ?>> validators;
30
31		@Autowired
32		public ValidationController(
33		JudgeD judgeD,
34		ServiceContractsRepository serviceContractsRepository,
35		List<InterfaceContractValidator<?, ?>> validators
36		) {
37		this.judgeD = judgeD;
38		this.serviceContractsRepository = serviceContractsRepository;
39		this.validators = validators;
40		}
41
42	View Code Duplication	@GetMapping(value = "/environment-compatibility-report/{environment}/{serviceName}:{serviceVersion:.+}", produces = MediaType.APPLICATION_JSON_VALUE)
		0 ignored issues – show Duplication introduced 2018-10-22 19:44 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
43		@ApiOperation(value = "Get validation report for contract between given service and given environment", nickname = "Validate against environment")
44		@ApiResponses(value = {
45		@ApiResponse(code = 200, message = "Success", response = String.class, responseContainer = "list"),
46		@ApiResponse(code = 500, message = "Failure"),
47		@ApiResponse(code = 404, message = "Service not found")
48		})
49		public List<ContractValidationReportDto> validateAgainstEnvironment(
50		@PathVariable("environment") String environment,
51		@PathVariable("serviceName") String serviceName,
52		@PathVariable("serviceVersion") String serviceVersion
53		) {
54		ServiceContracts validatedServiceContracts = this.serviceContractsRepository.find(serviceName, serviceVersion)
55		.orElseThrow(ResourceNotFoundException::new);
56
57		List<EnvironmentValidatorResult> collect = this.validators.stream()
58		.map(validator ->
59		this.judgeD.validateServiceAgainstEnv(
60		validatedServiceContracts,
61		environment,
62		validator
63		))
64		.collect(Collectors.toList());
65		return toDtos(collect, serviceName, serviceVersion);
66		}
67
68	View Code Duplication	@GetMapping(value = "/environment-compatibility-report/{serviceName}:{serviceVersion:.+}", produces = MediaType.APPLICATION_JSON_VALUE)
		0 ignored issues – show Duplication introduced 2018-10-22 19:44 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
69		@ApiOperation(value = "Get validation report for contract between given service and given environment", nickname = "Validate against environment")
70		@ApiResponses(value = {
71		@ApiResponse(code = 200, message = "Success", response = String.class, responseContainer = "list"),
72		@ApiResponse(code = 500, message = "Failure"),
73		@ApiResponse(code = 404, message = "Service not found")
74		})
75		public List<ContractValidationReportDto> validateAgainstEnvironments(
76		@PathVariable("serviceName") String serviceName,
77		@PathVariable("serviceVersion") String serviceVersion,
78		@RequestParam("environment") List<String> environments
79		) {
80		ServiceContracts validatedServiceContracts = this.serviceContractsRepository.find(serviceName, serviceVersion)
81		.orElseThrow(ResourceNotFoundException::new);
82
83		List<EnvironmentValidatorResult> collect = this.validators.stream()
84		.map(validator ->
85		this.judgeD.validateServiceAgainstEnv(
86		validatedServiceContracts,
87		environments,
88		validator
89		))
90		.collect(Collectors.toList());
91		return toDtos(collect, serviceName, serviceVersion);
92		}
93		}
94

HLTech / judge-d

Push — master ( 931bc2...fdbf8c )

dev.hltech.dredd.interfaces.rest.validation.ValidationController A

Complexity

Size/Duplication

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like