Issues in MetaDataProvider.php (develop) - Issues in develop - HDNET/onpage_integration - Measure and Improve Code Quality continuously with Scrutinizer

Issues (12)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Classes/Provider/MetaDataProvider.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace HDNET\OnpageIntegration\Provider;

use HDNET\OnpageIntegration\Service\ArrayService;
use HDNET\OnpageIntegration\Service\OnPageService;

class MetaDataProvider
{

    /**
     * @var \HDNET\OnpageIntegration\Provider\ConfigurationProvider
     */
    protected $configurationProvider;

    /**
     * @var \HDNET\OnpageIntegration\Service\ArrayService
     */
    protected $arrayService;

    /**
     * @var \HDNET\OnpageIntegration\Service\OnPageService
     */
    protected $onPageService;

    /**
     * MetaDataProvider constructor.
     *
     * @param ConfigurationProvider $configurationProvider
     * @param ArrayService          $arrayService
     */
    public function __construct(
        ConfigurationProvider $configurationProvider,
        ArrayService $arrayService,
        OnPageService $onPageService
    ) {
        $this->configurationProvider = $configurationProvider;
        $this->arrayService = $arrayService;
        $this->onPageService = $onPageService;
    }

    /**
     * @param string $key
     *
     * @return array
     */
    public function getMetaData($key)
    {
        $configData = $this->configurationProvider->getAllConfigurationData();
        $searchKeys = ['description', 'priority', 'errors', 'show'];

        // todo outsourced
        $trimmedConfigData = [];
        foreach ($configData['zoom'][$key] as $element) {
            if (!array_key_exists('disable', $element)) {
                $trimmedConfigData[] = $element;
            }
        }
        // todo deprecated
        // $elements = $this->arrayService->findElement($trimmedConfigData, $key);


        $buildData = $this->buildData($trimmedConfigData, $searchKeys);
        return $this->onPageService->build($buildData, $key);
    }

    /**
     * @param array $array
     * @param array $searchKeys
     *
     * @return array
     */
    protected function buildData(array $array, array $searchKeys)
    {
        $tmp = [];

        foreach ($array as $key => $element) {
            $tmp[$key] = $this->filter($element, $searchKeys);
        }

        return $tmp;
    }

    /**
     * @param array $array
     * @param array $searchKeys
     *
     * @return array
     */
    protected function filter(array $array, array $searchKeys)
    {
        $tmp = [];

        foreach ($array as $key => $element) {
            if (in_array($key, $searchKeys)) {
                $tmp[$key] = $element;
            }
        }

        return $tmp;
    }
}


1			<?php
2
3			namespace HDNET\OnpageIntegration\Provider;
4
5			use HDNET\OnpageIntegration\Service\ArrayService;
6			use HDNET\OnpageIntegration\Service\OnPageService;
7
8			class MetaDataProvider
9			{
10
11			/**
12			* @var \HDNET\OnpageIntegration\Provider\ConfigurationProvider
13			*/
14			protected $configurationProvider;
15
16			/**
17			* @var \HDNET\OnpageIntegration\Service\ArrayService
18			*/
19			protected $arrayService;
20
21			/**
22			* @var \HDNET\OnpageIntegration\Service\OnPageService
23			*/
24			protected $onPageService;
25
26			/**
27			* MetaDataProvider constructor.
28			*
29			* @param ConfigurationProvider $configurationProvider
30			* @param ArrayService $arrayService
31			*/
32			public function __construct(
33			ConfigurationProvider $configurationProvider,
34			ArrayService $arrayService,
35			OnPageService $onPageService
36			) {
37			$this->configurationProvider = $configurationProvider;
38			$this->arrayService = $arrayService;
39			$this->onPageService = $onPageService;
40			}
41
42			/**
43			* @param string $key
44			*
45			* @return array
46			*/
47			public function getMetaData($key)
48			{
49			$configData = $this->configurationProvider->getAllConfigurationData();
50			$searchKeys = ['description', 'priority', 'errors', 'show'];
51
52			// todo outsourced
53			$trimmedConfigData = [];
54			foreach ($configData['zoom'][$key] as $element) {
55			if (!array_key_exists('disable', $element)) {
56			$trimmedConfigData[] = $element;
57			}
58			}
59			// todo deprecated
60			// $elements = $this->arrayService->findElement($trimmedConfigData, $key);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-31 09:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
61
62			$buildData = $this->buildData($trimmedConfigData, $searchKeys);
63			return $this->onPageService->build($buildData, $key);
64			}
65
66			/**
67			* @param array $array
68			* @param array $searchKeys
69			*
70			* @return array
71			*/
72			protected function buildData(array $array, array $searchKeys)
73			{
74			$tmp = [];
75
76			foreach ($array as $key => $element) {
77			$tmp[$key] = $this->filter($element, $searchKeys);
78			}
79
80			return $tmp;
81			}
82
83			/**
84			* @param array $array
85			* @param array $searchKeys
86			*
87			* @return array
88			*/
89			protected function filter(array $array, array $searchKeys)
90			{
91			$tmp = [];
92
93			foreach ($array as $key => $element) {
94			if (in_array($key, $searchKeys)) {
95			$tmp[$key] = $element;
96			}
97			}
98
99			return $tmp;
100			}
101			}
102

HDNET / onpage_integration

Issues (12)

Security Analysis not enabled

Classes/Provider/MetaDataProvider.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like