ArrayUtility::buildIndexActionArray() - Code Metrics - Inspection of "Merge branch 'feature/OPE-16_persister' into devel..." - HDNET/onpage_integration - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 840c69...29c45a )

by René

created 2016-06-23 14:27 UTC

ArrayUtility::buildIndexActionArray() A

↳ Parent: ArrayUtility

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	7
rs	9.4285
cc	2
eloc	4
nc	2
nop	2

<?php
/**
 * Class ArrayUtility
 */
namespace HDNET\OnpageIntegration\Utility;

use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Class ArrayUtility
 */
class ArrayUtility
{

    /**
     * @param $metaDataArray
     * @param $section
     */
    static public function buildIndexActionArray(&$metaDataArray, $section)

    {
        $loader = GeneralUtility::makeInstance(\HDNET\OnpageIntegration\Loader\ApiResultLoader::class);
        for ($i = 0; $i < count($metaDataArray[0]); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $metaDataArray[0][$i]['errors'] = $loader->load('zoom_' . $section . '_' . $i . '_graph');
        }
    }
}


1			<?php
2			/**
3			* Class ArrayUtility
4			*/
5			namespace HDNET\OnpageIntegration\Utility;
6
7			use TYPO3\CMS\Core\Utility\GeneralUtility;
8
9			/**
10			* Class ArrayUtility
11			*/
12			class ArrayUtility
13			{
14
15			/**
16			* @param $metaDataArray
17			* @param $section
18			*/
19			static public function buildIndexActionArray(&$metaDataArray, $section)
			0 ignored issues – show Coding Style introduced 2016-06-23 14:30 UTC by Report Bug Copy Issue Report As per PSR2, the `static` declaration should come after the visibility declaration. Loading history...
20			{
21			$loader = GeneralUtility::makeInstance(\HDNET\OnpageIntegration\Loader\ApiResultLoader::class);
22			for ($i = 0; $i < count($metaDataArray[0]); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2016-06-23 14:30 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
23			$metaDataArray[0][$i]['errors'] = $loader->load('zoom_' . $section . '_' . $i . '_graph');
24			}
25			}
26			}
27

HDNET / onpage_integration

Push — develop ( 840c69...29c45a )

ArrayUtility::buildIndexActionArray() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like