Issues in EntityCollectionTester.php (master) - Issues in master - GuilleGF/PHP-Tools - Measure and Improve Code Quality continuously with Scrutinizer

Issues (20)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Collection/Helper/EntityCollectionTester.php (20 issues)

Labels

Bug 20

Severity

Minor 20

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace GuilleGF\PHPTools\Collection\Helper;

use GuilleGF\PHPTools\Collection\EntityCollection;

/**
 * Class EntityCollectionTester
 * @package GuilleGF\PHPTools\Collection\Helper
 */
trait EntityCollectionTester
{
    /**
     * @return string
     */
    abstract protected function entityCollectionClass(): string;

    /**
     * @test
     */
    public function emptyConstructor()
    {
        /** @var EntityCollection $entityCollectionClass */
        $entityCollectionClass = $this->entityCollectionClass();
        $exception = $entityCollectionClass::customEmptyException();

        $this->expectException(get_class($exception));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->expectExceptionMessage($exception->getMessage());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        new $entityCollectionClass([]);
    }

    /**
     * @test
     * @dataProvider invalidEntities
     * @param array $elements
     */
    public function invalidElementByConstructor(array $elements)
    {
        /** @var EntityCollection $entityCollectionClass */
        $entityCollectionClass = $this->entityCollectionClass();
        $exception = $entityCollectionClass::customInvalidEntityException();

        $this->expectException(get_class($exception));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->expectExceptionMessage($exception->getMessage());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        new $entityCollectionClass($elements);
    }

    /**
     * @return array
     */
    public function invalidEntities()
    {
        return [
            [[1]],
            [['element']],
            [[new \stdClass()]],
            [[new \stdClass(), new \stdClass()]],
            [[null]],
            [[false]]
        ];
    }

    /**
     * @test
     */
    public function invalidAddElement()
    {
        /** @var EntityCollection $entityCollectionClass */
        $entityCollectionClass = $this->entityCollectionClass();
        $exception = $entityCollectionClass::customInvalidEntityException();

        $this->expectException(get_class($exception));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->expectExceptionMessage($exception->getMessage());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        /** @var EntityCollection $collection */
        $collection = new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()], true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $collection->add([]);
    }

    /**
     * @test
     */
    public function invalidSetElement()
    {
        /** @var EntityCollection $entityCollectionClass */
        $entityCollectionClass = $this->entityCollectionClass();
        $exception = $entityCollectionClass::customInvalidEntityException();

        $this->expectException(get_class($exception));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->expectExceptionMessage($exception->getMessage());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        /** @var EntityCollection $collection */
        $collection = new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()], true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $collection->set('key', []);
    }

    /**
     * @test
     */
    public function validChildrenElementByConstructor()
    {
        /** @var EntityCollection $entityCollectionClass */
        $entityCollectionClass = $this->entityCollectionClass();
        $exception = $entityCollectionClass::customInvalidEntityException();

        $this->expectException(get_class($exception));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->expectExceptionMessage($exception->getMessage());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @test
     */
    public function validElementByConstructor()
    {
        /** @var EntityCollection $entityCollectionClass */
        $entityCollectionClass = $this->entityCollectionClass();

        /** @var EntityCollection $collection */
        $collection = new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()], true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->assertSame(1, $collection->count());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertInstanceOf($entityCollectionClass::entityClass(), $collection->current());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @test
     */
    public function addTwoValidElement()
    {
        /** @var EntityCollection $entityCollectionClass */
        $entityCollectionClass = $this->entityCollectionClass();

        /** @var EntityCollection $collection */
        $collection = new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()], true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}


        /** @var \Prophecy\Prophecy\ObjectProphecy $entity */
        $entity = $this->prophesize($entityCollectionClass::entityClass());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $collection->add($entity->reveal());
        $collection->set('key', $entity->reveal());

        $this->assertSame(3, $collection->count());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        foreach ($collection as $element) {
            $this->assertInstanceOf($entityCollectionClass::entityClass(), $element);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}


1			<?php
2
3			namespace GuilleGF\PHPTools\Collection\Helper;
4
5			use GuilleGF\PHPTools\Collection\EntityCollection;
6
7			/**
8			* Class EntityCollectionTester
9			* @package GuilleGF\PHPTools\Collection\Helper
10			*/
11			trait EntityCollectionTester
12			{
13			/**
14			* @return string
15			*/
16			abstract protected function entityCollectionClass(): string;
17
18			/**
19			* @test
20			*/
21			public function emptyConstructor()
22			{
23			/** @var EntityCollection $entityCollectionClass */
24			$entityCollectionClass = $this->entityCollectionClass();
25			$exception = $entityCollectionClass::customEmptyException();
26
27			$this->expectException(get_class($exception));
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectException()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			$this->expectExceptionMessage($exception->getMessage());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectExceptionMessage()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29
30			new $entityCollectionClass([]);
31			}
32
33			/**
34			* @test
35			* @dataProvider invalidEntities
36			* @param array $elements
37			*/
38			public function invalidElementByConstructor(array $elements)
39			{
40			/** @var EntityCollection $entityCollectionClass */
41			$entityCollectionClass = $this->entityCollectionClass();
42			$exception = $entityCollectionClass::customInvalidEntityException();
43
44			$this->expectException(get_class($exception));
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectException()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45			$this->expectExceptionMessage($exception->getMessage());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectExceptionMessage()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
46
47			new $entityCollectionClass($elements);
48			}
49
50			/**
51			* @return array
52			*/
53			public function invalidEntities()
54			{
55			return [
56			[[1]],
57			[['element']],
58			[[new \stdClass()]],
59			[[new \stdClass(), new \stdClass()]],
60			[[null]],
61			[[false]]
62			];
63			}
64
65			/**
66			* @test
67			*/
68			public function invalidAddElement()
69			{
70			/** @var EntityCollection $entityCollectionClass */
71			$entityCollectionClass = $this->entityCollectionClass();
72			$exception = $entityCollectionClass::customInvalidEntityException();
73
74			$this->expectException(get_class($exception));
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectException()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
75			$this->expectExceptionMessage($exception->getMessage());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectExceptionMessage()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
76
77			/** @var EntityCollection $collection */
78			$collection = new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()], true);
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
79			$collection->add([]);
80			}
81
82			/**
83			* @test
84			*/
85			public function invalidSetElement()
86			{
87			/** @var EntityCollection $entityCollectionClass */
88			$entityCollectionClass = $this->entityCollectionClass();
89			$exception = $entityCollectionClass::customInvalidEntityException();
90
91			$this->expectException(get_class($exception));
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectException()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
92			$this->expectExceptionMessage($exception->getMessage());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectExceptionMessage()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
93
94			/** @var EntityCollection $collection */
95			$collection = new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()], true);
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
96			$collection->set('key', []);
97			}
98
99			/**
100			* @test
101			*/
102			public function validChildrenElementByConstructor()
103			{
104			/** @var EntityCollection $entityCollectionClass */
105			$entityCollectionClass = $this->entityCollectionClass();
106			$exception = $entityCollectionClass::customInvalidEntityException();
107
108			$this->expectException(get_class($exception));
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectException()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
109			$this->expectExceptionMessage($exception->getMessage());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `expectExceptionMessage()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
110
111			new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()]);
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
112			}
113
114			/**
115			* @test
116			*/
117			public function validElementByConstructor()
118			{
119			/** @var EntityCollection $entityCollectionClass */
120			$entityCollectionClass = $this->entityCollectionClass();
121
122			/** @var EntityCollection $collection */
123			$collection = new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()], true);
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
124
125			$this->assertSame(1, $collection->count());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `assertSame()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
126			$this->assertInstanceOf($entityCollectionClass::entityClass(), $collection->current());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `assertInstanceOf()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
127			}
128
129			/**
130			* @test
131			*/
132			public function addTwoValidElement()
133			{
134			/** @var EntityCollection $entityCollectionClass */
135			$entityCollectionClass = $this->entityCollectionClass();
136
137			/** @var EntityCollection $collection */
138			$collection = new $entityCollectionClass([$this->prophesize($entityCollectionClass::entityClass())->reveal()], true);
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
139
140
141			/** @var \Prophecy\Prophecy\ObjectProphecy $entity */
142			$entity = $this->prophesize($entityCollectionClass::entityClass());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `prophesize()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
143			$collection->add($entity->reveal());
144			$collection->set('key', $entity->reveal());
145
146			$this->assertSame(3, $collection->count());
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `assertSame()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
147			foreach ($collection as $element) {
148			$this->assertInstanceOf($entityCollectionClass::entityClass(), $element);
			0 ignored issues – show Bug introduced 2017-03-28 12:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `assertInstanceOf()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
149			}
150			}
151			}
152

GuilleGF / PHP-Tools

Issues (20)

Security Analysis no request data

src/Collection/Helper/EntityCollectionTester.php (20 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like