Issues in Read.php (master) - Issues in master - Guilherme-fagundes/database - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

database/Read.php (13 issues)

Labels

Severity

<?php


namespace database;

use database\DB;

/**
 * Class Read
 * @package src
 */
class Read
{

    /**
     * @var
     */
    private $db;

    /**
     * @var
     */
    private $table;
    /**
     * @var
     */
    private $read;
    /**
     * @var
     */
    private $statement;
    /**
     * @var
     */
    private $terms;


    /**
     * @var
     */
    private $query;

    /**
     * @var
     */
    private $limit;


    /**
     * @var
     */
    private $offset;


    /**
     * @var
     */
    private $page;

    /**
     * @var
     */
    private $link;

    /**
     * @var
     */
    private $rows;
    /**
     * @var
     */
    private $maxLinks;

    /**
     * @var
     */
    private $first;

    /**
     * @var
     */
    private $last;


    private $paginator;


    /**
     * @var
     */
    private $result;


    /**
     * Read constructor.
     */
    public function __construct()
    {

    }

    /**
     * @return mixed
     */
    public function getResult()
    {
        return $this->result;
    }

    /**
     * @param $table
     * @param null $parse

     * @return array
     */

    public function query(string $query, string $parse = null)
    {
        if ($parse) {
            parse_str($parse, $this->statement);

        }

        $this->query = $query;
        $this->read = DB::connect()->prepare($this->query);
        $this->read->execute($this->statement);
        $this->rows = $this->read->rowCount();
        $this->result = $this->read->fetchAll(\PDO::FETCH_OBJ);
        return $this;



    }

    /**
     * @param $table
     * @return $this
     */
    public function all($table)
    {
        $this->table = (string)$table;


        $this->read = DB::connect()->prepare("SELECT * FROM {$this->table}");
        $this->read->execute();
        $this->rows = $this->read->rowCount();
        return $this->result = $this->read->fetchAll(\PDO::FETCH_OBJ);


        return $this;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

    }

    /**
     * @param string $table
     * @param string $terms
     * @param string $parse
     * @return mixed
     */
    public function find(string $table, string $terms, string $parse)
    {
        $this->table = $table;
        $this->terms = $terms;

        if ($parse) {
            parse_str($parse, $this->statement);
        }

        try {
            $this->read = DB::connect()->prepare("SELECT * FROM {$this->table} {$this->terms}");
            $this->read->execute($this->statement);
            $this->rows = $this->read->rowCount();
            return $this->result = $this->read->fetchAll(\PDO::FETCH_OBJ);
        } catch (\PDOException $e) {
            echo $e->getMessage() . " in " . $e->getFile();
        }

        return $this;
    }

    /**
     * @return int
     */
    public function getRowCount()
    {
        return $this->rows;

    }



}

1			<?php
2
3
4			namespace database;
5
6			use database\DB;
7
8			/**
9			* Class Read
10			* @package src
11			*/
12			class Read
13			{
14
15			/**
16			* @var
17			*/
18			private $db;
			0 ignored issues – show introduced 2020-06-21 05:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$db` is not used, and could be removed. Loading history...
19			/**
20			* @var
21			*/
22			private $table;
23			/**
24			* @var
25			*/
26			private $read;
27			/**
28			* @var
29			*/
30			private $statement;
31			/**
32			* @var
33			*/
34			private $terms;
35
36
37			/**
38			* @var
39			*/
40			private $query;
41
42			/**
43			* @var
44			*/
45			private $limit;
			0 ignored issues – show introduced 2020-09-03 21:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$limit` is not used, and could be removed. Loading history...
46
47			/**
48			* @var
49			*/
50			private $offset;
			0 ignored issues – show introduced 2020-09-03 21:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$offset` is not used, and could be removed. Loading history...
51
52			/**
53			* @var
54			*/
55			private $page;
			0 ignored issues – show introduced 2020-09-03 21:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$page` is not used, and could be removed. Loading history...
56			/**
57			* @var
58			*/
59			private $link;
			0 ignored issues – show introduced 2020-08-18 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$link` is not used, and could be removed. Loading history...
60			/**
61			* @var
62			*/
63			private $rows;
64			/**
65			* @var
66			*/
67			private $maxLinks;
			0 ignored issues – show introduced 2020-09-03 21:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$maxLinks` is not used, and could be removed. Loading history...
68			/**
69			* @var
70			*/
71			private $first;
			0 ignored issues – show introduced 2020-08-18 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$first` is not used, and could be removed. Loading history...
72			/**
73			* @var
74			*/
75			private $last;
			0 ignored issues – show introduced 2020-08-18 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$last` is not used, and could be removed. Loading history...
76
77			private $paginator;
			0 ignored issues – show introduced 2020-08-18 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The private property `$paginator` is not used, and could be removed. Loading history...
78
79			/**
80			* @var
81			*/
82			private $result;
83
84
85			/**
86			* Read constructor.
87			*/
88			public function __construct()
89			{
90
91			}
92
93			/**
94			* @return mixed
95			*/
96			public function getResult()
97			{
98			return $this->result;
99			}
100
101			/**
102			* @param $table
103			* @param null $parse
			0 ignored issues – show Documentation Bug introduced 2020-06-21 05:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the doc-type for parameter `$parse` is correct as it would always require `null` to be passed? Loading history...
104			* @return array
105			*/
106
107			public function query(string $query, string $parse = null)
108			{
109			if ($parse) {
110			parse_str($parse, $this->statement);
111
112			}
113
114			$this->query = $query;
115			$this->read = DB::connect()->prepare($this->query);
116			$this->read->execute($this->statement);
117			$this->rows = $this->read->rowCount();
118			$this->result = $this->read->fetchAll(\PDO::FETCH_OBJ);
119			return $this;
			0 ignored issues – show Bug Best Practice introduced 2020-08-18 04:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $this` returns the type `database\Read` which is incompatible with the documented return type `array`. Loading history...
120
121
122			}
123
124			/**
125			* @param $table
126			* @return $this
127			*/
128			public function all($table)
129			{
130			$this->table = (string)$table;
131
132
133			$this->read = DB::connect()->prepare("SELECT * FROM {$this->table}");
134			$this->read->execute();
135			$this->rows = $this->read->rowCount();
136			return $this->result = $this->read->fetchAll(\PDO::FETCH_OBJ);
			0 ignored issues – show Bug Best Practice introduced 2020-08-18 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $this->result = $...etchAll(PDO::FETCH_OBJ)` returns the type `array` which is incompatible with the documented return type `database\Read`. Loading history...
137
138			return $this;
			0 ignored issues – show Unused Code introduced 2020-08-18 04:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this `return $this` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
139
140			}
141
142			/**
143			* @param string $table
144			* @param string $terms
145			* @param string $parse
146			* @return mixed
147			*/
148			public function find(string $table, string $terms, string $parse)
149			{
150			$this->table = $table;
151			$this->terms = $terms;
152
153			if ($parse) {
154			parse_str($parse, $this->statement);
155			}
156
157			try {
158			$this->read = DB::connect()->prepare("SELECT * FROM {$this->table} {$this->terms}");
159			$this->read->execute($this->statement);
160			$this->rows = $this->read->rowCount();
161			return $this->result = $this->read->fetchAll(\PDO::FETCH_OBJ);
162			} catch (\PDOException $e) {
163			echo $e->getMessage() . " in " . $e->getFile();
164			}
165
166			return $this;
167			}
168
169			/**
170			* @return int
171			*/
172			public function getRowCount()
173			{
174			return $this->rows;
175
176			}
177
178
179
180			}

Guilherme-fagundes / database

Issues (15)

database/Read.php (13 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like