Gueststream-Inc /
iqware
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class dtTravelAgency |
|
|
|
|||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var string $AccountNo |
||
| 10 | */ |
||
| 11 | protected $AccountNo = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var string $IATANo |
||
| 15 | */ |
||
| 16 | protected $IATANo = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string $AccountName |
||
| 20 | */ |
||
| 21 | protected $AccountName = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var string $Address1 |
||
| 25 | */ |
||
| 26 | protected $Address1 = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var string $City |
||
| 30 | */ |
||
| 31 | protected $City = null; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var string $PhoneNo |
||
| 35 | */ |
||
| 36 | protected $PhoneNo = null; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @param string $AccountNo |
||
| 40 | * @param string $IATANo |
||
| 41 | * @param string $AccountName |
||
| 42 | * @param string $Address1 |
||
| 43 | * @param string $City |
||
| 44 | * @param string $PhoneNo |
||
| 45 | */ |
||
| 46 | public function __construct($AccountNo, $IATANo, $AccountName, $Address1, $City, $PhoneNo) |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @return string |
||
| 58 | */ |
||
| 59 | public function getAccountNo() |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @param string $AccountNo |
||
| 66 | * @return \Gueststream\PMS\IQWare\API\dtTravelAgency |
||
| 67 | */ |
||
| 68 | public function setAccountNo($AccountNo) |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @return string |
||
| 76 | */ |
||
| 77 | public function getIATANo() |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @param string $IATANo |
||
| 84 | * @return \Gueststream\PMS\IQWare\API\dtTravelAgency |
||
| 85 | */ |
||
| 86 | public function setIATANo($IATANo) |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @return string |
||
| 94 | */ |
||
| 95 | public function getAccountName() |
||
| 99 | |||
| 100 | /** |
||
| 101 | * @param string $AccountName |
||
| 102 | * @return \Gueststream\PMS\IQWare\API\dtTravelAgency |
||
| 103 | */ |
||
| 104 | public function setAccountName($AccountName) |
||
| 109 | |||
| 110 | /** |
||
| 111 | * @return string |
||
| 112 | */ |
||
| 113 | public function getAddress1() |
||
| 117 | |||
| 118 | /** |
||
| 119 | * @param string $Address1 |
||
| 120 | * @return \Gueststream\PMS\IQWare\API\dtTravelAgency |
||
| 121 | */ |
||
| 122 | public function setAddress1($Address1) |
||
| 127 | |||
| 128 | /** |
||
| 129 | * @return string |
||
| 130 | */ |
||
| 131 | public function getCity() |
||
| 135 | |||
| 136 | /** |
||
| 137 | * @param string $City |
||
| 138 | * @return \Gueststream\PMS\IQWare\API\dtTravelAgency |
||
| 139 | */ |
||
| 140 | public function setCity($City) |
||
| 145 | |||
| 146 | /** |
||
| 147 | * @return string |
||
| 148 | */ |
||
| 149 | public function getPhoneNo() |
||
| 153 | |||
| 154 | /** |
||
| 155 | * @param string $PhoneNo |
||
| 156 | * @return \Gueststream\PMS\IQWare\API\dtTravelAgency |
||
| 157 | */ |
||
| 158 | public function setPhoneNo($PhoneNo) |
||
| 163 | } |
||
| 164 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.