Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | class cGiftCertificateIncentivePeriod |
|
|
|||
6 | { |
||
7 | |||
8 | /** |
||
9 | * @var int $ID_IncentivePeriod |
||
10 | */ |
||
11 | protected $ID_IncentivePeriod = null; |
||
12 | |||
13 | /** |
||
14 | * @var \DateTime $FromDate |
||
15 | */ |
||
16 | protected $FromDate = null; |
||
17 | |||
18 | /** |
||
19 | * @var \DateTime $ToDate |
||
20 | */ |
||
21 | protected $ToDate = null; |
||
22 | |||
23 | /** |
||
24 | * @var TIncentiveType $Type |
||
25 | */ |
||
26 | protected $Type = null; |
||
27 | |||
28 | /** |
||
29 | * @var float $Amount |
||
30 | */ |
||
31 | protected $Amount = null; |
||
32 | |||
33 | /** |
||
34 | * @param int $ID_IncentivePeriod |
||
35 | * @param \DateTime $FromDate |
||
36 | * @param \DateTime $ToDate |
||
37 | * @param TIncentiveType $Type |
||
38 | * @param float $Amount |
||
39 | */ |
||
40 | public function __construct($ID_IncentivePeriod, \DateTime $FromDate, \DateTime $ToDate, $Type, $Amount) |
||
48 | |||
49 | /** |
||
50 | * @return int |
||
51 | */ |
||
52 | public function getID_IncentivePeriod() |
||
56 | |||
57 | /** |
||
58 | * @param int $ID_IncentivePeriod |
||
59 | * @return \Gueststream\PMS\IQWare\API\cGiftCertificateIncentivePeriod |
||
60 | */ |
||
61 | public function setID_IncentivePeriod($ID_IncentivePeriod) |
||
66 | |||
67 | /** |
||
68 | * @return \DateTime |
||
69 | */ |
||
70 | public function getFromDate() |
||
82 | |||
83 | /** |
||
84 | * @param \DateTime $FromDate |
||
85 | * @return \Gueststream\PMS\IQWare\API\cGiftCertificateIncentivePeriod |
||
86 | */ |
||
87 | public function setFromDate(\DateTime $FromDate) |
||
92 | |||
93 | /** |
||
94 | * @return \DateTime |
||
95 | */ |
||
96 | public function getToDate() |
||
108 | |||
109 | /** |
||
110 | * @param \DateTime $ToDate |
||
111 | * @return \Gueststream\PMS\IQWare\API\cGiftCertificateIncentivePeriod |
||
112 | */ |
||
113 | public function setToDate(\DateTime $ToDate) |
||
118 | |||
119 | /** |
||
120 | * @return TIncentiveType |
||
121 | */ |
||
122 | public function getType() |
||
126 | |||
127 | /** |
||
128 | * @param TIncentiveType $Type |
||
129 | * @return \Gueststream\PMS\IQWare\API\cGiftCertificateIncentivePeriod |
||
130 | */ |
||
131 | public function setType($Type) |
||
136 | |||
137 | /** |
||
138 | * @return float |
||
139 | */ |
||
140 | public function getAmount() |
||
144 | |||
145 | /** |
||
146 | * @param float $Amount |
||
147 | * @return \Gueststream\PMS\IQWare\API\cGiftCertificateIncentivePeriod |
||
148 | */ |
||
149 | public function setAmount($Amount) |
||
154 | } |
||
155 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.