Gueststream-Inc /
iqware
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class WebRes_GetGroupPrivatePricing |
|
|
|
|||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var int $intGUID |
||
| 10 | */ |
||
| 11 | protected $intGUID = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var string $LanguageCode |
||
| 15 | */ |
||
| 16 | protected $LanguageCode = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var int $AccountNo |
||
| 20 | */ |
||
| 21 | protected $AccountNo = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var string $strListOfRoomTypes |
||
| 25 | */ |
||
| 26 | protected $strListOfRoomTypes = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @param int $intGUID |
||
| 30 | * @param string $LanguageCode |
||
| 31 | * @param int $AccountNo |
||
| 32 | * @param string $strListOfRoomTypes |
||
| 33 | */ |
||
| 34 | public function __construct($intGUID, $LanguageCode, $AccountNo, $strListOfRoomTypes) |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @return int |
||
| 44 | */ |
||
| 45 | public function getIntGUID() |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @param int $intGUID |
||
| 52 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupPrivatePricing |
||
| 53 | */ |
||
| 54 | public function setIntGUID($intGUID) |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @return string |
||
| 62 | */ |
||
| 63 | public function getLanguageCode() |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @param string $LanguageCode |
||
| 70 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupPrivatePricing |
||
| 71 | */ |
||
| 72 | public function setLanguageCode($LanguageCode) |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @return int |
||
| 80 | */ |
||
| 81 | public function getAccountNo() |
||
| 85 | |||
| 86 | /** |
||
| 87 | * @param int $AccountNo |
||
| 88 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupPrivatePricing |
||
| 89 | */ |
||
| 90 | public function setAccountNo($AccountNo) |
||
| 95 | |||
| 96 | /** |
||
| 97 | * @return string |
||
| 98 | */ |
||
| 99 | public function getStrListOfRoomTypes() |
||
| 103 | |||
| 104 | /** |
||
| 105 | * @param string $strListOfRoomTypes |
||
| 106 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupPrivatePricing |
||
| 107 | */ |
||
| 108 | public function setStrListOfRoomTypes($strListOfRoomTypes) |
||
| 113 | } |
||
| 114 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.