Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | class WebRes_GetGroupBlocAvailability |
|
|
|||
6 | { |
||
7 | |||
8 | /** |
||
9 | * @var int $guid |
||
10 | */ |
||
11 | protected $guid = null; |
||
12 | |||
13 | /** |
||
14 | * @var string $LanguageCode |
||
15 | */ |
||
16 | protected $LanguageCode = null; |
||
17 | |||
18 | /** |
||
19 | * @var int $ID_Account |
||
20 | */ |
||
21 | protected $ID_Account = null; |
||
22 | |||
23 | /** |
||
24 | * @var \DateTime $StartDate |
||
25 | */ |
||
26 | protected $StartDate = null; |
||
27 | |||
28 | /** |
||
29 | * @var \DateTime $EndDate |
||
30 | */ |
||
31 | protected $EndDate = null; |
||
32 | |||
33 | /** |
||
34 | * @var TGroupBlocType $BlocType |
||
35 | */ |
||
36 | protected $BlocType = null; |
||
37 | |||
38 | /** |
||
39 | * @var TGroupBlocQtyType $BlocQtyType |
||
40 | */ |
||
41 | protected $BlocQtyType = null; |
||
42 | |||
43 | /** |
||
44 | * @param int $guid |
||
45 | * @param string $LanguageCode |
||
46 | * @param int $ID_Account |
||
47 | * @param \DateTime $StartDate |
||
48 | * @param \DateTime $EndDate |
||
49 | * @param TGroupBlocType $BlocType |
||
50 | * @param TGroupBlocQtyType $BlocQtyType |
||
51 | */ |
||
52 | public function __construct($guid, $LanguageCode, $ID_Account, \DateTime $StartDate, \DateTime $EndDate, $BlocType, $BlocQtyType) |
||
62 | |||
63 | /** |
||
64 | * @return int |
||
65 | */ |
||
66 | public function getGuid() |
||
70 | |||
71 | /** |
||
72 | * @param int $guid |
||
73 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupBlocAvailability |
||
74 | */ |
||
75 | public function setGuid($guid) |
||
80 | |||
81 | /** |
||
82 | * @return string |
||
83 | */ |
||
84 | public function getLanguageCode() |
||
88 | |||
89 | /** |
||
90 | * @param string $LanguageCode |
||
91 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupBlocAvailability |
||
92 | */ |
||
93 | public function setLanguageCode($LanguageCode) |
||
98 | |||
99 | /** |
||
100 | * @return int |
||
101 | */ |
||
102 | public function getID_Account() |
||
106 | |||
107 | /** |
||
108 | * @param int $ID_Account |
||
109 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupBlocAvailability |
||
110 | */ |
||
111 | public function setID_Account($ID_Account) |
||
116 | |||
117 | /** |
||
118 | * @return \DateTime |
||
119 | */ |
||
120 | public function getStartDate() |
||
132 | |||
133 | /** |
||
134 | * @param \DateTime $StartDate |
||
135 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupBlocAvailability |
||
136 | */ |
||
137 | public function setStartDate(\DateTime $StartDate) |
||
142 | |||
143 | /** |
||
144 | * @return \DateTime |
||
145 | */ |
||
146 | public function getEndDate() |
||
158 | |||
159 | /** |
||
160 | * @param \DateTime $EndDate |
||
161 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupBlocAvailability |
||
162 | */ |
||
163 | public function setEndDate(\DateTime $EndDate) |
||
168 | |||
169 | /** |
||
170 | * @return TGroupBlocType |
||
171 | */ |
||
172 | public function getBlocType() |
||
176 | |||
177 | /** |
||
178 | * @param TGroupBlocType $BlocType |
||
179 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupBlocAvailability |
||
180 | */ |
||
181 | public function setBlocType($BlocType) |
||
186 | |||
187 | /** |
||
188 | * @return TGroupBlocQtyType |
||
189 | */ |
||
190 | public function getBlocQtyType() |
||
194 | |||
195 | /** |
||
196 | * @param TGroupBlocQtyType $BlocQtyType |
||
197 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetGroupBlocAvailability |
||
198 | */ |
||
199 | public function setBlocQtyType($BlocQtyType) |
||
204 | } |
||
205 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.