Gueststream-Inc /
iqware
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class WebRes_GetCondoOwnerInvoiceByID |
|
|
|
|||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var string $WSlogin |
||
| 10 | */ |
||
| 11 | protected $WSlogin = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var string $WSpassword |
||
| 15 | */ |
||
| 16 | protected $WSpassword = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var int $DocumentID |
||
| 20 | */ |
||
| 21 | protected $DocumentID = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var int $PropertyGUID |
||
| 25 | */ |
||
| 26 | protected $PropertyGUID = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @param string $WSlogin |
||
| 30 | * @param string $WSpassword |
||
| 31 | * @param int $DocumentID |
||
| 32 | * @param int $PropertyGUID |
||
| 33 | */ |
||
| 34 | public function __construct($WSlogin, $WSpassword, $DocumentID, $PropertyGUID) |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @return string |
||
| 44 | */ |
||
| 45 | public function getWSlogin() |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @param string $WSlogin |
||
| 52 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerInvoiceByID |
||
| 53 | */ |
||
| 54 | public function setWSlogin($WSlogin) |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @return string |
||
| 62 | */ |
||
| 63 | public function getWSpassword() |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @param string $WSpassword |
||
| 70 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerInvoiceByID |
||
| 71 | */ |
||
| 72 | public function setWSpassword($WSpassword) |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @return int |
||
| 80 | */ |
||
| 81 | public function getDocumentID() |
||
| 85 | |||
| 86 | /** |
||
| 87 | * @param int $DocumentID |
||
| 88 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerInvoiceByID |
||
| 89 | */ |
||
| 90 | public function setDocumentID($DocumentID) |
||
| 95 | |||
| 96 | /** |
||
| 97 | * @return int |
||
| 98 | */ |
||
| 99 | public function getPropertyGUID() |
||
| 103 | |||
| 104 | /** |
||
| 105 | * @param int $PropertyGUID |
||
| 106 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerInvoiceByID |
||
| 107 | */ |
||
| 108 | public function setPropertyGUID($PropertyGUID) |
||
| 113 | } |
||
| 114 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.