Gueststream-Inc /
iqware
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class WebRes_GetCondoOwnerByReferal |
|
|
|
|||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var int $guid |
||
| 10 | */ |
||
| 11 | protected $guid = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var int $AccountNo |
||
| 15 | */ |
||
| 16 | protected $AccountNo = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string $RoomNo |
||
| 20 | */ |
||
| 21 | protected $RoomNo = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @param int $guid |
||
| 25 | * @param int $AccountNo |
||
| 26 | * @param string $RoomNo |
||
| 27 | */ |
||
| 28 | public function __construct($guid, $AccountNo, $RoomNo) |
||
| 34 | |||
| 35 | /** |
||
| 36 | * @return int |
||
| 37 | */ |
||
| 38 | public function getGuid() |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @param int $guid |
||
| 45 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerByReferal |
||
| 46 | */ |
||
| 47 | public function setGuid($guid) |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @return int |
||
| 55 | */ |
||
| 56 | public function getAccountNo() |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @param int $AccountNo |
||
| 63 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerByReferal |
||
| 64 | */ |
||
| 65 | public function setAccountNo($AccountNo) |
||
| 70 | |||
| 71 | /** |
||
| 72 | * @return string |
||
| 73 | */ |
||
| 74 | public function getRoomNo() |
||
| 78 | |||
| 79 | /** |
||
| 80 | * @param string $RoomNo |
||
| 81 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerByReferal |
||
| 82 | */ |
||
| 83 | public function setRoomNo($RoomNo) |
||
| 88 | } |
||
| 89 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.