Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | class WebRes_GetCondoOwnerAdminReservationsResult |
|
|
|||
6 | { |
||
7 | |||
8 | /** |
||
9 | * @var string $any |
||
10 | */ |
||
11 | protected $any = null; |
||
12 | |||
13 | /** |
||
14 | * @var UNKNOWN $namespace |
||
15 | */ |
||
16 | protected $namespace = null; |
||
17 | |||
18 | /** |
||
19 | * @var UNKNOWN $tableTypeName |
||
20 | */ |
||
21 | protected $tableTypeName = null; |
||
22 | |||
23 | /** |
||
24 | * @param string $any |
||
25 | * @param UNKNOWN $namespace |
||
26 | * @param UNKNOWN $tableTypeName |
||
27 | */ |
||
28 | public function __construct($any, $namespace, $tableTypeName) |
||
34 | |||
35 | /** |
||
36 | * @return string |
||
37 | */ |
||
38 | public function getAny() |
||
42 | |||
43 | /** |
||
44 | * @param string $any |
||
45 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerAdminReservationsResult |
||
46 | */ |
||
47 | public function setAny($any) |
||
52 | |||
53 | /** |
||
54 | * @return UNKNOWN |
||
55 | */ |
||
56 | public function getNamespace() |
||
60 | |||
61 | /** |
||
62 | * @param UNKNOWN $namespace |
||
63 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerAdminReservationsResult |
||
64 | */ |
||
65 | public function setNamespace($namespace) |
||
70 | |||
71 | /** |
||
72 | * @return UNKNOWN |
||
73 | */ |
||
74 | public function getTableTypeName() |
||
78 | |||
79 | /** |
||
80 | * @param UNKNOWN $tableTypeName |
||
81 | * @return \Gueststream\PMS\IQWare\API\WebRes_GetCondoOwnerAdminReservationsResult |
||
82 | */ |
||
83 | public function setTableTypeName($tableTypeName) |
||
88 | } |
||
89 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.