Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | class UnitAvailabilityCalendar |
|
|
|||
6 | { |
||
7 | |||
8 | /** |
||
9 | * @var \DateTime $CalendarDate |
||
10 | */ |
||
11 | protected $CalendarDate = null; |
||
12 | |||
13 | /** |
||
14 | * @var boolean $AvailableForArrival |
||
15 | */ |
||
16 | protected $AvailableForArrival = null; |
||
17 | |||
18 | /** |
||
19 | * @var boolean $AvailableForDeparture |
||
20 | */ |
||
21 | protected $AvailableForDeparture = null; |
||
22 | |||
23 | /** |
||
24 | * @param \DateTime $CalendarDate |
||
25 | * @param boolean $AvailableForArrival |
||
26 | * @param boolean $AvailableForDeparture |
||
27 | */ |
||
28 | public function __construct(\DateTime $CalendarDate, $AvailableForArrival, $AvailableForDeparture) |
||
34 | |||
35 | /** |
||
36 | * @return \DateTime |
||
37 | */ |
||
38 | public function getCalendarDate() |
||
50 | |||
51 | /** |
||
52 | * @param \DateTime $CalendarDate |
||
53 | * @return \Gueststream\PMS\IQWare\API\UnitAvailabilityCalendar |
||
54 | */ |
||
55 | public function setCalendarDate(\DateTime $CalendarDate) |
||
60 | |||
61 | /** |
||
62 | * @return boolean |
||
63 | */ |
||
64 | public function getAvailableForArrival() |
||
68 | |||
69 | /** |
||
70 | * @param boolean $AvailableForArrival |
||
71 | * @return \Gueststream\PMS\IQWare\API\UnitAvailabilityCalendar |
||
72 | */ |
||
73 | public function setAvailableForArrival($AvailableForArrival) |
||
78 | |||
79 | /** |
||
80 | * @return boolean |
||
81 | */ |
||
82 | public function getAvailableForDeparture() |
||
86 | |||
87 | /** |
||
88 | * @param boolean $AvailableForDeparture |
||
89 | * @return \Gueststream\PMS\IQWare\API\UnitAvailabilityCalendar |
||
90 | */ |
||
91 | public function setAvailableForDeparture($AvailableForDeparture) |
||
96 | } |
||
97 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.