Gueststream-Inc /
iqware
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class RoomLocation |
|
|
|
|||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var int $Code |
||
| 10 | */ |
||
| 11 | protected $Code = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var string $Name |
||
| 15 | */ |
||
| 16 | protected $Name = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var float $ExtraAmt |
||
| 20 | */ |
||
| 21 | protected $ExtraAmt = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var int $ExtraAmtType |
||
| 25 | */ |
||
| 26 | protected $ExtraAmtType = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var int $BillingType |
||
| 30 | */ |
||
| 31 | protected $BillingType = null; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @param int $Code |
||
| 35 | * @param float $ExtraAmt |
||
| 36 | * @param int $ExtraAmtType |
||
| 37 | * @param int $BillingType |
||
| 38 | */ |
||
| 39 | public function __construct($Code, $ExtraAmt, $ExtraAmtType, $BillingType) |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @return int |
||
| 49 | */ |
||
| 50 | public function getCode() |
||
| 54 | |||
| 55 | /** |
||
| 56 | * @param int $Code |
||
| 57 | * @return \Gueststream\PMS\IQWare\API\RoomLocation |
||
| 58 | */ |
||
| 59 | public function setCode($Code) |
||
| 64 | |||
| 65 | /** |
||
| 66 | * @return string |
||
| 67 | */ |
||
| 68 | public function getName() |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @param string $Name |
||
| 75 | * @return \Gueststream\PMS\IQWare\API\RoomLocation |
||
| 76 | */ |
||
| 77 | public function setName($Name) |
||
| 82 | |||
| 83 | /** |
||
| 84 | * @return float |
||
| 85 | */ |
||
| 86 | public function getExtraAmt() |
||
| 90 | |||
| 91 | /** |
||
| 92 | * @param float $ExtraAmt |
||
| 93 | * @return \Gueststream\PMS\IQWare\API\RoomLocation |
||
| 94 | */ |
||
| 95 | public function setExtraAmt($ExtraAmt) |
||
| 100 | |||
| 101 | /** |
||
| 102 | * @return int |
||
| 103 | */ |
||
| 104 | public function getExtraAmtType() |
||
| 108 | |||
| 109 | /** |
||
| 110 | * @param int $ExtraAmtType |
||
| 111 | * @return \Gueststream\PMS\IQWare\API\RoomLocation |
||
| 112 | */ |
||
| 113 | public function setExtraAmtType($ExtraAmtType) |
||
| 118 | |||
| 119 | /** |
||
| 120 | * @return int |
||
| 121 | */ |
||
| 122 | public function getBillingType() |
||
| 126 | |||
| 127 | /** |
||
| 128 | * @param int $BillingType |
||
| 129 | * @return \Gueststream\PMS\IQWare\API\RoomLocation |
||
| 130 | */ |
||
| 131 | public function setBillingType($BillingType) |
||
| 136 | } |
||
| 137 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.